From: "ordex (Code Review)" Date: Mon, 14 Apr 2025 19:21:32 +0000 In-Reply-To: References: Reply-To: antonio@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="VZecLjCb77U="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Reformat the whole project with clang-format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --VZecLjCb77U= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/791?usp=3Demail ) Change subject: Reformat the whole project with clang-format ...................................................................... Patch Set 14: (8 comments) Patchset: PS14: the change is extremely long, so not easy to comment to everything, but I t= hrew a few concerns worth checking. File sample/sample-plugins/client-connect/sample-client-connect.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/c6e0d1ce_30cbe3ba : PS14, Line 135: stderr, this hurts me a bit, for two reasons: 1) "stderr," should just stay on the same line as fprintf, given that there= is enough space; 2) when going to a new line, I personally prefer to see the text aligned to= the opening parenthesis. http://gerrit.openvpn.net/c/openvpn/+/791/comment/27a22e79_01461376 : PS14, Line 251: MODULE, same as above, I expected MODULE to be on the line above NOTE: I won't report any other occurrence of this in the rest of the patch http://gerrit.openvpn.net/c/openvpn/+/791/comment/3682efec_128649c3 : PS14, Line 252: "env has UV_WANT_CC_ASYNC=3D%d, but " here there is a more generic question to answer: do we want to keep string = on the same line, even if they are too long? Pro being that the casual reader could be reasonably able to grep an error = message (with some magic, due to format patterns). File sample/sample-plugins/defer/multi-auth.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/e5889e88_f1a4caaa : PS14, Line 267: np(context->test_valid_user), I'd vote for putting these arguments on the same line, if there is enough s= pace. http://gerrit.openvpn.net/c/openvpn/+/791/comment/8f6e4102_5edbebdb : PS14, Line 294: const char *envp[]) ratio behind this change? one arg per line? http://gerrit.openvpn.net/c/openvpn/+/791/comment/99dbd0d9_8682fdd3 : PS14, Line 418: plog(context, PLOG_NOTE, "FUNC: openvpn_plugin_client_c= onstructor_v1"); how about forcing a new line after variables declaration? File sample/sample-plugins/log/log_v3.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/c1025c39_05185d3b : PS14, Line 87: "log_v3: ** ERROR ** Incompatible plug-in interf= ace between this plug-in and OpenVPN\n"); this is probably another instance of the same situation as before. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/791?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e Gerrit-Change-Number: 791 Gerrit-PatchSet: 14 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: ordex Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 14 Apr 2025 19:21:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --VZecLjCb77U= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

View C= hange

8 comments:

    =
  • Patchset:

    • Patch Set #14:

      the change is extremely long, so not easy to com= ment to everything, but I threw a few concerns worth checking.

    • File sample/sample-plugins/cl= ient-connect/sample-client-connect.c:

      • Patch Set #14, Line 135: stderr,

        this hurts me a bit, for two reasons:1) "stderr," should just stay on the same line as fprintf, given= that there is enough space;
        2) when going to a new line, I personally p= refer to see the text aligned to the opening parenthesis.

      • = Patch Set #14, Line 251: MODULE,

        same as above, I expected MODULE to be on the line a= bove

        NOTE: I = won't report any other occurrence of this in the rest of the patch

        <= /li>
      • Patch Set #14, Line 252: "env has UV_WANT_CC_ASYNC=3D%d, but = "

        here there is a more generic question to answer: do we want to keep string= on the same line, even if they are too long?
        Pro being that the casual = reader could be reasonably able to grep an error message (with some magic, = due to format patterns).

    • File sample/sample-plugins/defer/multi-auth.c:

    • File sample/sample-plugins/log/log_v3.c:

      • Patch Set #14, Line 87: "log_v3: ** = ERROR ** Incompatible plug-in interface between this plug-in and OpenVPN\n&= quot;);

        change 791. To unsubscribe, or for help writi= ng mail filters, visit setti= ngs.

        Gerrit-Project: openvpn
        Gerrit-Branch: master
        Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b= 8973463404e3e
        Gerrit-Change-Number: 791
        Gerrit-PatchSet: 14
        Gerrit-Owner: flichtenheld <frank@...2723...= .>
        Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
        Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
        Gerrit-CC: ordex <antonio@...2726...>
        Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
        Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
        Gerrit-Comment-Date: Mon, 14 Apr 2025 19:21:32= +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Gerrit-MessageType: comment
        --VZecLjCb77U=--