Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ABA4C43461 for ; Fri, 11 Sep 2020 05:40:25 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AB42208FE for ; Fri, 11 Sep 2020 05:40:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AB42208FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kGbn8-0000Xh-L4; Fri, 11 Sep 2020 05:40:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kGbn7-0000Xc-3I for xen-devel@lists.xenproject.org; Fri, 11 Sep 2020 05:40:09 +0000 X-Inumbo-ID: cc26030c-aa45-4b2c-ba35-ccf95c33965c Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cc26030c-aa45-4b2c-ba35-ccf95c33965c; Fri, 11 Sep 2020 05:40:08 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D4A02B384; Fri, 11 Sep 2020 05:40:22 +0000 (UTC) Subject: Re: Regression: [PATCH v10 10/12] tools/libxl: use libxenhypfs for setting xen runtime parameters To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Anthony PERARD , Ian Jackson , Wei Liu References: <20200519072106.26894-1-jgross@suse.com> <20200519072106.26894-11-jgross@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Fri, 11 Sep 2020 07:40:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 10.09.20 22:09, Andrew Cooper wrote: > On 19/05/2020 08:21, Juergen Gross wrote: >> Instead of xc_set_parameters() use xenhypfs_write() for setting >> parameters of the hypervisor. >> >> Signed-off-by: Juergen Gross > > Something here isn't right.  XenServer's testing for XSA-304 has shown > the following bizarre behaviour. > > # xl set-parameters ept= > libxl: error: libxl.c:701:libxl_set_parameters: setting parameters: > Invalid argument > cannot set parameters: ept= > # xl set-parameters ept=exec-sp > # xl set-parameters ept=no-exec-sp > libxl: error: libxl.c:701:libxl_set_parameters: setting parameters: No > space left on device > cannot set parameters: ept=no-exec-sp > > Instrumentation shows that the first two examples here enter > parse_ept_param_runtime() with the provided string, while the third > example doesn't. > > Given the -ENOSPC, I'm guessing there is some overly small internal > buffer somewhere in the hyperfs infrastructure ? Not, really, just a bad test for max length. Patch sent. Juergen