From: "Gustavo A. R. Silva" Subject: Re: [PATCH] IB/hfi1: Add missing break in switch statement Date: Thu, 21 Feb 2019 15:26:22 -0600 Message-ID: References: <20190221010233.GA29228@embeddedor> <20190221210902.GA25062@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190221210902.GA25062@ziepe.ca> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Jason Gunthorpe Cc: Kaike Wan , Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook List-Id: linux-rdma@vger.kernel.org On 2/21/19 3:09 PM, Jason Gunthorpe wrote: > On Wed, Feb 20, 2019 at 07:02:33PM -0600, Gustavo A. R. Silva wrote: >> Fix the following warning by adding a missing break: >> >> drivers/infiniband/hw/hfi1/tid_rdma.c: In function ‘hfi1_tid_rdma_wqe_interlock’: >> drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may fall through [-Wimplicit-fallthrough=] >> switch (prev->wr.opcode) { >> ^~~~~~ >> drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here >> case IB_WR_RDMA_READ: >> ^~~~ >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> This patch is part of the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Fixes: c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and other requests") >> Signed-off-by: Gustavo A. R. Silva >> Reviewed-by: Kaike Wan >> -- >> drivers/infiniband/hw/hfi1/tid_rdma.c | 1 + >> 1 file changed, 1 insertion(+) > > Applied to for-next, thanks > Great. :) Thank you both, Kaike and Jason. -- Gustavo