References: <20190613134834.5709-1-arne@...1227...> From: David Sommerseth Message-ID: Date: Tue, 25 Jun 2019 22:08:29 +0200 MIME-Version: 1.0 In-Reply-To: <20190613134834.5709-1-arne@...1227...> Content-Language: en-GB Subject: Re: [Openvpn-devel] [PATCH v4 2/7] Implement --genkey type keyfile syntax and migrate tls-crypt-v2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: Arne Schwabe , openvpn-devel@lists.sourceforge.net On 13/06/2019 15:48, Arne Schwabe wrote: > This unifies our key generation and also migrates the generation > of the tls-crypt-v2 keys. Since tls-crypt-v2 is not included in any > released version, we remove the the old syntax without compatibility. > > PATCH V4: Introduce warning/error when using --secret with --genkey > Update non code usages to use new --genkey syntax > --- > INSTALL | 2 +- > doc/openvpn.8 | 81 ++++++++++++++------------ > sample/sample-config-files/server.conf | 2 +- > sample/sample-keys/gen-sample-keys.sh | 2 +- > sample/sample-windows/sample.ovpn | 2 +- > src/openvpn/crypto.c | 2 +- > src/openvpn/init.c | 71 ++++++++++++++-------- > src/openvpn/options.c | 67 +++++++++++++-------- > src/openvpn/options.h | 11 +++- > tests/t_lpback.sh | 8 +-- > 10 files changed, 151 insertions(+), 97 deletions(-) > Acked-by: David Sommerseth Looks good now, 'make check' passes and behaviour is more consistent. -- kind regards, David Sommerseth OpenVPN Inc