From: "MaxF (Code Review)" Date: Tue, 18 Jun 2024 12:41:20 +0000 In-Reply-To: References: Reply-To: max@...2606..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="6JCGjD41JMU="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: mbedtls: Remove support for old TLS versions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , flichtenheld , openvpn-devel --6JCGjD41JMU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MaxF has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/682= ?usp=3Demail ) Change subject: mbedtls: Remove support for old TLS versions ...................................................................... mbedtls: Remove support for old TLS versions Recent versions of mbedtls have dropped support for TLS 1.0 and 1.1. Rather than checking which versions are supported, drop support for everything before 1.2. Change-Id: Ia3883a26ac26df6bbb5353fb074a2e0f814737be Signed-off-by: Max Fillinger Reviewed-on: http://gerrit.openvpn.net/c/openvpn/+/682 Reviewed-by: plaisthos --- M src/openvpn/ssl_mbedtls.c 1 file changed, 1 insertion(+), 19 deletions(-) Approvals: plaisthos: Looks good to me, approved diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.c index a68588e..ec9ec13 100644 --- a/src/openvpn/ssl_mbedtls.c +++ b/src/openvpn/ssl_mbedtls.c @@ -1040,12 +1040,8 @@ { #if defined(MBEDTLS_SSL_PROTO_TLS1_2) return TLS_VER_1_2; -#elif defined(MBEDTLS_SSL_PROTO_TLS1_1) - return TLS_VER_1_1; -#elif defined(MBEDTLS_SSL_PROTO_TLS1) - return TLS_VER_1_0; #else /* defined(MBEDTLS_SSL_PROTO_TLS1_2) */ - #error "mbedtls is compiled without support for TLS 1.0, 1.1 and 1.2." + #error "mbedtls is compiled without support for TLS 1.2." #endif /* defined(MBEDTLS_SSL_PROTO_TLS1_2) */ } @@ -1067,20 +1063,6 @@ switch (tls_ver) { -#if defined(MBEDTLS_SSL_PROTO_TLS1) - case TLS_VER_1_0: - *major =3D MBEDTLS_SSL_MAJOR_VERSION_3; - *minor =3D MBEDTLS_SSL_MINOR_VERSION_1; - break; -#endif - -#if defined(MBEDTLS_SSL_PROTO_TLS1_1) - case TLS_VER_1_1: - *major =3D MBEDTLS_SSL_MAJOR_VERSION_3; - *minor =3D MBEDTLS_SSL_MINOR_VERSION_2; - break; -#endif - #if defined(MBEDTLS_SSL_PROTO_TLS1_2) case TLS_VER_1_2: *major =3D MBEDTLS_SSL_MAJOR_VERSION_3; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/682?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia3883a26ac26df6bbb5353fb074a2e0f814737be Gerrit-Change-Number: 682 Gerrit-PatchSet: 3 Gerrit-Owner: MaxF Gerrit-Reviewer: MaxF Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: merged --6JCGjD41JMU= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

MaxF submitted this change.

View Change

Approvals: plaisthos: Looks good to me, approved
mbedtls: Remove support for old TLS versions

Recent versions of m= bedtls have dropped support for TLS 1.0 and 1.1.
Rather than checking wh= ich versions are supported, drop support for
everything before 1.2.
<= br>Change-Id: Ia3883a26ac26df6bbb5353fb074a2e0f814737be
Signed-off-by: M= ax Fillinger <maximilian.fillinger@...2507...>
Reviewed-on: http:/= /gerrit.openvpn.net/c/openvpn/+/682
Reviewed-by: plaisthos <arne-open= vpn@...1227...>
---
M src/openvpn/ssl_mbedtls.c
1 file changed,= 1 insertion(+), 19 deletions(-)

diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.c
index a68588e..ec9ec13 100644
--- a/src/openvpn/= ssl_mbedtls.c
+++ b/src/openvpn/ssl_mbedtls.c
@@ -1040,12 +1040,8 @@
{
#if defined(M= BEDTLS_SSL_PROTO_TLS1_2)
return TLS_VER_1_2;-#elif defined(MBEDTLS_SSL_PROTO= _TLS1_1)
- return TL= S_VER_1_1;
-#elif defin= ed(MBEDTLS_SSL_PROTO_TLS1)
- return TLS_VER_1_0;
#else /* defined(MBEDTLS_SSL_= PROTO_TLS1_2) */
- #= error "mbedtls is compiled without support for TLS 1.0, 1.1 and 1.2.&q= uot;
+ #error &quo= t;mbedtls is compiled without support for TLS 1.2."
#= endif /* defined(MBEDTLS_SSL_PROTO_TLS1_2) */
}
=
@@ -1067,20 +1063,6 @@

= switch (tls_ver)
{
-#if defined(MBEDTLS_SSL_PROTO_TLS1)
= - case TLS_VER_1_0:=
- *major =3D MBEDT= LS_SSL_MAJOR_VERSION_3;
- *minor =3D MBEDTLS_SSL_MINOR_VERSION_1;
- break;
-#endif
-
-#if def= ined(MBEDTLS_SSL_PROTO_TLS1_1)
- case TLS_VER_1_1:
- *major =3D MBEDTLS_SSL_MAJOR_VERSION_3;
= - *minor =3D MBEDTLS_S= SL_MINOR_VERSION_2;
- = break;
-#endi= f
-
#i= f defined(MBEDTLS_SSL_PROTO_TLS1_2)
case TLS_VER_1= _2:
*major =3D MBEDTLS_SSL_MAJOR_VERSION_3;

To view, visit change 682. To unsubscribe, or = for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia3883a26ac26df6bbb5353fb074= a2e0f814737be
Gerrit-Change-Number: 682
Gerrit-PatchSet: 3
Gerrit-Owner: MaxF <max@...2606...>
Gerrit-Reviewer: MaxF <max@...2606...> <= /div>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: merged
--6JCGjD41JMU=--