References: <20200416134925.8848-1-a@...2181...> From: Antonio Quartulli Message-ID: Date: Thu, 16 Apr 2020 15:51:31 +0200 MIME-Version: 1.0 In-Reply-To: <20200416134925.8848-1-a@...2181...> Content-Language: en-US Subject: Re: [Openvpn-devel] [PATCH] t_net.sh: use dummy interface instead of tun List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: openvpn-devel@lists.sourceforge.net Hi, On 16/04/2020 15:49, Antonio Quartulli wrote: > The tun interface has proved to be a bit fragile for basic netlink tests > as it may introduce delays in switching state, depending on the system > the test is ran on. > > For this reason, switch to dummy interface type and at the same type > set its oper-state to up right after creation to avoid hitting the > no-carrier state later. No-carrier has been problematic in pasts tests > as it sometimes persists long enough to create a discrepancy between the > various tests snapshots thus causing a test failure. > > Setting a static MAC addressis also re-enabled to avoid it being > different and thus causing a test failure when comparing snapshots. > > Signed-off-by: Antonio Quartulli This patch has gone through buildbot a couple of times and I was never able to trigger the usual failure that we saw until now. -- Antonio Quartulli