From: Maarten Lankhorst Subject: Re: [PATCH 12/24] drm/i915: Split plane hw and uapi state Date: Wed, 9 Oct 2019 14:13:55 +0200 Message-ID: References: <20191004113514.17064-1-maarten.lankhorst@linux.intel.com> <20191004113514.17064-13-maarten.lankhorst@linux.intel.com> <20191008174231.GU1208@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id CFB576E2F0 for ; Wed, 9 Oct 2019 12:13:57 +0000 (UTC) In-Reply-To: <20191008174231.GU1208@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMDgtMTAtMjAxOSBvbSAxOTo0MiBzY2hyZWVmIFZpbGxlIFN5cmrDpGzDpDoKPiBPbiBGcmks IE9jdCAwNCwgMjAxOSBhdCAwMTozNTowMlBNICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90 ZToKPj4gU3BsaXR0aW5nIHBsYW5lIHN0YXRlIGlzIGVhc2llciB0aGFuIHNwbGl0dGluZyBjcnRj X3N0YXRlLAo+PiBiZWZvcmUgcGxhbmUgY2hlY2sgd2UgY29weSB0aGUgZHJtIHByb3BlcnRpZXMg dG8gaHcgc28gd2UgY2FuCj4+IGRvIHRoZSBzYW1lIGluIGJpZ2pvaW5lciBsYXRlciBvbi4KPj4K Pj4gV2UgY29weSB0aGUgc3RhdGUgYWZ0ZXIgd2UgZGlkIGFsbCB0aGUgbW9kZXNldCBoYW5kbGlu ZywgYnV0IGZvcnR1bmF0ZWx5Cj4+IGk5MTUgc2VlbXMgdG8gYmUgc3BsaXQgY29ycmVjdGx5IGFu ZCBub3RoaW5nIGR1cmluZyBtb2Rlc2V0IGxvb2tzCj4+IGF0IHBsYW5lX3N0YXRlLgo+Pgo+PiBT aWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXgu aW50ZWwuY29tPgo+PiAtLS0KPj4gIC4uLi9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hdG9t aWNfcGxhbmUuYyB8IDM3ICsrKysrKysrKysrKysrKysrKy0KPj4gIC4uLi9ncHUvZHJtL2k5MTUv ZGlzcGxheS9pbnRlbF9hdG9taWNfcGxhbmUuaCB8ICAyICsKPj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jICB8ICAxICsKPj4gIC4uLi9kcm0vaTkxNS9kaXNw bGF5L2ludGVsX2Rpc3BsYXlfdHlwZXMuaCAgICB8IDIyICsrKysrKysrKy0tCj4+ICA0IGZpbGVz IGNoYW5nZWQsIDU3IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2F0b21pY19wbGFuZS5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hdG9taWNfcGxhbmUuYwo+PiBpbmRl eCAwMTkzNzg5NmQ2OWMuLmNjMTU0Y2ZhMzM4MSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hdG9taWNfcGxhbmUuYwo+PiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2F0b21pY19wbGFuZS5jCj4+IEBAIC05Myw2ICs5Myw5 IEBAIGludGVsX3BsYW5lX2R1cGxpY2F0ZV9zdGF0ZShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSkK Pj4gIAlpbnRlbF9zdGF0ZS0+dm1hID0gTlVMTDsKPj4gIAlpbnRlbF9zdGF0ZS0+ZmxhZ3MgPSAw Owo+PiAgCj4+ICsJLyogd2lsbCBiZSBzZXQgaW4gaW50ZWxfcGxhbmVfYXRvbWljX2NoZWNrX3dp dGhfc3RhdGUoKSAqLwo+PiArCW1lbXNldCgmaW50ZWxfc3RhdGUtPmh3LCAwLCBzaXplb2YoaW50 ZWxfc3RhdGUtPmh3KSk7Cj4gVGhhdCBzZWVtcyB3cm9uZyBmb3IgdGhlIGNhc2Ugd2hlcmUgd2Ug YWRkIHRoZSBwbGFuZSBhZnRlciB0aGUKPiBwbGFuZSBjaGVjayBoYXMgYWxyZWFkeSBiZWVuIGRv bmUuCj4KPiBJIHRoaW5rIHdlIHNob3VsZCBtYWludGFpbiB0aGUgY3VycmVudCBzdGF0ZSB1bmxl c3MgdGhlIHBsYW5lIGNoZWNrCj4gd2lsbCBvdmVyd3JpdGUgaXQuCkhhdmUgeW91IHNlZW4KCmlu dGVsX2F0b21pY19nZXRfcGxhbmVfc3RhdGVfYWZ0ZXJfY2hlY2soKT8KCj4+ICsKPj4gIAlyZXR1 cm4gJmludGVsX3N0YXRlLT51YXBpOwo+PiAgfQo+PiAgCj4+IEBAIC0xMTIsNiArMTE1LDggQEAg aW50ZWxfcGxhbmVfZGVzdHJveV9zdGF0ZShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPj4gIAlX QVJOX09OKHBsYW5lX3N0YXRlLT52bWEpOwo+PiAgCj4+ICAJX19kcm1fYXRvbWljX2hlbHBlcl9w bGFuZV9kZXN0cm95X3N0YXRlKCZwbGFuZV9zdGF0ZS0+dWFwaSk7Cj4+ICsJaWYgKHBsYW5lX3N0 YXRlLT5ody5mYikKPj4gKwkJZHJtX2ZyYW1lYnVmZmVyX3B1dChwbGFuZV9zdGF0ZS0+aHcuZmIp Owo+PiAgCWtmcmVlKHBsYW5lX3N0YXRlKTsKPj4gIH0KPj4gIAo+PiBAQCAtMTM4LDE1ICsxNDMs MzQgQEAgdW5zaWduZWQgaW50IGludGVsX3BsYW5lX2RhdGFfcmF0ZShjb25zdCBzdHJ1Y3QgaW50 ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPj4gIAlyZXR1cm4gY3BwICogY3J0Y19zdGF0ZS0+ cGl4ZWxfcmF0ZTsKPj4gIH0KPj4gIAo+PiArdm9pZCBpbnRlbF9wbGFuZV9jb3B5X3VhcGlfdG9f aHdfc3RhdGUoc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSwKPj4gKwkJCQkg ICAgICAgY29uc3Qgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpmcm9tX3BsYW5lX3N0YXRlKQo+ PiArewo+PiArCXBsYW5lX3N0YXRlLT5ody5jcnRjID0gZnJvbV9wbGFuZV9zdGF0ZS0+dWFwaS5j cnRjOwo+PiArCXBsYW5lX3N0YXRlLT5ody5mYiA9IGZyb21fcGxhbmVfc3RhdGUtPnVhcGkuZmI7 Cj4+ICsJaWYgKHBsYW5lX3N0YXRlLT5ody5mYikKPj4gKwkJZHJtX2ZyYW1lYnVmZmVyX2dldChw bGFuZV9zdGF0ZS0+aHcuZmIpOwo+PiArCj4+ICsJcGxhbmVfc3RhdGUtPmh3LmFscGhhID0gZnJv bV9wbGFuZV9zdGF0ZS0+dWFwaS5hbHBoYTsKPj4gKwlwbGFuZV9zdGF0ZS0+aHcucGl4ZWxfYmxl bmRfbW9kZSA9Cj4+ICsJCWZyb21fcGxhbmVfc3RhdGUtPnVhcGkucGl4ZWxfYmxlbmRfbW9kZTsK Pj4gKwlwbGFuZV9zdGF0ZS0+aHcucm90YXRpb24gPSBmcm9tX3BsYW5lX3N0YXRlLT51YXBpLnJv dGF0aW9uOwo+PiArCXBsYW5lX3N0YXRlLT5ody5jb2xvcl9lbmNvZGluZyA9IGZyb21fcGxhbmVf c3RhdGUtPnVhcGkuY29sb3JfZW5jb2Rpbmc7Cj4+ICsJcGxhbmVfc3RhdGUtPmh3LmNvbG9yX3Jh bmdlID0gZnJvbV9wbGFuZV9zdGF0ZS0+dWFwaS5jb2xvcl9yYW5nZTsKPj4gK30KPj4gKwo+PiAg aW50IGludGVsX3BsYW5lX2F0b21pY19jaGVja193aXRoX3N0YXRlKGNvbnN0IHN0cnVjdCBpbnRl bF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSwKPj4gIAkJCQkJc3RydWN0IGludGVsX2NydGNf c3RhdGUgKm5ld19jcnRjX3N0YXRlLAo+PiAgCQkJCQljb25zdCBzdHJ1Y3QgaW50ZWxfcGxhbmVf c3RhdGUgKm9sZF9wbGFuZV9zdGF0ZSwKPj4gIAkJCQkJc3RydWN0IGludGVsX3BsYW5lX3N0YXRl ICpuZXdfcGxhbmVfc3RhdGUpCj4+ICB7Cj4+ICAJc3RydWN0IGludGVsX3BsYW5lICpwbGFuZSA9 IHRvX2ludGVsX3BsYW5lKG5ld19wbGFuZV9zdGF0ZS0+dWFwaS5wbGFuZSk7Cj4+IC0JY29uc3Qg c3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBuZXdfcGxhbmVfc3RhdGUtPmh3LmZiOwo+PiAr CWNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiOwo+PiAgCWludCByZXQ7Cj4+ICAKPj4g KwlpbnRlbF9wbGFuZV9jb3B5X3VhcGlfdG9faHdfc3RhdGUobmV3X3BsYW5lX3N0YXRlLCBuZXdf cGxhbmVfc3RhdGUpOwo+PiArCWZiID0gbmV3X3BsYW5lX3N0YXRlLT5ody5mYjsKPj4gKwo+PiAg CW5ld19jcnRjX3N0YXRlLT5hY3RpdmVfcGxhbmVzICY9IH5CSVQocGxhbmUtPmlkKTsKPj4gIAlu ZXdfY3J0Y19zdGF0ZS0+bnYxMl9wbGFuZXMgJj0gfkJJVChwbGFuZS0+aWQpOwo+PiAgCW5ld19j cnRjX3N0YXRlLT5jOF9wbGFuZXMgJj0gfkJJVChwbGFuZS0+aWQpOwo+PiBAQCAtMzczLDYgKzM5 Nyw3IEBAIGludGVsX2F0b21pY19nZXRfcGxhbmVfc3RhdGVfYWZ0ZXJfY2hlY2soc3RydWN0IGlu dGVsX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4+ICB7Cj4+ICAJc3RydWN0IGludGVsX3BsYW5lX3N0 YXRlICpwbGFuZV9zdGF0ZSA9Cj4+ICAJCWludGVsX2F0b21pY19nZXRfbmV3X3BsYW5lX3N0YXRl KHN0YXRlLCBwbGFuZSk7Cj4+ICsJY29uc3Qgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpvbGRf cGxhbmVfc3RhdGU7Cj4+ICAKPj4gIAlpZiAocGxhbmVfc3RhdGUpCj4+ICAJCXJldHVybiBwbGFu ZV9zdGF0ZTsKPj4gQEAgLTM4MSw2ICs0MDYsMTYgQEAgaW50ZWxfYXRvbWljX2dldF9wbGFuZV9z dGF0ZV9hZnRlcl9jaGVjayhzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpzdGF0ZSwKPj4gIAlp ZiAoSVNfRVJSKHBsYW5lX3N0YXRlKSkKPj4gIAkJcmV0dXJuIHBsYW5lX3N0YXRlOwo+PiAgCj4+ ICsJb2xkX3BsYW5lX3N0YXRlID0gaW50ZWxfYXRvbWljX2dldF9vbGRfcGxhbmVfc3RhdGUoc3Rh dGUsIHBsYW5lKTsKPj4gKwo+PiArCS8qCj4+ICsJICogY29weSBIVyBwYXJhbWV0ZXJzIHNpbmNl IHRoZXkncmUgemVybydkIG9uIGR1cGxpY2F0aW9uLCB0byBwcmV2ZW50Cj4+ICsJICogYWNjaWRl bnRhbGx5IHVzaW5nIHN0YWxlIHN0YXRlLgo+PiArCSAqLwo+PiArCXBsYW5lX3N0YXRlLT5odyA9 IG9sZF9wbGFuZV9zdGF0ZS0+aHc7Cj4+ICsJaWYgKHBsYW5lX3N0YXRlLT5ody5mYikKPj4gKwkJ ZHJtX2ZyYW1lYnVmZmVyX2dldChwbGFuZV9zdGF0ZS0+aHcuZmIpOwo+PiArCj4+ICAJbmV3X2Ny dGNfc3RhdGUtPnVwZGF0ZV9wbGFuZXMgfD0gQklUKHBsYW5lLT5pZCk7Cj4+ICAJcmV0dXJuIHBs YW5lX3N0YXRlOwo+PiAgfQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9hdG9taWNfcGxhbmUuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkv aW50ZWxfYXRvbWljX3BsYW5lLmgKPj4gaW5kZXggY2I3ZWY0ZjllYWZkLi5mZDRiOTYwMTM0NTQg MTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYXRvbWlj X3BsYW5lLmgKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hdG9t aWNfcGxhbmUuaAo+PiBAQCAtMjAsNiArMjAsOCBAQCBleHRlcm4gY29uc3Qgc3RydWN0IGRybV9w bGFuZV9oZWxwZXJfZnVuY3MgaW50ZWxfcGxhbmVfaGVscGVyX2Z1bmNzOwo+PiAgCj4+ICB1bnNp Z25lZCBpbnQgaW50ZWxfcGxhbmVfZGF0YV9yYXRlKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpjcnRjX3N0YXRlLAo+PiAgCQkJCSAgIGNvbnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0 ZSAqcGxhbmVfc3RhdGUpOwo+PiArdm9pZCBpbnRlbF9wbGFuZV9jb3B5X3VhcGlfdG9faHdfc3Rh dGUoc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSwKPj4gKwkJCQkgICAgICAg Y29uc3Qgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpmcm9tX3BsYW5lX3N0YXRlKTsKPj4gIHZv aWQgaW50ZWxfdXBkYXRlX3BsYW5lKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUsCj4+ICAJCQlj b25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPj4gIAkJCWNvbnN0IHN0 cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpOwo+PiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+PiBpbmRleCAwZWU1NDI4NDBjNzAuLmZm ZGU0YjhiOGJlOSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9p bnRlbF9kaXNwbGF5LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRl bF9kaXNwbGF5LmMKPj4gQEAgLTMyNjcsNiArMzI2Nyw3IEBAIGludGVsX2ZpbmRfaW5pdGlhbF9w bGFuZV9vYmooc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMsCj4+ICAKPj4gIAlwbGFuZV9z dGF0ZS0+ZmIgPSBmYjsKPj4gIAlwbGFuZV9zdGF0ZS0+Y3J0YyA9ICZpbnRlbF9jcnRjLT5iYXNl Owo+PiArCWludGVsX3BsYW5lX2NvcHlfdWFwaV90b19od19zdGF0ZShpbnRlbF9zdGF0ZSwgaW50 ZWxfc3RhdGUpOwo+PiAgCj4+ICAJYXRvbWljX29yKHRvX2ludGVsX3BsYW5lKHByaW1hcnkpLT5m cm9udGJ1ZmZlcl9iaXQsCj4+ICAJCSAgJnRvX2ludGVsX2Zyb250YnVmZmVyKGZiKS0+Yml0cyk7 Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3Bs YXlfdHlwZXMuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheV90 eXBlcy5oCj4+IGluZGV4IGM2YzQ5YWE4YzE3Mi4uNjc2NDQ4MThlZmQyIDEwMDY0NAo+PiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXlfdHlwZXMuaAo+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXlfdHlwZXMuaAo+ PiBAQCAtNTE1LDEwICs1MTUsMjQgQEAgc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSB7Cj4+ICB9 Owo+PiAgCj4+ICBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgewo+PiAtCXVuaW9uIHsKPj4gLQkJ c3RydWN0IGRybV9wbGFuZV9zdGF0ZSB1YXBpOwo+PiAtCQlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRl IGh3Owo+PiAtCX07Cj4+ICsJc3RydWN0IGRybV9wbGFuZV9zdGF0ZSB1YXBpOwo+PiArCj4+ICsJ LyoKPj4gKwkgKiBhY3R1YWwgaGFyZHdhcmUgc3RhdGUsIHRoZSBzdGF0ZSB3ZSBwcm9ncmFtIHRv IHRoZSBoYXJkd2FyZS4KPj4gKwkgKiBUaGUgZm9sbG93aW5nIG1lbWJlcnMgYXJlIHVzZWQgdG8g dmVyaWZ5IHRoZSBoYXJkd2FyZSBzdGF0ZToKPj4gKwkgKiBEdXJpbmcgaW5pdGlhbCBodyByZWFk b3V0LCB0aGV5IG5lZWQgdG8gYmUgY29waWVkIGZyb20gdWFwaS4KPj4gKwkgKi8KPj4gKwlzdHJ1 Y3Qgewo+PiArCQlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4+ICsJCXN0cnVjdCBkcm1fZnJhbWVi dWZmZXIgKmZiOwo+PiArCj4+ICsJCXUxNiBhbHBoYTsKPj4gKwkJdWludDE2X3QgcGl4ZWxfYmxl bmRfbW9kZTsKPj4gKwkJdW5zaWduZWQgaW50IHJvdGF0aW9uOwo+PiArCQllbnVtIGRybV9jb2xv cl9lbmNvZGluZyBjb2xvcl9lbmNvZGluZzsKPj4gKwkJZW51bSBkcm1fY29sb3JfcmFuZ2UgY29s b3JfcmFuZ2U7Cj4+ICsJfSBodzsKPj4gKwo+PiAgCXN0cnVjdCBpOTE1X2dndHRfdmlldyB2aWV3 Owo+PiAgCXN0cnVjdCBpOTE1X3ZtYSAqdm1hOwo+PiAgCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4+ IC0tIAo+PiAyLjIzLjAKPj4KPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+PiBJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4