Content-Type: multipart/mixed; boundary="===============4925248390735507310==" MIME-Version: 1.0 From: Jason Wang To: kbuild-all@lists.01.org Subject: Re: [PATCH] vdpa: bypass waking up vhost_woker for vdpa vq kick Date: Tue, 02 Jun 2020 19:10:38 +0800 Message-ID: In-Reply-To: List-Id: --===============4925248390735507310== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 2020/6/2 =E4=B8=8B=E5=8D=886:16, Jason Wang wrote: > > On 2020/6/2 =E4=B8=8B=E5=8D=885:42, Dan Carpenter wrote: >> Hi Zhu, >> >> url: = >> https://github.com/0day-ci/linux/commits/Zhu-Lingshan/vdpa-bypass-waking= -up-vhost_woker-for-vdpa-vq-kick/20200526-133819 = >> >> base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git = >> linux-next >> config: x86_64-randconfig-m001-20200529 (attached as .config) >> compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kbuild test robot >> Reported-by: Dan Carpenter >> >> smatch warnings: >> drivers/vhost/vdpa.c:348 vhost_vdpa_set_vring_kick() error: = >> uninitialized symbol 'r'. >> >> # = >> https://github.com/0day-ci/linux/commit/a84ddbf1ef29f18aafb2bb8a93bcedd4= a29a967d = >> >> git remote add linux-review https://github.com/0day-ci/linux >> git remote update linux-review >> git checkout a84ddbf1ef29f18aafb2bb8a93bcedd4a29a967d >> vim +/r +348 drivers/vhost/vdpa.c >> >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 316=C2=A0 static long = >> vhost_vdpa_set_vring_kick(struct vhost_virtqueue *vq, >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 317=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = >> void __user *argp) >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 318=C2=A0 { >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 319=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 bool pollstart =3D = >> false, pollstop =3D false; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 320=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 struct file = >> *eventfp, *filep =3D NULL; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 321=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 struct = >> vhost_vring_file f; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 322=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 long r; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 323 >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 324=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 if = >> (copy_from_user(&f, argp, sizeof(f))) >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 325=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -EFAULT; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 326 >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 327=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 eventfp =3D f.fd =3D=3D -1 = >> ? NULL : eventfd_fget(f.fd); >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 328=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 if (IS_ERR(eventfp)) { >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 329=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 r =3D = >> PTR_ERR(eventfp); >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 330=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return r; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 331=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 } >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 332 >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 333=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 if (eventfp !=3D = >> vq->kick) { >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 334=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pollstop =3D = >> (filep =3D vq->kick) !=3D NULL; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 335=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pollstart =3D = >> (vq->kick =3D eventfp) !=3D NULL; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 336=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 } else >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 337=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 filep =3D eventfp; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 338 >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 339=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 if (pollstop && = >> vq->handle_kick) >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 340 vhost_vdpa_poll_stop(vq= ); >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 341 >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 342=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 if (filep) >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 343 fput(filep); >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 344 >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 345=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 if (pollstart && = >> vq->handle_kick) >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 346=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 r =3D = >> vhost_vdpa_poll_start(vq); >> >> "r" not initialized on else path. >> >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 347 >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26 @348=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 return r; >> a84ddbf1ef29f1 Zhu Lingshan 2020-05-26=C2=A0 349=C2=A0 } > > > Will fix. > > Thanks = Lingshan reminds me that we've posted V2 which reuses the vhost.c = implementation for polling. So there's no need for the fix. Thanks --===============4925248390735507310==--