From: "cron2 (Code Review)" Date: Mon, 13 Jan 2025 11:43:27 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., a@...2181... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="02Vag9pjios="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Fix 'uninitialized pointer read' in openvpn_decrypt_aead List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --02Vag9pjios= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/858?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by ordex Change subject: Fix 'uninitialized pointer read' in openvpn_decrypt_aead ...................................................................... Fix 'uninitialized pointer read' in openvpn_decrypt_aead Coverity complains that if we error out in the first error condition we try to free gc without initializing it. While here move the declaration of outlen to the first usage. Change-Id: I0391f30a1e962ee242e9bcdec4f605bf7e831cca Signed-off-by: Frank Lichtenheld Acked-by: Antonio Quartulli Message-Id: <20250113112226.17728-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30= 421.html Signed-off-by: Gert Doering --- M src/openvpn/crypto.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/58/858/2 diff --git a/src/openvpn/crypto.c b/src/openvpn/crypto.c index 84ec436..dbd95a8 100644 --- a/src/openvpn/crypto.c +++ b/src/openvpn/crypto.c @@ -406,17 +406,15 @@ static const char error_prefix[] =3D "AEAD Decrypt error"; struct packet_id_net pin =3D { 0 }; struct key_ctx *ctx =3D &opt->key_ctx_bi.decrypt; + struct gc_arena gc; + + gc_init(&gc); if (cipher_decrypt_verify_fail_exceeded(ctx)) { CRYPT_DROP("Decryption failed verification limit reached."); } - int outlen; - struct gc_arena gc; - - gc_init(&gc); - ASSERT(opt); ASSERT(frame); ASSERT(buf->len > 0); @@ -506,6 +504,8 @@ dmsg(D_PACKET_CONTENT, "DECRYPT AD: %s", format_hex(ad_start, ad_size, 0, &gc)); + int outlen; + /* Decrypt and authenticate packet */ if (!cipher_ctx_update(ctx->cipher, BPTR(&work), &outlen, BPTR(buf), data_len)) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/858?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0391f30a1e962ee242e9bcdec4f605bf7e831cca Gerrit-Change-Number: 858 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: ordex Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --02Vag9pjios= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by flichtenheld.

View Change

The following approvals got outda= ted and were removed: Code-Review+2 by ordex

Fix 'uninitialized pointer read' in openvpn_=
decrypt_aead

Coverity complains that if we error out in the firsterror condition we try to free gc without initializing
it.

While= here move the declaration of outlen to the first
usage.

Change-I= d: I0391f30a1e962ee242e9bcdec4f605bf7e831cca
Signed-off-by: Frank Lichte= nheld <frank@...2641...>
Acked-by: Antonio Quartulli <a@...2588...= ...>
Message-Id: <20250113112226.17728-1-gert@...1296...>
UR= L: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg3042= 1.html
Signed-off-by: Gert Doering <gert@...1296...>
---
M s= rc/openvpn/crypto.c
1 file changed, 5 insertions(+), 5 deletions(-)
<= br>
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/58/858/2=
diff --git a/src/openvpn/crypto.c b/src/openvpn/crypto.cindex 84ec436..dbd95a8 100644
--- a/src/openvpn/cryp= to.c
+++ b/src/openvpn/crypto.c
@@ -406,17 = +406,15 @@
static const char error_prefix[] =3D "= AEAD Decrypt error";
struct packet_id_net pin =3D= { 0 };
struct key_ctx *ctx =3D &opt->key_ctx_b= i.decrypt;
+ struc= t gc_arena gc;
+
+ gc_init(&gc);

if (cipher_decrypt_verify_fail_exceede= d(ctx))
{
CRYPT_DROP("De= cryption failed verification limit reached.");
}<= /span>

- = int outlen;
- struct= gc_arena gc;
-<= br>- gc_init(&gc);<= br>-
ASSERT(= opt);
ASSERT(frame);
ASSERT(buf-&= gt;len > 0);
@@ -506,6 +504,8 @@
dm= sg(D_PACKET_CONTENT, "DECRYPT AD: %s",
= format_hex(ad_start, ad_size, 0, &gc));

+ int outlen;

+
/* Decrypt and = authenticate packet */
if (!cipher_ctx_update(ctx->= cipher, BPTR(&work), &outlen, BPTR(buf),
= data_len))

To view, v= isit chan= ge 858. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0391f30a1e962ee242e9bcdec4f= 605bf7e831cca
Gerrit-Change-Number: 858
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: ordex <a@...2181...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--02Vag9pjios=--