From: "MaxF (Code Review)"
Date: Thu, 22 May 2025 13:35:11 +0000
In-Reply-To:
References:
Reply-To: max@...2606..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="k4o9IXYPR2o="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Use
mbedtls_ssl_export_keying_material()
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: plaisthos , flichtenheld , openvpn-devel
--k4o9IXYPR2o=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/open=
vpn/+/1041?usp=3Demail )
Change subject: Use mbedtls_ssl_export_keying_material()
......................................................................
Patch Set 2:
(1 comment)
File CMakeLists.txt:
http://gerrit.openvpn.net/c/openvpn/+/1041/comment/48dc00df_b6879caa :
PS2, Line 305: check_symbol_exists(mbedtls_ssl_export_keying_material m=
bedtls/ssl.h HAVE_MBEDTLS_SSL_EXPORT_KEYING_MATERIAL)
> shouldn't we rather rely on the mbed TLS configuration define MBEDTLS_SSL=
_KEYING_MATERIAL_EXPORT to [=E2=80=A6]
In configure.ac, we need to check if one of the key exporting callbacks exi=
sts, or if mbedtls_ssl_export_keying_material() exists, to determine if we =
should set HAVE_EXPORT_KEYING_MATERIAL. Is it possible to check that a defi=
ne exists in autoconf?
Alternatively, we could just refuse to compile if there's no way to export =
keying material, but I think I would rather do that in a different commit.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1041?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1204bc2ff85952160a86f0b9d1caae90e5065bc4
Gerrit-Change-Number: 1041
Gerrit-PatchSet: 2
Gerrit-Owner: MaxF
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Thu, 22 May 2025 13:35:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos
Gerrit-MessageType: comment
--k4o9IXYPR2o=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
View =
Change
1 comment:
I=
n configure.ac, we need to check if one of the key exporting callbacks exis=
ts, or if mbedtls_ssl_export_keying_material() exists, to determine if we s=
hould set HAVE_EXPORT_KEYING_MATERIAL. Is it possible to check that a defin=
e exists in autoconf?
Alternatively, we could just refuse to compile if there's no w=
ay to export keying material, but I think I would rather do that in a diffe=
rent commit.
To view, visit change 1041. To unsubscri=
be, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1204bc2ff85952160a86f0b9d1c=
aae90e5065bc4
Gerrit-Change-Number: 1041
Gerrit-PatchSet: 2
Gerrit-Owner: MaxF <max@...2606...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Thu, 22 May 2025 13:35:11=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <arne-openvp=
n@...1227...>
Gerrit-MessageType: comment
--k4o9IXYPR2o=--