From: Maarten Lankhorst Subject: Re: [CI 01/12] drm/i915: Introduce intel_atomic_get_plane_state_after_check(), v2. Date: Wed, 30 Oct 2019 10:17:52 +0100 Message-ID: References: <20191029072229.27092-1-maarten.lankhorst@linux.intel.com> <20191029183557.GE1208@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id D9EC46E8E4 for ; Wed, 30 Oct 2019 09:18:03 +0000 (UTC) In-Reply-To: <20191029183557.GE1208@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMjktMTAtMjAxOSBvbSAxOTozNSBzY2hyZWVmIFZpbGxlIFN5cmrDpGzDpDoKPiBPbiBUdWUs IE9jdCAyOSwgMjAxOSBhdCAwODoyMjoxOEFNICswMTAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90 ZToKPj4gVXNlIHRoaXMgaW4gYWxsIHRoZSBwbGFjZXMgd2hlcmUgd2UgdHJ5IHRvIGFjcXVpcmUg cGxhbmVzIGFmdGVyIHRoZSBwbGFuZXMKPj4gYXRvbWljX2NoZWNrKCkuCj4+Cj4+IEluIGNhc2Ug b2YgaW50ZWxfbW9kZXNldF9hbGxfcGlwZXMoKSB0aGlzIGlzIG5vdCB5ZXQgZG9uZSBhZnRlciBh dG9taWNfY2hlY2ssCj4+IGJ1dCBzZWVtcyBsaWtlIGl0IHdpbGwgYmUgaW4gdGhlIGZ1dHVyZS4g VG8gYWRkIHNvbWUgcGFyYW5vaWEsIGFkZCBhbGwgcGxhbmVzCj4+IHJhdGhlciB0aGFuIGFjdGl2 ZSBwbGFuZXMsIGJlY2F1c2Ugb2YgYmlnam9pbmVyIGFuZCBwbGFuYXIgWVVWIHN1cHBvcnQgaGF2 aW5nCj4+IGV4dHJhIHBsYW5lcyBvdXRzaWRlIG9mIHRoZSBjb3JlJ3MgdmlldyB0aGF0IHdvdWxk bid0IGJlIGFkZGVkIG90aGVyd2lzZS4KPj4KPj4gQ2hhbmdlcyBzaW5jZSB2MToKPj4gLSBBbHdh eXMgYWRkIGFsbCBwbGFuZXMsIHRvIGhhbmRsZSBmb3JjZSBwbGFuZSB1cGRhdGVzIHRvIHdvcmsg Y29ycmVjdGx5Cj4+ICAgd2l0aCBhIGRpc2FibGVkIGN1cnNvciBwbGFuZS4KPj4KPj4gU2lnbmVk LW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVs LmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2F0b21p Yy5jICAgfCA0MSArKysrKysrKystLS0tLS0tLS0tCj4+ICAuLi4vZ3B1L2RybS9pOTE1L2Rpc3Bs YXkvaW50ZWxfYXRvbWljX3BsYW5lLmMgfCAxNSArKysrKysrCj4+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9kaXNwbGF5L2ludGVsX2NkY2xrLmMgICAgfCAxNSArKysrLS0tCj4+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2NvbG9yLmMgICAgfCAgNyArKy0tCj4+ICAuLi4vZHJt L2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5X3R5cGVzLmggICAgfCAgNiArKysKPj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgICAgICAgICAgICAgICB8IDE0ICsrKystLS0KPj4g IDYgZmlsZXMgY2hhbmdlZCwgNjIgaW5zZXJ0aW9ucygrKSwgMzYgZGVsZXRpb25zKC0pCj4+Cj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2F0b21pYy5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hdG9taWMuYwo+PiBpbmRleCA5 Y2Q2ZDIzNDhhMWUuLjgwZGY2YzIzMzU4MSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvZGlzcGxheS9pbnRlbF9hdG9taWMuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9kaXNwbGF5L2ludGVsX2F0b21pYy5jCj4+IEBAIC0zMTMsMTMgKzMxMywxMCBAQCBpbnQgaW50 ZWxfYXRvbWljX3NldHVwX3NjYWxlcnMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LAo+PiAgCQkJICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjLAo+PiAgCQkJICAg ICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+PiAgewo+PiAtCXN0cnVj dCBkcm1fcGxhbmUgKnBsYW5lID0gTlVMTDsKPj4gLQlzdHJ1Y3QgaW50ZWxfcGxhbmUgKmludGVs X3BsYW5lOwo+PiAtCXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUgPSBOVUxM Owo+PiAgCXN0cnVjdCBpbnRlbF9jcnRjX3NjYWxlcl9zdGF0ZSAqc2NhbGVyX3N0YXRlID0KPj4g IAkJJmNydGNfc3RhdGUtPnNjYWxlcl9zdGF0ZTsKPj4gIAlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0 ZSAqZHJtX3N0YXRlID0gY3J0Y19zdGF0ZS0+YmFzZS5zdGF0ZTsKPj4gLQlzdHJ1Y3QgaW50ZWxf YXRvbWljX3N0YXRlICppbnRlbF9zdGF0ZSA9IHRvX2ludGVsX2F0b21pY19zdGF0ZShkcm1fc3Rh dGUpOwo+PiArCXN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRlID0gdG9faW50ZWxfYXRv bWljX3N0YXRlKGRybV9zdGF0ZSk7Cj4+ICAJaW50IG51bV9zY2FsZXJzX25lZWQ7Cj4+ICAJaW50 IGk7Cj4+ICAKPj4gQEAgLTM0Niw2ICszNDMsNyBAQCBpbnQgaW50ZWxfYXRvbWljX3NldHVwX3Nj YWxlcnMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgCj4+ICAJLyogd2Fs a3Rocm91Z2ggc2NhbGVyX3VzZXJzIGJpdHMgYW5kIHN0YXJ0IGFzc2lnbmluZyBzY2FsZXJzICov Cj4+ICAJZm9yIChpID0gMDsgaSA8IHNpemVvZihzY2FsZXJfc3RhdGUtPnNjYWxlcl91c2Vycykg KiA4OyBpKyspIHsKPj4gKwkJc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSA9 IE5VTEw7Cj4+ICAJCWludCAqc2NhbGVyX2lkOwo+PiAgCQljb25zdCBjaGFyICpuYW1lOwo+PiAg CQlpbnQgaWR4Owo+PiBAQCAtMzYxLDE5ICszNTksMTYgQEAgaW50IGludGVsX2F0b21pY19zZXR1 cF9zY2FsZXJzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gIAkJCS8qIHBh bmVsIGZpdHRlciBjYXNlOiBhc3NpZ24gYXMgYSBjcnRjIHNjYWxlciAqLwo+PiAgCQkJc2NhbGVy X2lkID0gJnNjYWxlcl9zdGF0ZS0+c2NhbGVyX2lkOwo+PiAgCQl9IGVsc2Ugewo+PiAtCQkJbmFt ZSA9ICJQTEFORSI7Cj4+ICsJCQlzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lOwo+PiAgCj4+ICAJ CQkvKiBwbGFuZSBzY2FsZXIgY2FzZTogYXNzaWduIGFzIGEgcGxhbmUgc2NhbGVyICovCj4+ICAJ CQkvKiBmaW5kIHRoZSBwbGFuZSB0aGF0IHNldCB0aGUgYml0IGFzIHNjYWxlcl91c2VyICovCj4+ IC0JCQlwbGFuZSA9IGRybV9zdGF0ZS0+cGxhbmVzW2ldLnB0cjsKPj4gIAo+PiAgCQkJLyoKPj4g IAkJCSAqIHRvIGVuYWJsZS9kaXNhYmxlIGhxIG1vZGUsIGFkZCBwbGFuZXMgdGhhdCBhcmUgdXNp bmcgc2NhbGVyCj4+ICAJCQkgKiBpbnRvIHRoaXMgdHJhbnNhY3Rpb24KPj4gIAkJCSAqLwo+PiAt CQkJaWYgKCFwbGFuZSkgewo+PiAtCQkJCXN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRlOwo+ PiAtCj4+ICsJCQlpZiAoIWRybV9zdGF0ZS0+cGxhbmVzW2ldLnB0cikgewo+PiAgCQkJCS8qCj4+ ICAJCQkJICogR0xLKyBzY2FsZXJzIGRvbid0IGhhdmUgYSBIUSBtb2RlIHNvIGl0Cj4+ICAJCQkJ ICogaXNuJ3QgbmVjZXNzYXJ5IHRvIGNoYW5nZSBiZXR3ZWVuIEhRIGFuZCBkeW4gbW9kZQo+PiBA QCAtMzgyLDI0ICszNzcsMjggQEAgaW50IGludGVsX2F0b21pY19zZXR1cF9zY2FsZXJzKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gIAkJCQlpZiAoSU5URUxfR0VOKGRldl9w cml2KSA+PSAxMCB8fCBJU19HRU1JTklMQUtFKGRldl9wcml2KSkKPj4gIAkJCQkJY29udGludWU7 Cj4+ICAKPj4gLQkJCQlwbGFuZSA9IGRybV9wbGFuZV9mcm9tX2luZGV4KCZkZXZfcHJpdi0+ZHJt LCBpKTsKPj4gLQkJCQlzdGF0ZSA9IGRybV9hdG9taWNfZ2V0X3BsYW5lX3N0YXRlKGRybV9zdGF0 ZSwgcGxhbmUpOwo+PiAtCQkJCWlmIChJU19FUlIoc3RhdGUpKSB7Cj4+IC0JCQkJCURSTV9ERUJV R19LTVMoIkZhaWxlZCB0byBhZGQgW1BMQU5FOiVkXSB0byBkcm1fc3RhdGVcbiIsCj4+IC0JCQkJ CQlwbGFuZS0+YmFzZS5pZCk7Cj4+IC0JCQkJCXJldHVybiBQVFJfRVJSKHN0YXRlKTsKPj4gKwkJ CQlwbGFuZSA9IHRvX2ludGVsX3BsYW5lKGRybV9wbGFuZV9mcm9tX2luZGV4KCZkZXZfcHJpdi0+ ZHJtLCBpKSk7Cj4+ICsJCQkJcGxhbmVfc3RhdGUgPQo+PiArCQkJCQlpbnRlbF9hdG9taWNfZ2V0 X3BsYW5lX3N0YXRlX2FmdGVyX2NoZWNrKHN0YXRlLAo+PiArCQkJCQkJCQkJCSBjcnRjX3N0YXRl LAo+PiArCQkJCQkJCQkJCSBwbGFuZSk7Cj4+ICsJCQkJaWYgKElTX0VSUihwbGFuZV9zdGF0ZSkp IHsKPj4gKwkJCQkJRFJNX0RFQlVHX0tNUygiRmFpbGVkIHRvIGFkZCBbUExBTkU6JWRdIHRvIGRy bV9zdGF0ZTogJWxpXG4iLAo+PiArCQkJCQkJcGxhbmUtPmJhc2UuYmFzZS5pZCwgUFRSX0VSUihw bGFuZV9zdGF0ZSkpOwo+PiArCQkJCQlyZXR1cm4gUFRSX0VSUihwbGFuZV9zdGF0ZSk7Cj4+ICAJ CQkJfQo+PiArCQkJfSBlbHNlIHsKPj4gKwkJCQlwbGFuZSA9IHRvX2ludGVsX3BsYW5lKGRybV9z dGF0ZS0+cGxhbmVzW2ldLnB0cik7Cj4+ICsJCQkJcGxhbmVfc3RhdGUgPSBpbnRlbF9hdG9taWNf Z2V0X25ld19wbGFuZV9zdGF0ZShzdGF0ZSwKPj4gKwkJCQkJCQkJCSAgICAgICBwbGFuZSk7Cj4+ ICAJCQl9Cj4+ICAKPj4gLQkJCWludGVsX3BsYW5lID0gdG9faW50ZWxfcGxhbmUocGxhbmUpOwo+ PiAtCQkJaWR4ID0gcGxhbmUtPmJhc2UuaWQ7Cj4+IC0KPj4gIAkJCS8qIHBsYW5lIG9uIGRpZmZl cmVudCBjcnRjIGNhbm5vdCBiZSBhIHNjYWxlciB1c2VyIG9mIHRoaXMgY3J0YyAqLwo+PiAtCQkJ aWYgKFdBUk5fT04oaW50ZWxfcGxhbmUtPnBpcGUgIT0gaW50ZWxfY3J0Yy0+cGlwZSkpCj4+ICsJ CQlpZiAoV0FSTl9PTihwbGFuZS0+cGlwZSAhPSBpbnRlbF9jcnRjLT5waXBlKSkKPj4gIAkJCQlj b250aW51ZTsKPj4gIAo+PiAtCQkJcGxhbmVfc3RhdGUgPSBpbnRlbF9hdG9taWNfZ2V0X25ld19w bGFuZV9zdGF0ZShpbnRlbF9zdGF0ZSwKPj4gLQkJCQkJCQkJICAgICAgIGludGVsX3BsYW5lKTsK Pj4gKwkJCW5hbWUgPSAiUExBTkUiOwo+PiArCQkJaWR4ID0gcGxhbmUtPmJhc2UuYmFzZS5pZDsK Pj4gIAkJCXNjYWxlcl9pZCA9ICZwbGFuZV9zdGF0ZS0+c2NhbGVyX2lkOwo+PiAgCQl9Cj4+ICAK Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYXRvbWlj X3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2F0b21pY19wbGFu ZS5jCj4+IGluZGV4IDk4ZjU1N2E5ZjhlZS4uYTllMjY4NGM2YjZkIDEwMDY0NAo+PiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2F0b21pY19wbGFuZS5jCj4+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYXRvbWljX3BsYW5lLmMKPj4gQEAg LTQwMiw2ICs0MDIsMjEgQEAgdm9pZCBpOXh4X3VwZGF0ZV9wbGFuZXNfb25fY3J0YyhzdHJ1Y3Qg aW50ZWxfYXRvbWljX3N0YXRlICpzdGF0ZSwKPj4gIAl9Cj4+ICB9Cj4+ICAKPj4gK3N0cnVjdCBp bnRlbF9wbGFuZV9zdGF0ZSAqCj4+ICtpbnRlbF9hdG9taWNfZ2V0X3BsYW5lX3N0YXRlX2FmdGVy X2NoZWNrKHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRlLAo+PiArCQkJCQkgc3RydWN0 IGludGVsX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRlLAo+PiArCQkJCQkgc3RydWN0IGludGVs X3BsYW5lICpwbGFuZSkKPj4gK3sKPj4gKwlzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5l X3N0YXRlID0KPj4gKwkJaW50ZWxfYXRvbWljX2dldF9wbGFuZV9zdGF0ZShzdGF0ZSwgcGxhbmUp Owo+PiArCj4+ICsJaWYgKElTX0VSUihwbGFuZV9zdGF0ZSkpCj4+ICsJCXJldHVybiBwbGFuZV9z dGF0ZTsKPj4gKwo+PiArCW5ld19jcnRjX3N0YXRlLT51cGRhdGVfcGxhbmVzIHw9IEJJVChwbGFu ZS0+aWQpOwo+PiArCXJldHVybiBwbGFuZV9zdGF0ZTsKPj4gK30KPiBXaXRoIHRoZSBodyBzdGF0 ZSBiZWluZyBwZXJzaXN0ZW50IG5vdyBJIGd1ZXNzIHdlIGRvbid0IG5lZWQgdGhpcwo+IGFueW1v cmU/CgpZZXMsIGl0IHdvdWxkIHN0aWwgYmUgdXNlZnVsIGZvciBhbm5vdGF0aW9uIHRob3VnaC4g OikKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==