From: Tvrtko Ursulin Subject: Re: [PATCH 3/3] drm/i915: Wait for the previous RCU grace period, not request completion Date: Thu, 13 Sep 2018 12:16:42 +0100 Message-ID: References: <20180912164015.28362-1-chris@chris-wilson.co.uk> <20180912164015.28362-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5492B6E668 for ; Thu, 13 Sep 2018 11:16:49 +0000 (UTC) In-Reply-To: <20180912164015.28362-3-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEyLzA5LzIwMTggMTc6NDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBVbmRlciBtZW1wcmVz c3VyZSwgb3VyIGdvYWwgaXMgdG8gYWxsb3cgb3Vyc2VsdmVzIHN1ZmZpY2llbnQgdGltZSB0bwo+ IHJlY2xhaW0gdGhlIFJDVSBwcm90ZWN0ZWQgc2xhYnMgd2l0aG91dCBvdmVybHkgcGVuYWxpemlu ZyBvdXIgY2xpZW50cy4KPiBDdXJyZW50bHksIHdlIHVzZSBhIDEgamlmZmllIHdhaXQgaWYgdGhl IGNsaWVudCBpcyBzdGlsbCBhY3RpdmUgYXMgYQo+IG1lYW5zIG9mIHRocm90dGxpbmcgdGhlIGFs bG9jYXRpb25zLCBidXQgd2UgY2FuIGluc3RlYWQgd2FpdCBmb3IgdGhlIGVuZAo+IG9mIHRoZSBS Q1UgZ3JhY2UgcGVyaW9kIG9mIHRoZSBjbGllbnRzIHByZXZpb3VzIGFsbG9jYXRpb24uCgpXaHkg ZGlkIHlvdSBvcHQgZm9yIHRocmVlIHBhdGNoZXMgY2hhbmdpbmcgdGhlIHNhbWUgY29kZSBhbmQg anVzdCBzcXVhc2ggCnRvIGxhc3Q/CgpSZWdhcmRzLAoKVHZydGtvCgo+IFN1Z2dlc3RlZC1ieTog RGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBTaWduZWQtb2ZmLWJ5OiBD aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3Vs aW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29u YXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGZmd2xsLmNoPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1 ZXN0LmMgfCAxNCArKysrKystLS0tLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9y ZXF1ZXN0LmggfCAgOCArKysrKysrKwo+ICAgMiBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25z KCspLCA4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X3JlcXVlc3QuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5jCj4g aW5kZXggNzJiY2I0Y2EwYzQ1Li5hNDkyMzg1YjIwODkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3JlcXVlc3QuYwo+IEBAIC03MzIsMTcgKzczMiwxMyBAQCBpOTE1X3JlcXVlc3RfYWxsb2Mo c3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLCBzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAq Y3R4KQo+ICAgCXJxID0ga21lbV9jYWNoZV9hbGxvYyhpOTE1LT5yZXF1ZXN0cywKPiAgIAkJCSAg ICAgIEdGUF9LRVJORUwgfCBfX0dGUF9SRVRSWV9NQVlGQUlMIHwgX19HRlBfTk9XQVJOKTsKPiAg IAlpZiAodW5saWtlbHkoIXJxKSkgewo+ICsJCWk5MTVfcmV0aXJlX3JlcXVlc3RzKGk5MTUpOwo+ ICsKPiAgIAkJLyogUmF0ZWxpbWl0IG91cnNlbHZlcyB0byBwcmV2ZW50IG9vbSBmcm9tIG1hbGlj aW91cyBjbGllbnRzICovCj4gICAJCXJxID0gaTkxNV9nZW1fYWN0aXZlX3JhdygmY2UtPnJpbmct PnRpbWVsaW5lLT5sYXN0X3JlcXVlc3QsCj4gICAJCQkJCSAmaTkxNS0+ZHJtLnN0cnVjdF9tdXRl eCk7Cj4gLQkJaWYgKHJxICYmIGk5MTVfcmVxdWVzdF93YWl0KHJxLAo+IC0JCQkJCSAgICBJOTE1 X1dBSVRfTE9DS0VEIHwKPiAtCQkJCQkgICAgSTkxNV9XQUlUX0lOVEVSUlVQVElCTEUsCj4gLQkJ CQkJICAgIDEpID09IC1FSU5UUikgewo+IC0JCQlyZXQgPSAtRUlOVFI7Cj4gLQkJCWdvdG8gZXJy X3VucmVzZXJ2ZTsKPiAtCQl9Cj4gLQkJaTkxNV9yZXRpcmVfcmVxdWVzdHMoaTkxNSk7Cj4gKwkJ aWYgKHJxKQo+ICsJCQljb25kX3N5bmNocm9uaXplX3JjdShycS0+cmN1c3RhdGUpOwo+ICAgCj4g ICAJCS8qCj4gICAJCSAqIFdlJ3ZlIGZvcmNlZCB0aGUgY2xpZW50IHRvIHN0YWxsIGFuZCBjYXRj aCB1cCB3aXRoIHdoYXRldmVyCj4gQEAgLTc2Miw2ICs3NTgsOCBAQCBpOTE1X3JlcXVlc3RfYWxs b2Moc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLCBzdHJ1Y3QgaTkxNV9nZW1fY29udGV4 dCAqY3R4KQo+ICAgCQl9Cj4gICAJfQo+ICAgCj4gKwlycS0+cmN1c3RhdGUgPSBnZXRfc3RhdGVf c3luY2hyb25pemVfcmN1KCk7Cj4gKwo+ICAgCUlOSVRfTElTVF9IRUFEKCZycS0+YWN0aXZlX2xp c3QpOwo+ICAgCXJxLT5pOTE1ID0gaTkxNTsKPiAgIAlycS0+ZW5naW5lID0gZW5naW5lOwo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuaCBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5oCj4gaW5kZXggOTg5ODMwMWFiN2VmLi43ZmE5NGIw MjQ5NjggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0LmgK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuaAo+IEBAIC0xMDAsNiAr MTAwLDE0IEBAIHN0cnVjdCBpOTE1X3JlcXVlc3Qgewo+ICAgCXN0cnVjdCBpOTE1X3RpbWVsaW5l ICp0aW1lbGluZTsKPiAgIAlzdHJ1Y3QgaW50ZWxfc2lnbmFsX25vZGUgc2lnbmFsaW5nOwo+ICAg Cj4gKwkvKgo+ICsJICogVGhlIHJjdSBlcG9jaCBvZiB3aGVuIHRoaXMgcmVxdWVzdCB3YXMgYWxs b2NhdGVkLiBVc2VkIHRvIGp1ZGljaW91c2x5Cj4gKwkgKiBhcHBseSBiYWNrcHJlc3N1cmUgb24g ZnV0dXJlIGFsbG9jYXRpb25zIHRvIGVuc3VyZSB0aGF0IHVuZGVyCj4gKwkgKiBtZW1wcmVzc3Vy ZSB0aGVyZSBpcyBzdWZmaWNpZW50IFJDVSB0aWNrcyBmb3IgdXMgdG8gcmVjbGFpbSBvdXIKPiAr CSAqIFJDVSBwcm90ZWN0ZWQgc2xhYnMuCj4gKwkgKi8KPiArCXVuc2lnbmVkIGxvbmcgcmN1c3Rh dGU7Cj4gKwo+ICAgCS8qCj4gICAJICogRmVuY2VzIGZvciB0aGUgdmFyaW91cyBwaGFzZXMgaW4g dGhlIHJlcXVlc3QncyBsaWZldGltZS4KPiAgIAkgKgo+IApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK