From: Patrice CHOTARD Date: Wed, 21 Oct 2020 12:28:14 +0000 Subject: [PATCH 16/33] misc: rcc: keep the rcc device name for subnode In-Reply-To: <20201014091646.4233-17-patrick.delaunay@st.com> References: <20201014091646.4233-1-patrick.delaunay@st.com> <20201014091646.4233-17-patrick.delaunay@st.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Patrick On 10/14/20 11:16 AM, Patrick Delaunay wrote: > Update the name associated with the RCC drivers to avoid > duplicated name with the driver name. > > With this patch the traces displayed with log macro provide a > correct device name. > > The rcc device name before the patch is: > > Class Index Probed Driver Name > ----------------------------------------------------------- > root 0 [ + ] root_driver root_driver > simple_bus 0 [ + ] simple_bus |-- soc > (...) > nop 0 [ + ] stm32-rcc | |-- rcc at 50000000 > clk 0 [ + ] stm32mp1_clk | | |-- stm32mp1_clk > reset 0 [ + ] stm32_rcc_reset | | `-- stm32_rcc_reset > > And they become: > (...) > nop 0 [ + ] stm32-rcc | |-- rcc at 50000000 > clk 0 [ + ] stm32mp1_clk | | |-- rcc at 50000000 > reset 0 [ + ] stm32_rcc_reset | | `-- rcc at 50000000 > > The traces is correct: > stm32mp1_clk rcc at stm32mp1_clk: ..... > => > stm32mp1_clk rcc at 50000000: ..... > > Signed-off-by: Patrick Delaunay > > --- > > drivers/misc/stm32_rcc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/stm32_rcc.c b/drivers/misc/stm32_rcc.c > index c1a99d78e2..e46685f0e1 100644 > --- a/drivers/misc/stm32_rcc.c > +++ b/drivers/misc/stm32_rcc.c > @@ -54,7 +54,7 @@ static int stm32_rcc_bind(struct udevice *dev) > return -ENOENT; > } > > - ret = device_bind_with_driver_data(dev, drv, rcc_clk->drv_name, > + ret = device_bind_with_driver_data(dev, drv, dev->name, > rcc_clk->soc, > dev_ofnode(dev), &child); > > @@ -67,7 +67,7 @@ static int stm32_rcc_bind(struct udevice *dev) > return -ENOENT; > } > > - return device_bind_with_driver_data(dev, drv, "stm32_rcc_reset", > + return device_bind_with_driver_data(dev, drv, dev->name, > rcc_clk->soc, > dev_ofnode(dev), &child); > } Reviewed-by: Patrice Chotard Thanks