Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD06C433DF for ; Wed, 5 Aug 2020 15:08:17 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 973A623331 for ; Wed, 5 Aug 2020 15:08:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 973A623331 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3L1T-0007OC-HI; Wed, 05 Aug 2020 15:08:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3L1S-0007O7-A3 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2020 15:08:06 +0000 X-Inumbo-ID: 2f524f99-b9f5-4538-8df4-5e5e98e2d2bd Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2f524f99-b9f5-4538-8df4-5e5e98e2d2bd; Wed, 05 Aug 2020 15:08:05 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 88212AC7F; Wed, 5 Aug 2020 15:08:21 +0000 (UTC) Subject: Re: [PATCH] x86/ioapic: Fix style in io_apic.h To: Andrew Cooper References: <20200805125124.7763-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 5 Aug 2020 17:08:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200805125124.7763-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 05.08.2020 14:51, Andrew Cooper wrote: > This file is a mix of Xen and Linux styles. Switch it fully to Xen style. > > No functional change. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich with a suggestion and, I'm afraid, a few more adjustments: > --- a/xen/include/asm-x86/io_apic.h > +++ b/xen/include/asm-x86/io_apic.h > @@ -13,9 +13,9 @@ > * Copyright (C) 1997, 1998, 1999, 2000 Ingo Molnar > */ > > -#define IO_APIC_BASE(idx) \ > - ((volatile int *)(__fix_to_virt(FIX_IO_APIC_BASE_0 + idx) \ > - + (mp_ioapics[idx].mpc_apicaddr & ~PAGE_MASK))) > +#define IO_APIC_BASE(idx) \ > + ((volatile int *)(__fix_to_virt(FIX_IO_APIC_BASE_0 + idx) \ > + + (mp_ioapics[idx].mpc_apicaddr & ~PAGE_MASK))) As you touch this anyway, would you mind parenthesizing idx when used as a, operand of + ? > @@ -135,28 +135,28 @@ unsigned int io_apic_gsi_base(unsigned int apic); > > static inline unsigned int __io_apic_read(unsigned int apic, unsigned int reg) > { > - *IO_APIC_BASE(apic) = reg; > - return *(IO_APIC_BASE(apic)+4); > + *IO_APIC_BASE(apic) = reg; > + return *(IO_APIC_BASE(apic)+4); Here and below + wants to be framed by spaces. Jan