From: "stipa (Code Review)" Date: Fri, 21 Mar 2025 14:09:47 +0000 In-Reply-To: References: Reply-To: lstipakov@...277..., arne-openvpn@...1227..., heiko@...515..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="f0L1itly5Kw="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: d12fk Cc: flichtenheld , plaisthos , openvpn-devel --f0L1itly5Kw= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: d12fk, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/837?usp=3Demail ) Change subject: win: implement --dns option support with NRPT ...................................................................... Patch Set 14: -Code-Review (3 comments) Patchset: PS14: Is split-dns already supposed to work? In my server config I have push "dns server 1 resolve-domains fi" push "dns server 1 address 1.1.1.1" push "dns server 2 resolve-domains io" push "dns server 2 address 8.8.8.8" so I would expect .fi go to 1.1.1.1 and .io to 8.8.8.8, but instead only on= e registry entry .fi is created with 1.1.1.1. Also, with that push "dns server 1 resolve-domains fi" push "dns server 1 address 1.1.1.1" in addition to NRPT we set 1.1.1.1 on VPN adapter and many DNS requests not= directed to .fi domains also resolved via 1.1.1.1. This contradicts to wha= t documentation says: "where only the given domains are resolved by the ser= ver". File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/837/comment/8e6ebec0_a562e6ce : PS14, Line 2259: MsgToEventLog(M_SYSERR, TEXT("IsInterfaceConnected= : " At least on my machine I have 6 "real" network adapters (according to Get-N= etAdapter | Format-List Name, InterfaceGuid) and 12 registry keys, apparent= ly those are disabled/hidden etc. Because of that I got lots of scary "IsInterfaceConnected: could not convert interface {F2D72071-CB76-4D6F-9DC8= -EDAA3AC6B387} GUID to LUID" messages. Let's don't display this error messa= ge - at least if ConvertInterfaceGuidToLuid returns ERROR_INVALID_PARAMETER. http://gerrit.openvpn.net/c/openvpn/+/837/comment/427ad111_8562738a : PS14, Line 2510: for (int i =3D 0; i < _countof(data); ++i) Does it really make sense to create keys for all adapters, even if there ar= e no domains/servers defined? Could we do it only if there are adapter-specific domains defined? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/837?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5adbebaaf209cc Gerrit-Change-Number: 837 Gerrit-PatchSet: 14 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: d12fk Gerrit-Comment-Date: Fri, 21 Mar 2025 14:09:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --f0L1itly5Kw= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: d12fk, plaisthos.

Patch set 14:-Code-Review

=

View C= hange

3 comments:

    =
  • Patchset:

    • Patch Set #14:

      Is split-dns already supposed to work? In my ser= ver config I have


      push "dns server 1 resolve-domains fi"
      push "dns= server 1 address 1.1.1.1"

      push "dns server 2 resolve-domains io"
      push= "dns server 2 address 8.8.8.8"

      so I would expect .fi go to 1.1.1.1 and .io to= 8.8.8.8, but instead only one registry entry .fi is created with 1.1.1.1.<= /p>

      Also, with th= at

      push "= ;dns server 1 resolve-domains fi"
      push "dns server 1 address 1= .1.1.1"

      = in addition to NRPT we set 1.1.1.1 on VPN adapter and many DNS requests not= directed to .fi domains also resolved via 1.1.1.1. This contradicts to wha= t documentation says: "where only the given domains are resolved by th= e server".

  • F= ile src/openvpnserv/interactive.c:

    • Patch Set #14, Line 2259: MsgToEventLog(M_SYSERR, TEXT("IsInterfaceCo= nnected: "

      At least on my machine I have 6 "real" network adapters= (according to Get-NetAdapter | Format-List Name, InterfaceGuid) and 12 reg= istry keys, apparently those are disabled/hidden etc. Because of that I got= lots of scary
      "IsInterfaceConnected: could not convert interface = {F2D72071-CB76-4D6F-9DC8-EDAA3AC6B387} GUID to LUID" messages. Let'= ;s don't display this error message - at least if ConvertInterfaceGuidT= oLuid returns ERROR_INVALID_PARAMETER.

    • Patch Set #14, Line= 2510: for (int i = =3D 0; i < _countof(data); ++i)

      Does it really make sense to create keys for a= ll adapters, even if there are no domains/servers defined?

      Could we do it only if there= are adapter-specific domains defined?

To view, v= isit chan= ge 837. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5= adbebaaf209cc
Gerrit-Change-Number: 837
Gerrit-PatchSet: 14
Gerrit-Owner: d12fk <heiko@...515...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...= >
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: d12fk <heiko@...515...>= ;
Gerrit-Comment-Date: Fri, 21 Mar 2025 14:09:47= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--f0L1itly5Kw=--