From: "flichtenheld (Code Review)" Date: Tue, 31 Mar 2026 16:32:15 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="U6URVlC9YNA="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Rename key* to privkey* in cert_data.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --U6URVlC9YNA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerr= it.openvpn.net/c/openvpn/+/1597?usp=3Demail ) Change subject: Rename key* to privkey* in cert_data.h ...................................................................... Patch Set 1: (1 comment) File tests/unit_tests/openvpn/test_pkcs11.c: http://gerrit.openvpn.net/c/openvpn/+/1597/comment/f1d19305_b39e693a?usp=3D= email : PS1, Line 145: { cert1, key1, cname1, "OVPN TEST CA1", "OVPN Test C= ert 1", { 0 }, NULL }, what is going on here? Why do we only change one name? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1597?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id8680e6555a66024417d6eb9322d4fde79922453 Gerrit-Change-Number: 1597 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-CC: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Tue, 31 Mar 2026 16:32:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No --U6URVlC9YNA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

View = Change

1 comment:

    =
  • File tests/unit_tests/openvpn/test_= pkcs11.c:

    • Patch Set #1, Line 145: { cert1, key1, cname1, "OVPN TEST CA1", "OVPN T= est Cert 1", { 0 }, NULL },

      what is going on here? Why do w= e only change one name?

To view, visit change 1597. T= o unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id8680e6555a66024417d6eb9322= d4fde79922453
Gerrit-Change-Number: 1597
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-CC: flichtenheld <frank@...2641...&g= t;
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Tue, 31 Mar 2026 16:32:15= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
= --U6URVlC9YNA=--