Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 213D7C43603 for ; Mon, 16 Dec 2019 09:49:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC31620665 for ; Mon, 16 Dec 2019 09:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727036AbfLPJtq (ORCPT ); Mon, 16 Dec 2019 04:49:46 -0500 Received: from s3.sipsolutions.net ([144.76.43.62]:42374 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726959AbfLPJtq (ORCPT ); Mon, 16 Dec 2019 04:49:46 -0500 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.3) (envelope-from ) id 1ign0Z-001Bus-QJ; Mon, 16 Dec 2019 10:49:43 +0100 Message-ID: Subject: Re: [PATCH v2 1/7] mac80211: add a struct for holding BSS color settings From: Johannes Berg To: John Crispin , Kalle Valo Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Date: Mon, 16 Dec 2019 10:49:42 +0100 In-Reply-To: <20191213155802.25491-1-john@phrozen.org> References: <20191213155802.25491-1-john@phrozen.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2019-12-13 at 16:57 +0100, John Crispin wrote: > Right now we only track the actual color but not the other bits contained > within the he_oper field. Fix this by creating a new struct to hold all > of the info. > > Signed-off-by: John Crispin > --- > include/net/cfg80211.h | 15 +++++++++++++++ > include/net/mac80211.h | 2 ++ > 2 files changed, 17 insertions(+) I think you should drop this patch and put the cfg80211 and mac80211 update into the second and third patch of this series, respectively. It doesn't make much sense to add some unused structs. > diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h > index 8140c4837122..e395ef48af83 100644 > --- a/include/net/cfg80211.h > +++ b/include/net/cfg80211.h > @@ -259,6 +259,19 @@ struct ieee80211_he_obss_pd { It looks like I didn't see that previously for that one, > + * struct ieee80211_he_bss_color - AP settings for BSS coloring but I'd kinda prefer this be called cfg80211_... since it's not part of ieee80211.h with all the over-the-air struct definitions. I'm sure we have some non-over-the-air things that are called ieee80211_*, but ... johannes