Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCCEAC433EF for ; Tue, 25 Jan 2022 01:04:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DD80E83035; Tue, 25 Jan 2022 02:04:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 2871083102; Tue, 25 Jan 2022 02:04:33 +0100 (CET) Received: from relay.hostedemail.com (relay036.a.hostedemail.com [64.99.140.36]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AC6BA80FE4 for ; Tue, 25 Jan 2022 02:04:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=joe@perches.com Received: from omf19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 16181221E6; Tue, 25 Jan 2022 01:04:26 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf19.hostedemail.com (Postfix) with ESMTPA id D154820025; Tue, 25 Jan 2022 01:04:25 +0000 (UTC) Message-ID: Subject: Re: [PATCH v4 1/4] checkpatch: Support wide strings From: Joe Perches To: Simon Glass Cc: Tom Rini , U-Boot Mailing List , Heinrich Schuchardt Date: Mon, 24 Jan 2022 17:04:24 -0800 In-Reply-To: References: <20220122012736.2725994-1-sjg@chromium.org> <20220122012736.2725994-2-sjg@chromium.org> <20220123145415.GB7515@bill-the-cat> <500dd2deb5202ef4c2fb0bd1d2a45a36776c5cca.camel@perches.com> <20220123161914.GG7515@bill-the-cat> <49268c4a594eea1555846a6059dacea8e18fa227.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Stat-Signature: c1m8xs6o48fw6tqr79c56daxekd5exz1 X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: D154820025 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/m9ZX3nDCy1Iqi94V+woPVCJya94TbqLk= X-HE-Tag: 1643072665-306162 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Sun, 2022-01-23 at 13:12 -0700, Simon Glass wrote: > Hi Joe, > > On Sun, 23 Jan 2022 at 09:27, Joe Perches wrote: > > > > On Sun, 2022-01-23 at 11:19 -0500, Tom Rini wrote: > > > On Sun, Jan 23, 2022 at 08:10:37AM -0800, Joe Perches wrote: > > > > On Sun, 2022-01-23 at 09:03 -0700, Simon Glass wrote: > > > > > > > > > Do you think we > > > > > should try to send the U-Boot things upstream? > > > > > > > > No idea. What are the U-Boot things that could or should be generic ? > > > > > > > > https://source.denx.de/u-boot/u-boot/-/commits/master/scripts/checkpatch.pl > > > > > > Honestly? > > > > Do you honestly think I normally look at or care about u-boot ? > > > > > I think we got everything that was generic pushed upstream > > > first these days and it's just U-Boot centric checks in the u_boot_* > > > functions. > > > > Fine by me. > > > > It is just one perl function enabled by a --u-boot flag, so if you > don't mind, it would be convenient to upstream it. You could send a patch for review.