From: "mrbff (Code Review)"
Date: Thu, 28 Nov 2024 15:21:49 +0000
In-Reply-To:
References:
Reply-To: marco@...2726..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
lstipakov@...277...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="VCP4z05lV5k="; charset=UTF-8
Subject: [Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Allow
OpenVPN in client mode to receive and handle PUSH ...
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , stipa , plaisthos , openvpn-devel
--VCP4z05lV5k=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos, stipa.
mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/808?usp=3Demail )
Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and ha=
ndle PUSH UPDATE control messages to allow options updating at runtime.
......................................................................
Patch Set 5:
(7 comments)
File CMakeLists.txt:
http://gerrit.openvpn.net/c/openvpn/+/808/comment/8f5a6f36_8362c01a :
PS4, Line 812:
> nit: whitespace
Done
File src/openvpn/init.c:
http://gerrit.openvpn.net/c/openvpn/+/808/comment/bd8dd262_1158ed00 :
PS4, Line 2033: int status =3D do_route(&c->options, c->c1.rout=
e_list, c->c1.route_ipv6_list,
> nice catch!
tnx!
File src/openvpn/options_util.c:
http://gerrit.openvpn.net/c/openvpn/+/808/comment/f8c35b78_8f40c7a2 :
PS4, Line 124: check_push_update_option_flags(char **line, unsigned int *fl=
ags)
> Add doxygen what does this function do.
Done
http://gerrit.openvpn.net/c/openvpn/+/808/comment/a0c306fd_1444ca21 :
PS4, Line 138: if (str[1])
> below 8 lines are duplicated 3 times. Maybe define a macro and reuse it, =
and later undefine? Like [=E2=80=A6]
Clever, i like it, I tried but when the compiler optimizes it, the code get=
s skipped. Anyway, i simplified and now i use it just 2 times and with a sl=
ightly different condition so i hope is good enough
http://gerrit.openvpn.net/c/openvpn/+/808/comment/a517e1a9_3a38d88f :
PS4, Line 160: if (c =3D=3D '-' && !(*flags & PUSH_OPT_TO_REMOVE))
> you could remove the "c =3D=3D '-'" check here and move this whole block =
under the "if" condition above
I'm not entirely sure that's what you meant but I simplified
http://gerrit.openvpn.net/c/openvpn/+/808/comment/ada8cdcc_81c709fb :
PS4, Line 221: apply_pull_filter(const struct options *o, char *line, bool =
is_update, unsigned int *push_update_option_flags)
> Let's move doxygen to the header.
Done
File src/openvpn/push.h:
http://gerrit.openvpn.net/c/openvpn/+/808/comment/276f3131_7f2768f9 :
PS4, Line 47: int process_incoming_push_update(struct context *c,
> Doxygen
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595c742aeec6064a
Gerrit-Change-Number: 808
Gerrit-PatchSet: 5
Gerrit-Owner: mrbff
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-CC: stipa
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Attention: stipa
Gerrit-Comment-Date: Thu, 28 Nov 2024 15:21:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa
Gerrit-MessageType: comment
--VCP4z05lV5k=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos, stipa. <=
/p>
View C=
hange
7 comments:
Done
File src/openvpn/init.c:
Patch Set #4, Line 2033: int status =3D do_route(&c->options, c->c1.r=
oute_list, c->c1.route_ipv6_list,
nice catch!tnx!=
File src/openvpn=
/options_util.c:
=
Patch Set #4, Line 124: check_push_update_option_flags(char **line, unsigned int *flags)
Add doxygen what does this function do.
Done
=
Patch Set #4, Line 138: if (str[1])
below 8 lines are duplicated 3 t=
imes. Maybe define a macro and reuse it, and later undefine? Like [=E2=80=
=A6]
Clever, i like it, I tried but when the compiler optimizes it, the cod=
e gets skipped. Anyway, i simplified and now i use it just 2 times and with=
a slightly different condition so i hope is good enough
=
Patch Set #4, Line 160: if (c =3D=3D '-' && !(*flags & PUSH_OPT_TO_REMOVE)=
)
you could remove the "c =3D=3D '-'&quo=
t; check here and move this whole block under the "if" condition =
above
I'm not entirely sure that's what you meant but I simplified<=
/p>
Patch Set #4, Line 221: apply_pull_filter(const struct options *o, char *line, bo=
ol is_update, unsigned int *push_update_option_flags)
Let's move doxygen to the header.
Done
File src/openvpn/push.h:
To v=
iew, visit change 808. To unsubscribe, or for help writing mail filters, visit <=
a href=3D"http://gerrit.openvpn.net/settings">settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595=
c742aeec6064a
Gerrit-Change-Number: 808
Gerrit-PatchSet: 5
Gerrit-Owner: mrbff <marco@...2726...> <=
/div>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-CC: stipa <lstipakov@...277...> <=
/div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: stipa <lstipakov@...1663...=
.>
Gerrit-Comment-Date: Thu, 28 Nov 2024 15:21:49=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa <lstipakov@...1664...=
7...>
Gerrit-MessageType: comment
--VCP4z05lV5k=--