Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1236E101EE for ; Fri, 20 Jun 2025 03:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750388677; cv=none; b=bpOUAZ/bsZQMThvPuxqgePxwu/4o1jeTHJtmSJaCURHj9wKsgEBrXpGf5LkrX504fPw94t1XaPsM6JxG+6dyoZBg/cpTQcyWrrVOZUn/m6hQqNxSy2A71O6kY38xyYFsNagPoSivOtWyeQjQcNTP6SKoNt/XpKrJ+hyjZFjxoFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750388677; c=relaxed/simple; bh=0zzSsOaaVW+6Rladm+VrtEW+Uxxwfj2qRoLW/MhT43s=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=VIvZU2619+AWxgoubK7B0yOX0bPo99JEZ4Y5jB7JTR96o71CCHbR4pelMGWLdYG9U8Uq0lAqgOqP4F5vwXXR25fJ9tWJbc7X0mIIpgX0sr0ZADM/Q/4bZ6pWh6oONsQQf6MiGEjcAwtyVrjaynNENWr4H10F6MnqbtXvLI4A01Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FhA5bwO6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FhA5bwO6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2191C4CEEA; Fri, 20 Jun 2025 03:04:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750388676; bh=0zzSsOaaVW+6Rladm+VrtEW+Uxxwfj2qRoLW/MhT43s=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=FhA5bwO67Cdtq+2B7kb3uiwUoOuieGxjnOOK7iALgbsp2HtVqDeQOdj2nzYUMlfBS 2IZEtq2f39hbe3reaa9UyULvk6qwMX5caInhTiw/hSRBBPIgfaEWZbwGugM37lN3cs 4JxEX85SEdf9rcl2YzYWTVOFY9IVcsUD6ATXBy6ukUgEfWgVmgJjo/YTMJmi8BMNy0 nIY66kgwGTMJ9exaE62V8GV9G4EOV4H8eGBTuEbjH5lv9JflFhAf+aV++T00dUVX8T UsugUbfU9LfrNSZYkhTI90NUEorqbRRDgdITAQsVTFl+xK/aF/OKey5hxm7PAZYXrx ezMLWyMugnT/A== Message-ID: Date: Fri, 20 Jun 2025 12:04:34 +0900 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: endpoint: Fix configfs group removal on driver teardown From: Damien Le Moal To: linux-pci@vger.kernel.org, Manivannan Sadhasivam , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas Cc: Niklas Cassel References: <20250617010737.560029-1-dlemoal@kernel.org> Content-Language: en-US Organization: Western Digital Research In-Reply-To: <20250617010737.560029-1-dlemoal@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/17/25 10:07, Damien Le Moal wrote: > An endpoint driver configfs attributes group is added to the > epf_group list of struct pci_epf_driver pci_epf_add_cfs() but not > removed from this list when the attribute group is unregistered with > pci_ep_cfs_remove_epf_group(). Add the missing list_del_init() call in > that function to correctly remove the attribute group from the driver > list. > > Furthermore, doing a list_del() on the epf_group field of struct > pci_epf_driver in pci_epf_remove_cfs() is not correct as this field is a > list head, not a list entry, and triggers a KASAN warning: Ping ? > > ================================================================== > BUG: KASAN: slab-use-after-free in pci_epf_remove_cfs+0x17c/0x198 > Write of size 8 at addr ffff00010f4a0d80 by task rmmod/319 > > CPU: 3 UID: 0 PID: 319 Comm: rmmod Not tainted 6.16.0-rc2 #1 NONE > Hardware name: Radxa ROCK 5B (DT) > Call trace: > show_stack+0x2c/0x84 (C) > dump_stack_lvl+0x70/0x98 > print_report+0x17c/0x538 > kasan_report+0xb8/0x190 > __asan_report_store8_noabort+0x20/0x2c > pci_epf_remove_cfs+0x17c/0x198 > pci_epf_unregister_driver+0x18/0x30 > nvmet_pci_epf_cleanup_module+0x24/0x30 [nvmet_pci_epf] > __arm64_sys_delete_module+0x264/0x424 > invoke_syscall+0x70/0x260 > el0_svc_common.constprop.0+0xac/0x230 > do_el0_svc+0x40/0x58 > el0_svc+0x48/0xdc > el0t_64_sync_handler+0x10c/0x138 > el0t_64_sync+0x198/0x19c > ... > > Remove this list_del() call from pci_epf_remove_cfs() and replace it > with a warning if the epf_group list is not empty. > > Fixes: ef1433f717a2 ("PCI: endpoint: Create configfs entry for each pci_epf_device_id table entry") > Cc: stable@vger.kernel.org > Signed-off-by: Damien Le Moal > --- > drivers/pci/endpoint/pci-ep-cfs.c | 1 + > drivers/pci/endpoint/pci-epf-core.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c > index d712c7a866d2..63876537e7dc 100644 > --- a/drivers/pci/endpoint/pci-ep-cfs.c > +++ b/drivers/pci/endpoint/pci-ep-cfs.c > @@ -691,6 +691,7 @@ void pci_ep_cfs_remove_epf_group(struct config_group *group) > if (IS_ERR_OR_NULL(group)) > return; > > + list_del_init(&group->group_entry); > configfs_unregister_default_group(group); > } > EXPORT_SYMBOL(pci_ep_cfs_remove_epf_group); > diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c > index 577a9e490115..167dc6ee63f7 100644 > --- a/drivers/pci/endpoint/pci-epf-core.c > +++ b/drivers/pci/endpoint/pci-epf-core.c > @@ -338,7 +338,7 @@ static void pci_epf_remove_cfs(struct pci_epf_driver *driver) > mutex_lock(&pci_epf_mutex); > list_for_each_entry_safe(group, tmp, &driver->epf_group, group_entry) > pci_ep_cfs_remove_epf_group(group); > - list_del(&driver->epf_group); > + WARN_ON(!list_empty(&driver->epf_group)); > mutex_unlock(&pci_epf_mutex); > } > -- Damien Le Moal Western Digital Research