From: "flichtenheld (Code Review)" Date: Wed, 16 Apr 2025 13:48:29 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, antonio@...2726... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="X4QD1OC4Uf8="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Reformat the whole project with clang-format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , openvpn-devel --X4QD1OC4Uf8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/791?usp=3Demail ) Change subject: Reformat the whole project with clang-format ...................................................................... Patch Set 16: (4 comments) File sample/sample-plugins/client-connect/sample-client-connect.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/763d178b_37f47877 : PS14, Line 251: MODULE, > So basically what you want is "BinPackArguments: true", will apply that. Done File sample/sample-plugins/defer/multi-auth.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/e720aaa5_9dff2c4a : PS14, Line 267: np(context->test_valid_user), > I'd vote for putting these arguments on the same line, if there is enough= space. Done http://gerrit.openvpn.net/c/openvpn/+/791/comment/6d71e7fc_faa3fc2d : PS14, Line 418: plog(context, PLOG_NOTE, "FUNC: openvpn_plugin_client_c= onstructor_v1"); > Doesn't seem to be supported. There is a feature request for it: https://= github. [=E2=80=A6] Acknowledged File sample/sample-plugins/log/log_v3.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/5a59375c_600cff63 : PS14, Line 87: "log_v3: ** ERROR ** Incompatible plug-in interf= ace between this plug-in and OpenVPN\n"); > yes Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/791?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e Gerrit-Change-Number: 791 Gerrit-PatchSet: 16 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: ordex Gerrit-Attention: plaisthos Gerrit-Attention: ordex Gerrit-Comment-Date: Wed, 16 Apr 2025 13:48:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Comment-In-Reply-To: ordex Gerrit-MessageType: comment --X4QD1OC4Uf8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: ordex, plaisthos.

View C= hange

4 comments:

    =
  • File sample/sample-plugins/client-c= onnect/sample-client-connect.c:

  • File sample/sam= ple-plugins/defer/multi-auth.c:

    • Patch Set #14, Line 267: np(context->test_valid_user),

      I'd vote for putting these arguments on the same line, if there is = enough space.

      Done

    • Patch Set #14, Line 418: plog(context, PLOG_NOTE, "FU= NC: openvpn_plugin_client_constructor_v1");

      Does= n't seem to be supported. There is a feature request for it: https://gi= thub. [=E2=80=A6]

      Acknowledged

  • File sample/sample-plugins/log/log_v3.c:

    • Patch Set #14, Line 87: "log_v3: ** ERROR ** = Incompatible plug-in interface between this plug-in and OpenVPN\n");

      yes

      Acknowledged

To view, vi= sit chang= e 791. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b= 8973463404e3e
Gerrit-Change-Number: 791
Gerrit-PatchSet: 16
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: ordex <antonio@...2726...>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: ordex <antonio@...2726...= >
Gerrit-Comment-Date: Wed, 16 Apr 2025 13:48:29= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Comment-In-Reply-To: ordex <antonio@...2787...= ...>
Gerrit-MessageType: comment
--X4QD1OC4Uf8=--