From: "plaisthos (Code Review)" Date: Wed, 3 Jan 2024 15:23:38 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="yGzb3DpJvi8="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Make it more explicit and visible when pkg-config is not found List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: cron2 , flichtenheld Cc: openvpn-devel --yGzb3DpJvi8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/465?usp=3Demail to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by flichtenheld, Code-Review-1 by cron2 The change is no longer submittable: Code-Review and checks~ChecksSubmitRul= e are unsatisfied now. Change subject: Make it more explicit and visible when pkg-config is not fo= und ...................................................................... Make it more explicit and visible when pkg-config is not found Users seem to struggle to read the full error message. This adds an indication if pkg-config is actually found to the warning/error message that use pkg-config. On platforms that do not require pkg-config and for optional libraries, the existence of pkg-config is mentioned as part of the error/warning messa= ge. When found: configure: error: libnl-genl-3.0 package not found or too old. Is the d= evelopment package and pkg-config (using /usr/bin/pkg-config) installed? Mu= st be version 3.4.0 or newer for DCO not found: configure: error: libnl-genl-3.0 package not found or too old. Is the d= evelopment package and pkg-config (not found) installed? Must be version 3.= 4.0 or newer for DCO On platforms where pkg-config is required (only Linux at the moment), configure will abort when not detecting pkg-config: checking for pkg-config... no configure: error: pkg-config is required Change-Id: Iebaa35a23e217a4cd7739af229cbfc08a3d8854a Signed-off-by: Arne Schwabe --- M configure.ac 1 file changed, 17 insertions(+), 5 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/65/465/3 diff --git a/configure.ac b/configure.ac index f420612..f009fe2 100644 --- a/configure.ac +++ b/configure.ac @@ -323,6 +323,7 @@ AM_CONDITIONAL([TARGET_LINUX], [true]) AC_DEFINE_UNQUOTED([TARGET_PREFIX], ["L"], [Target prefix]) have_sitnl=3D"yes" + pkg_config_required=3D"yes" ;; *-*-solaris*) AC_DEFINE([TARGET_SOLARIS], [1], [Are we running on Solaris?]) @@ -376,6 +377,16 @@ AM_CONDITIONAL([CROSS_COMPILING], test "${cross_compiling}" =3D "yes") PKG_PROG_PKG_CONFIG +# Add variable to print if pkg-config is found or not. Users often miss th= at +if test "${PKG_CONFIG}" =3D ""; then + if test "${pkg_config_required}" =3D "yes"; then + AC_MSG_ERROR([pkg-config is required]) + fi + pkg_config_found=3D"(not found)" +else + pkg_config_found=3D"(using ${PKG_CONFIG})" +fi + AC_PROG_CPP AC_PROG_INSTALL AC_PROG_LN_S @@ -810,7 +821,7 @@ [libnl-genl-3.0 >=3D 3.4.0], [have_libnl=3D"yes"], [ - AC_MSG_ERROR([libnl-genl-3.0 package not found or too old. Is the = development package and pkg-config installed? Must be version 3.4.0 or newe= r for DCO]) + AC_MSG_ERROR([libnl-genl-3.0 package not found or too old. Is the = development package and pkg-config ${pkg_config_found} installed? Must be v= ersion 3.4.0 or newer for DCO]) ] ) CFLAGS=3D"${CFLAGS} ${LIBNL_GENL_CFLAGS}" @@ -854,10 +865,11 @@ dnl case "$host" in *-*-linux*) + # We require pkg-config PKG_CHECK_MODULES([LIBCAPNG], [libcap-ng], [], - [AC_MSG_ERROR([libcap-ng package not found. Is the development packa= ge and pkg-config installed?])] + [AC_MSG_ERROR([libcap-ng package not found. Is the development packa= ge and pkg-config ${pkg_config_found} installed?])] ) AC_CHECK_HEADER([sys/prctl.h],,[AC_MSG_ERROR([sys/prctl.h not found!])]) @@ -878,7 +890,7 @@ [OPENSSL], [openssl >=3D 1.0.2], [have_openssl=3D"yes"], - [] # If this fails, we will do another test next + [AC_MSG_WARN([OpenSSL not found by pkg-config ${pkg_config_found}])] # = If this fails, we will do another test next ) OPENSSL_LIBS=3D${OPENSSL_LIBS:--lssl -lcrypto} fi @@ -1083,7 +1095,7 @@ [WOLFSSL], [wolfssl], [], - [AC_MSG_ERROR([Could not find wolfSSL.])] + [AC_MSG_ERROR([Could not find wolfSSL using pkg-config ${pkg_config_fou= nd}])] ) PKG_CHECK_VAR( [WOLFSSL_INCLUDEDIR], @@ -1508,7 +1520,7 @@ PKG_CHECK_MODULES( [CMOCKA], [cmocka], [have_cmocka=3D"yes"], - [AC_MSG_WARN([cmocka.pc not found on the system. Unit tests disabled])] + [AC_MSG_WARN([cmocka.pc not found on the system using pkg-config ${pkg_co= nfig_found}. Unit tests disabled])] ) AM_CONDITIONAL([ENABLE_UNITTESTS], [test "${enable_unit_tests}" =3D "yes" = -a "${have_cmocka}" =3D "yes" ]) AC_SUBST([ENABLE_UNITTESTS]) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/465?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iebaa35a23e217a4cd7739af229cbfc08a3d8854a Gerrit-Change-Number: 465 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-MessageType: newpatchset --yGzb3DpJvi8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld, plaisthos. <= /p>

plaisthos uploaded patch set #3 to this change.

<= a href=3D"http://gerrit.openvpn.net/c/openvpn/+/465?usp=3Demail">View Chang= e

The following approvals got outdated and were removed: Code-Review+2 by flichtenheld, Code-Review-1 by cron2

The change is n= o longer submittable: Code-Review and checks~ChecksSubmitRule are unsatisfi= ed now.

Make it more explicit and visible when pkg-config is not found
<= br>Users seem to struggle to read the full error message. This adds an
i= ndication if pkg-config is actually found to the warning/error message
t= hat use pkg-config.

On platforms that do not require pkg-config and = for optional libraries,
the existence of pkg-config is mentioned as part= of the error/warning message.

When found:

configure: err= or: libnl-genl-3.0 package not found or too old. Is the development package= and pkg-config (using /usr/bin/pkg-config) installed? Must be version 3.4.= 0 or newer for DCO

not found:

configure: error: libnl-gen= l-3.0 package not found or too old. Is the development package and pkg-conf= ig (not found) installed? Must be version 3.4.0 or newer for DCO

On = platforms where pkg-config is required (only Linux at the moment),
confi= gure will abort when not detecting pkg-config:

checking for pkg-conf= ig... no
configure: error: pkg-config is required

Change-Id: Ieba= a35a23e217a4cd7739af229cbfc08a3d8854a
Signed-off-by: Arne Schwabe <ar= ne@...1227...>
---
M configure.ac
1 file changed, 17 insertions= (+), 5 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openv=
pn refs/changes/65/465/3
diff --git a/configure.ac b/configure.ac
index f420612..f009fe2 100644
--- a/configur= e.ac
+++ b/configure.ac
@@ -323,6 +323,7 @@=
AM_CONDITIONAL([TARGET_LINUX], [true])
= AC_DEFINE_UNQUOTED([TARGET_PREFIX], ["L"], [Target prefix])
have_sitnl=3D"yes"
+ pkg_config_required=3D"yes" ;;
*-*-solaris*)
AC_DEFINE([= TARGET_SOLARIS], [1], [Are we running on Solaris?])
@@ -376= ,6 +377,16 @@
AM_CONDITIONAL([CROSS_COMPILING], test "= ;${cross_compiling}" =3D "yes")

= PKG_PROG_PKG_CONFIG
+# Add variable to print if pkg-config is found or not. Users often m= iss that
+if test &qu= ot;${PKG_CONFIG}" =3D ""; then
+ if test "${pkg_config_required}" = =3D "yes"; then
+ AC_MSG_ERROR([pkg-config is required])
+ fi
+ pkg_config_found=3D"(not found)"
= +else
+ pkg_config_found=3D"(using ${PKG_CONFIG= })"
+fi+
AC_PROG_CP= P
AC_PROG_INSTALL
AC_PROG_LN_S
= @@ -810,7 +821,7 @@
[libnl-genl-3.0 >=3D 3= .4.0],
[have_libnl=3D"yes"],
[

- = AC_MSG_ERROR([libnl-genl-3.0 package not found or too old. Is the developme= nt package and pkg-config installed? Must be version 3.4.0 or newer for DCO= ])
+ AC_MSG_ER= ROR([libnl-genl-3.0 package not found or too old. Is the development packag= e and pkg-config ${pkg_config_found} installed? Must be version 3.4.0 or ne= wer for DCO])
]
)
CFLAGS=3D"${CFLAGS} ${LIBNL_GENL_CFLAGS}"

@@ -854,10 +865,11 @@
dnl
case "$h= ost" in
*-*-linux*)
+ # We require pkg-config
PKG_CHE= CK_MODULES([LIBCAPNG],
[libcap-ng],
= [],
- [AC_M= SG_ERROR([libcap-ng package not found. Is the development package and pkg-c= onfig installed?])]
+= [AC_MSG_ERROR([libcap-ng package not found. Is the development packag= e and pkg-config ${pkg_config_found} installed?])]
)
AC_CHECK_HEADER([sys/prctl.h],,[AC_MSG_ERROR([sys/prctl.h n= ot found!])])

@@ -878,7 +890,7 @@<= br> [OPENSSL],
[openssl >=3D 1.0.2],=
[have_openssl=3D"yes"],
- [] # If this fails, we will do another test ne= xt
+ [AC_MSG_WARN([= OpenSSL not found by pkg-config ${pkg_config_found}])] # If this fails, we = will do another test next
)
OPENSSL_L= IBS=3D${OPENSSL_LIBS:--lssl -lcrypto}
fi
= @@ -1083,7 +1095,7 @@
[WOLFSSL],
[w= olfssl],
[],
- [AC_MSG_ERROR([Could not find wolfSSL.])]
+ [AC_MSG_ERROR([Could not find wolfSS= L using pkg-config ${pkg_config_found}])]
)
PKG_CHECK_VAR(

[WOLFSSL_INCLUDEDIR],
<= span>@@ -1508,7 +1520,7 @@
PKG_CHECK_MODULES(
[CMOCKA], [cmocka],
[have_cmocka=3D"yes"]= ,
- [AC_MSG_WARN([cmock= a.pc not found on the system. Unit tests disabled])]
+ [AC_MSG_WARN([cmocka.pc not found on the= system using pkg-config ${pkg_config_found}. Unit tests disabled])]
)
AM_CONDITIONAL([ENABLE_UNITTESTS], [test &qu= ot;${enable_unit_tests}" =3D "yes" -a "${have_cmocka}&q= uot; =3D "yes" ])
AC_SUBST([ENABLE_UNITTESTS])

To view, visit change 465. To unsubscribe, or= for help writing mail filters, visit settings.

<= /div>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iebaa35a23e217a4cd7739af229c= bfc08a3d8854a
Gerrit-Change-Number: 465
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newpatchset
--yGzb3DpJvi8=--