From: "Lendacky, Thomas" Subject: Re: [PATCH] scsi: smartpqi: properly set both the DMA mask and the coherent DMA mask in pqi_pci_init() Date: Thu, 23 May 2019 14:45:12 +0000 Message-ID: References: <20190523055212.23568-1-lijiang@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190523055212.23568-1-lijiang@redhat.com> Content-Language: en-US Content-ID: <6BA16298E5669743908BA574047E8C3B@namprd12.prod.outlook.com> Sender: linux-kernel-owner@vger.kernel.org To: Lianbo Jiang , "linux-kernel@vger.kernel.org" Cc: "don.brace@microsemi.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , "esc.storagedev@microsemi.com" , "dyoung@redhat.com" List-Id: linux-scsi@vger.kernel.org T24gNS8yMy8xOSAxMjo1MiBBTSwgTGlhbmJvIEppYW5nIHdyb3RlOg0KPiBXaGVuIFNNRSBpcyBl bmFibGVkLCB0aGUgc21hcnRwcWkgZHJpdmVyIHdvbid0IHdvcmsgb24gdGhlIEhQIERMMzg1DQo+ IEcxMCBtYWNoaW5lLCB3aGljaCBjYXVzZXMgdGhlIGZhaWx1cmUgb2Yga2VybmVsIGJvb3QgYmVj YXVzZSBpdCBmYWlscw0KPiB0byBhbGxvY2F0ZSBwcWkgZXJyb3IgYnVmZmVyLiBQbGVhc2UgcmVm ZXIgdG8gdGhlIGtlcm5lbCBsb2c6DQo+IC4uLi4NCj4gWyAgICA5LjQzMTc0OV0gdXNiY29yZTog cmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciB1YXMNCj4gWyAgICA5LjQ0MTUyNF0gTWlj cm9zZW1pIFBRSSBEcml2ZXIgKHYxLjEuNC0xMzApDQo+IFsgICAgOS40NDI5NTZdIGk0MGUgMDAw MDowNDowMC4wOiBmdyA2LjcwLjQ4NzY4IGFwaSAxLjcgbnZtIDEwLjIuNQ0KPiBbICAgIDkuNDQ3 MjM3XSBzbWFydHBxaSAwMDAwOjIzOjAwLjA6IE1pY3Jvc2VtaSBTbWFydCBGYW1pbHkgQ29udHJv bGxlciBmb3VuZA0KPiAgICAgICAgICBTdGFydGluZyBkcmFjdXQgaW5pdHF1ZXVlIGhvb2suLi4N Cj4gWyAgT0sgIF0gU3RhcnRlZCBTaG93IFBseW1vdXRoIEJvb3QgU2NyZVsgICAgOS40NzE2NTRd IEJyb2FkY29tIE5ldFh0cmVtZS1DL0UgZHJpdmVyIGJueHRfZW4gdjEuOS4xDQo+IGVuLg0KPiBb ICBPSyAgXSBTdGFydGVkIEZvcndhcmQgUGFzc3dvcmQgUmVxdWVzdHMgdG8gUGx5bW91dGggRGly ZWN0b3J5IFdhdGNoLg0KPiBbWzA7WyAgICA5LjQ4NzEwOF0gc21hcnRwcWkgMDAwMDoyMzowMC4w OiBmYWlsZWQgdG8gYWxsb2NhdGUgUFFJIGVycm9yIGJ1ZmZlcg0KPiAuLi4uDQo+IFsgIDEzOS4w NTA1NDRdIGRyYWN1dC1pbml0cXVldWVbOTQ5XTogV2FybmluZzogZHJhY3V0LWluaXRxdWV1ZSB0 aW1lb3V0IC0gc3RhcnRpbmcgdGltZW91dCBzY3JpcHRzDQo+IFsgIDEzOS41ODk3NzldIGRyYWN1 dC1pbml0cXVldWVbOTQ5XTogV2FybmluZzogZHJhY3V0LWluaXRxdWV1ZSB0aW1lb3V0IC0gc3Rh cnRpbmcgdGltZW91dCBzY3JpcHRzDQo+IA0KPiBGb3IgY29ycmVjdCBvcGVyYXRpb24sIGxldHMg Y2FsbCB0aGUgZG1hX3NldF9tYXNrX2FuZF9jb2hlcmVudCgpIHRvDQo+IHByb3Blcmx5IHNldCB0 aGUgbWFzayBmb3IgYm90aCBzdHJlYW1pbmcgYW5kIGNvaGVyZW50LCBpbiBvcmRlciB0bw0KPiBp bmZvcm0gdGhlIGtlcm5lbCBhYm91dCB0aGUgZGV2aWNlcyBETUEgYWRkcmVzc2luZyBjYXBhYmls aXRpZXMuDQoNCllvdSBzaG91bGQgcHJvYmFibHkgZXhwYW5kIG9uIHRoaXMgYSBiaXQuLi4gIEJh c2ljYWxseSwgdGhlIGZhY3QgdGhhdA0KdGhlIGNvaGVyZW50IERNQSBtYXNrIHZhbHVlIHdhc24n dCBzZXQgY2F1c2VkIHRoZSBkcml2ZXIgdG8gZmFsbCBiYWNrDQp0byBTV0lPVExCIHdoZW4gU01F IGlzIGFjdGl2ZS4gSSdtIG5vdCBzdXJlIGlmIHRoZSBmYWlsdXJlIHdhcyBmcm9tDQpydW5uaW5n IG91dCBvZiBTV0lPVExCIG9yIGV4Y2VlZGluZyB0aGUgbWF4aW11bSBhbGxvY2F0aW9uIHNpemUg Zm9yDQpTV0lPVExCLg0KDQpJIGJlbGlldmUgdGhlIGZpeCBpcyBwcm9wZXIsIGJ1dCBJJ2xsIGxl dCB0aGUgZHJpdmVyIG93bmVyIGNvbW1lbnQgb24NCnRoYXQuDQoNClRoYW5rcywNClRvbQ0KDQo+ IA0KPiBTaWduZWQtb2ZmLWJ5OiBMaWFuYm8gSmlhbmcgPGxpamlhbmdAcmVkaGF0LmNvbT4NCj4g LS0tDQo+ICBkcml2ZXJzL3Njc2kvc21hcnRwcWkvc21hcnRwcWlfaW5pdC5jIHwgMiArLQ0KPiAg MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9zY3NpL3NtYXJ0cHFpL3NtYXJ0cHFpX2luaXQuYyBiL2RyaXZlcnMv c2NzaS9zbWFydHBxaS9zbWFydHBxaV9pbml0LmMNCj4gaW5kZXggYzI2Y2FjODE5ZjllLi44YjFm ZGU2YzdkYWIgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvc2NzaS9zbWFydHBxaS9zbWFydHBxaV9p bml0LmMNCj4gKysrIGIvZHJpdmVycy9zY3NpL3NtYXJ0cHFpL3NtYXJ0cHFpX2luaXQuYw0KPiBA QCAtNzI4Miw3ICs3MjgyLDcgQEAgc3RhdGljIGludCBwcWlfcGNpX2luaXQoc3RydWN0IHBxaV9j dHJsX2luZm8gKmN0cmxfaW5mbykNCj4gICAgICAgICBlbHNlDQo+ICAgICAgICAgICAgICAgICBt YXNrID0gRE1BX0JJVF9NQVNLKDMyKTsNCj4gDQo+IC0gICAgICAgcmMgPSBkbWFfc2V0X21hc2so JmN0cmxfaW5mby0+cGNpX2Rldi0+ZGV2LCBtYXNrKTsNCj4gKyAgICAgICByYyA9IGRtYV9zZXRf bWFza19hbmRfY29oZXJlbnQoJmN0cmxfaW5mby0+cGNpX2Rldi0+ZGV2LCBtYXNrKTsNCj4gICAg ICAgICBpZiAocmMpIHsNCj4gICAgICAgICAgICAgICAgIGRldl9lcnIoJmN0cmxfaW5mby0+cGNp X2Rldi0+ZGV2LCAiZmFpbGVkIHRvIHNldCBETUEgbWFza1xuIik7DQo+ICAgICAgICAgICAgICAg ICBnb3RvIGRpc2FibGVfZGV2aWNlOw0KPiAtLQ0KPiAyLjE3LjENCj4gDQo=