Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A368F188713 for ; Thu, 22 May 2025 17:11:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747933871; cv=none; b=pfgk5OM7T2R/T8w7pOCUMMu0CiKC+AVxUqgvS7A4QG+74fFnkRZWbH3yWvo+nJ6t2wiMVLi6D+vT72xXjyGyvtLua2xvT9RigtOWqXTxOFs11GaQtZxXDdSUnP3Rqiq0oegsSK0O9f7tfVQem0rwY0HjyaJ7D3B8e57SjmuIymQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747933871; c=relaxed/simple; bh=jfxSMcZJMO8MDfMIiZmmfap8FL5PP1/hTt9xX+Kh6+k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OwrT8811Yfz0OPVn2ZnG0pCJS/ob/XTz1Q1VTrskGvdycRS6HsTh2l4kZxuJuBYjD3+9IAzZzhOu9aKcdgXjXGflTmOhg12ptKk1ohpRpKchIphSD/OI5Nwf2hP3Vog5HhzcDLQ5bpQhffUjfXFGV9b0wE8aYM9oPk8aZon56II= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CWXaT57J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CWXaT57J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7F76C4CEE4; Thu, 22 May 2025 17:11:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747933870; bh=jfxSMcZJMO8MDfMIiZmmfap8FL5PP1/hTt9xX+Kh6+k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CWXaT57JAQwh/W4ETy/HA+ap7QgWf35phwh8tjSK/DGUHkiUkPRaU75n0cKqJJG05 IKlqOhzNHt1Hg/nUC+3ztu3Cr4mCoAAqce/VzHillZ/gRg7RlSt7Fz6eK6TpJvjXrZ 1UKaYRYKCMa+MhwMKxBzjZ2iNcxJJq5ZvC/HYKasXVMNgYth/zlirW5uRYs+VSPeL+ p0kiVJ1Tgt5AS18kKmA9JFI4bDVdrqAmmyerutE0K+sJpxQ7RJ8r5bgP8eQWZ78Ywk ry7bWE6guKvPlThjUucTPA/4nxI4S2ov2EeB/nR5bnXYTAd8x1gjX3+PIdGs2HHh9B V7f9C0OuX2twA== Message-ID: Date: Thu, 22 May 2025 13:11:08 -0400 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 3/5] guestfs: Move console-related steps to guestfs role To: Luis Chamberlain Cc: kdevops@lists.linux.dev, Chuck Lever References: <20250522133137.989457-1-cel@kernel.org> <20250522133137.989457-4-cel@kernel.org> Content-Language: en-US From: Chuck Lever Organization: kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/22/25 1:09 PM, Luis Chamberlain wrote: > On Thu, May 22, 2025 at 09:31:35AM -0400, cel@kernel.org wrote: >> From: Chuck Lever >> >> These steps are relocated because my plan is to remove the >> bringup_guestfs role eventually. >> >> Signed-off-by: Chuck Lever > > For 4 and 5: > > But just one nit-pick: it says move, but its not deleting the code it > is moving. > > Reviewed-by: Luis Chamberlain > > LUis I'm planning to include a patch at the end that removes the bringup_guestfs role. But fair enough, I will change the verb to "copy". -- Chuck Lever