From: "flichtenheld (Code Review)" Date: Mon, 11 Mar 2024 14:45:37 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ZFUL+KWvJzo="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: plaisthos , openvpn-devel --ZFUL+KWvJzo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/523?usp=3Demail ) Change subject: Http-proxy: fix bug preventing proxy credentials caching ...................................................................... Patch Set 5: (4 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/523/comment/0095e7d0_7032f979 : PS5, Line 21: http_proxy_options and also a getter method to retrieve The man page for --auth-nocache still says it has no effect on --http-proxy= . This needs to be updated. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/10c5ad5e_1e39dee3 : PS5, Line 3126: if (ce->http_proxy_options) This needs to be moved one level up. E.g. when using "--proto tcp4-client" = currently --auth-nocache is ignored, since proto is already PROTO_TCP_CLIEN= T. There should be no issue with always setting this independently of ce->prot= o. File src/openvpn/proxy.h: http://gerrit.openvpn.net/c/openvpn/+/523/comment/2c3993c2_e1173cce : PS5, Line 61: bool nocache; Please update "show_http_proxy_options" in options.c to show value of nocac= he. File src/openvpn/proxy.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/663d790d_11843add : PS5, Line 669: if (p->up.nocache) wouldn't it be better to move this clearing into get_user_pass_http? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a Gerrit-Change-Number: 523 Gerrit-PatchSet: 5 Gerrit-Owner: its_Giaan Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Comment-Date: Mon, 11 Mar 2024 14:45:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --ZFUL+KWvJzo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: its_Giaan, plaisthos.

View C= hange

4 comments:

    =
  • Commit Message:

    • <= p style=3D"margin-bottom: 4px;">Patch Set #5, Line 21: http_proxy_options and also a getter m= ethod to retrieve

      The man page for --auth-nocache still says it has no effect on = --http-proxy. This needs to be updated.

  • File src/openvpn/options.c:

    • Patch Set #5, Line 3126: if (ce->http_proxy_options= )

      This= needs to be moved one level up. E.g. when using "--proto tcp4-client&= quot; currently --auth-nocache is ignored, since proto is already PROTO_TCP= _CLIENT.
      There should be no issue with always setting this independently= of ce->proto.

  • File src/openvpn/proxy.h:

      <= li style=3D"margin: 0; padding: 0 0 0 16px;">

      Patch Set #5, Line 61: bool nocache;

      Please update "show_http_proxy_options" in op= tions.c to show value of nocache.

  • File src/openvpn/proxy.c:

= To view, visit change 523. To unsubscribe, or for help writing mail filters, vis= it settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279= fb71c01a1a78a
Gerrit-Change-Number: 523
Gerrit-PatchSet: 5
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Comment-Date: Mon, 11 Mar 2024 14:45:37= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--ZFUL+KWvJzo=--