Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22139C55ABA for ; Wed, 5 Aug 2026 16:20:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wreLA-0002vf-1N; Wed, 05 Aug 2026 12:19:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wreL5-0002vO-Qd for qemu-devel@nongnu.org; Wed, 05 Aug 2026 12:19:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wreL3-00075Z-Kt for qemu-devel@nongnu.org; Wed, 05 Aug 2026 12:19:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785946767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0O5ZtYQODtIT8IU35n7B81cQ5fZ5krZawhbY2OU/jl4=; b=U+/FrNcqJOpTlOyL9x9nwimw8+Z9QLOzjuvCzXn2w3RFOYrxXs3nroSfA3cnpLkn6IRxqg btfuVc+OjiQmV7aCtZUoaS1vLDglFiCFn+/wZEQsf3629lwIK3dCE/h6MOnUPiMBiMkQpD OK0CEnPs2zB1lwwl/EML8Putyy46cCg= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-281-HTcvQaZwMZuAdpdDkp8grQ-1; Wed, 05 Aug 2026 12:19:24 -0400 X-MC-Unique: HTcvQaZwMZuAdpdDkp8grQ-1 X-Mimecast-MFC-AGG-ID: HTcvQaZwMZuAdpdDkp8grQ_1785946763 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A77DB1954AEC; Wed, 5 Aug 2026 16:19:22 +0000 (UTC) Received: from [10.44.32.79] (unknown [10.44.32.79]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6092A1800598; Wed, 5 Aug 2026 16:19:21 +0000 (UTC) Date: Wed, 5 Aug 2026 18:19:15 +0200 (CEST) From: Mikulas Patocka To: Richard Henderson cc: Yoshinori Sato , qemu-devel@nongnu.org Subject: Re: [PATCH] linux-user/sh4: Deliver SIGILL on invalid instruction In-Reply-To: <841905d0-6967-4560-b07f-d040e992f4fa@linaro.org> Message-ID: References: <2a3f1f1e-459e-5d36-0c1c-e56568cced9c@redhat.com> <841905d0-6967-4560-b07f-d040e992f4fa@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=mpatocka@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.852, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, 5 Aug 2026, Richard Henderson wrote: > On 8/3/26 12:42, Mikulas Patocka wrote: > > On invalid instruction, deliver SIGILL rather than crashing the whole > > process unconditionally. > > > > Cc: qemu-stable@nongnu.org > > Signed-off-by: Mikulas Patocka > > > > --- > > linux-user/sh4/cpu_loop.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > Index: qemu/linux-user/sh4/cpu_loop.c > > =================================================================== > > --- qemu.orig/linux-user/sh4/cpu_loop.c 2026-08-02 19:02:25.000000000 > > +0200 > > +++ qemu/linux-user/sh4/cpu_loop.c 2026-08-02 19:06:40.000000000 +0200 > > @@ -64,6 +64,10 @@ void cpu_loop(CPUSH4State *env) > > cpu_exec_step_atomic(cs); > > arch_interrupt = false; > > break; > > + case 0x180: > > + /* Illegal instruction */ > > + force_sig_fault(TARGET_SIGILL, TARGET_ILL_ILLOPC, env->pc); > > + break; > > default: > > fprintf(stderr, "Unhandled trap: 0x%x\n", trapnr); > > cpu_dump_state(cs, stderr, 0); > > > > Missing 0x1a0, from helper_raise_slot_illegal_instruction. > > r~ OK, I'm sending version 2 of the patch. Mikulas