From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm/amdgpu: allocate gart memory when it's required (v3) Date: Wed, 4 Jul 2018 12:50:28 +0200 Message-ID: References: <1530088098-10566-1-git-send-email-Jerry.Zhang@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1530088098-10566-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Junwei Zhang , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Felix.Kuehling-5C7GfCeVMHo@public.gmane.org, christian.koenig-5C7GfCeVMHo@public.gmane.org QW0gMjcuMDYuMjAxOCB1bSAxMDoyOCBzY2hyaWViIEp1bndlaSBaaGFuZzoKPiBJbnN0ZWFkIG9m IGNhbGxpbmcgZ2FydCBtZW1vcnkgb24gZXZlcnkgYm8gcGluLAo+IGFsbG9jYXRlcyBpdCBvbiBk ZW1hbmQKPgo+IHYyOiBmaXggZXJyb3IgaGFuZGxpbmcKPiB2MzogZHJvcCB0aGUgY2hhbmdlIGZv ciBrZmQgZ3R0IGJvIG1hcHBpbmcsIG5vdCBuZWVkZWQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBKdW53 ZWkgWmhhbmcgPEplcnJ5LlpoYW5nQGFtZC5jb20+CgpSZXZpZXdlZC1ieTogQ2hyaXN0aWFuIEvD tm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgoKPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdV9hbWRrZmQuYyAgICAgICAgfCAgNiArKysrKysKPiAgIGRyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9iZW5jaG1hcmsuYyAgICAgfCAxNCArKysrKysr KysrKystLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rpc3BsYXkuYyAg ICAgICB8ICA2ICsrKysrKwo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Zi LmMgICAgICAgICAgICB8ICA4ICsrKysrKysrCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfb2JqZWN0LmMgICAgICAgIHwgMTUgKysrKysrKysrLS0tLS0tCj4gICBkcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdGVzdC5jICAgICAgICAgIHwgIDUgKysrKysKPiAg IGRyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMgfCAxMyAr KysrKysrKysrKy0tCj4gICA3IGZpbGVzIGNoYW5nZWQsIDU3IGluc2VydGlvbnMoKyksIDEwIGRl bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdV9hbWRrZmQuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9hbWRrZmQu Ywo+IGluZGV4IDk4ZTNiZjguLmUzZWQwOGQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X2FtZGtmZC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X2FtZGtmZC5jCj4gQEAgLTI4MCw2ICsyODAsMTIgQEAgaW50IGFsbG9jX2d0 dF9tZW0oc3RydWN0IGtnZF9kZXYgKmtnZCwgc2l6ZV90IHNpemUsCj4gICAJCWdvdG8gYWxsb2Nh dGVfbWVtX3Bpbl9ib19mYWlsZWQ7Cj4gICAJfQo+ICAgCj4gKwlyID0gYW1kZ3B1X3R0bV9hbGxv Y19nYXJ0KCZiby0+dGJvKTsKPiArCWlmIChyKSB7Cj4gKwkJZGV2X2VycihhZGV2LT5kZXYsICIl cCBiaW5kIGZhaWxlZFxuIiwgYm8pOwo+ICsJCWdvdG8gYWxsb2NhdGVfbWVtX2ttYXBfYm9fZmFp bGVkOwo+ICsJfQo+ICsKPiAgIAlyID0gYW1kZ3B1X2JvX2ttYXAoYm8sICZjcHVfcHRyX3RtcCk7 Cj4gICAJaWYgKHIpIHsKPiAgIAkJZGV2X2VycihhZGV2LT5kZXYsCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9iZW5jaG1hcmsuYyBiL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9iZW5jaG1hcmsuYwo+IGluZGV4IGNiODhkN2UuLjMwNzll YTggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2JlbmNo bWFyay5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2JlbmNobWFy ay5jCj4gQEAgLTk2LDExICs5NiwxNiBAQCBzdGF0aWMgdm9pZCBhbWRncHVfYmVuY2htYXJrX21v dmUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIHVuc2lnbmVkIHNpemUsCj4gICAJaWYgKHVu bGlrZWx5KHIgIT0gMCkpCj4gICAJCWdvdG8gb3V0X2NsZWFudXA7Cj4gICAJciA9IGFtZGdwdV9i b19waW4oc29iaiwgc2RvbWFpbik7Cj4gLQlzYWRkciA9IGFtZGdwdV9ib19ncHVfb2Zmc2V0KHNv YmopOwo+ICsJaWYgKHIpIHsKPiArCQlhbWRncHVfYm9fdW5yZXNlcnZlKHNvYmopOwo+ICsJCWdv dG8gb3V0X2NsZWFudXA7Cj4gKwl9Cj4gKwlyID0gYW1kZ3B1X3R0bV9hbGxvY19nYXJ0KCZzb2Jq LT50Ym8pOwo+ICAgCWFtZGdwdV9ib191bnJlc2VydmUoc29iaik7Cj4gICAJaWYgKHIpIHsKPiAg IAkJZ290byBvdXRfY2xlYW51cDsKPiAgIAl9Cj4gKwlzYWRkciA9IGFtZGdwdV9ib19ncHVfb2Zm c2V0KHNvYmopOwo+ICAgCWJwLmRvbWFpbiA9IGRkb21haW47Cj4gICAJciA9IGFtZGdwdV9ib19j cmVhdGUoYWRldiwgJmJwLCAmZG9iaik7Cj4gICAJaWYgKHIpIHsKPiBAQCAtMTEwLDExICsxMTUs MTYgQEAgc3RhdGljIHZvaWQgYW1kZ3B1X2JlbmNobWFya19tb3ZlKHN0cnVjdCBhbWRncHVfZGV2 aWNlICphZGV2LCB1bnNpZ25lZCBzaXplLAo+ICAgCWlmICh1bmxpa2VseShyICE9IDApKQo+ICAg CQlnb3RvIG91dF9jbGVhbnVwOwo+ICAgCXIgPSBhbWRncHVfYm9fcGluKGRvYmosIGRkb21haW4p Owo+IC0JZGFkZHIgPSBhbWRncHVfYm9fZ3B1X29mZnNldChkb2JqKTsKPiArCWlmIChyKSB7Cj4g KwkJYW1kZ3B1X2JvX3VucmVzZXJ2ZShzb2JqKTsKPiArCQlnb3RvIG91dF9jbGVhbnVwOwo+ICsJ fQo+ICsJciA9IGFtZGdwdV90dG1fYWxsb2NfZ2FydCgmZG9iai0+dGJvKTsKPiAgIAlhbWRncHVf Ym9fdW5yZXNlcnZlKGRvYmopOwo+ICAgCWlmIChyKSB7Cj4gICAJCWdvdG8gb3V0X2NsZWFudXA7 Cj4gICAJfQo+ICsJZGFkZHIgPSBhbWRncHVfYm9fZ3B1X29mZnNldChkb2JqKTsKPiAgIAo+ICAg CWlmIChhZGV2LT5tbWFuLmJ1ZmZlcl9mdW5jcykgewo+ICAgCQl0aW1lID0gYW1kZ3B1X2JlbmNo bWFya19kb19tb3ZlKGFkZXYsIHNpemUsIHNhZGRyLCBkYWRkciwgbik7Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kaXNwbGF5LmMgYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGlzcGxheS5jCj4gaW5kZXggMDM2YjZmNy4uN2Q2YTM2 YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGlzcGxh eS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rpc3BsYXkuYwo+ IEBAIC0xOTQsNiArMTk0LDEyIEBAIGludCBhbWRncHVfZGlzcGxheV9jcnRjX3BhZ2VfZmxpcF90 YXJnZXQoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAgCQlnb3RvIHVucmVzZXJ2ZTsKPiAgIAl9 Cj4gICAKPiArCXIgPSBhbWRncHVfdHRtX2FsbG9jX2dhcnQoJm5ld19hYm8tPnRibyk7Cj4gKwlp ZiAodW5saWtlbHkociAhPSAwKSkgewo+ICsJCURSTV9FUlJPUigiJXAgYmluZCBmYWlsZWRcbiIs IG5ld19hYm8pOwo+ICsJCWdvdG8gdW5waW47Cj4gKwl9Cj4gKwo+ICAgCXIgPSByZXNlcnZhdGlv bl9vYmplY3RfZ2V0X2ZlbmNlc19yY3UobmV3X2Fiby0+dGJvLnJlc3YsICZ3b3JrLT5leGNsLAo+ ICAgCQkJCQkgICAgICAmd29yay0+c2hhcmVkX2NvdW50LAo+ICAgCQkJCQkgICAgICAmd29yay0+ c2hhcmVkKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X2ZiLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZmIuYwo+IGluZGV4IDQ2 MmI3YTEuLmNkNjhhMmUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X2ZiLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZmIu Ywo+IEBAIC0xNzMsNiArMTczLDE0IEBAIHN0YXRpYyBpbnQgYW1kZ3B1ZmJfY3JlYXRlX3Bpbm5l ZF9vYmplY3Qoc3RydWN0IGFtZGdwdV9mYmRldiAqcmZiZGV2LAo+ICAgCQlhbWRncHVfYm9fdW5y ZXNlcnZlKGFibyk7Cj4gICAJCWdvdG8gb3V0X3VucmVmOwo+ICAgCX0KPiArCj4gKwlyZXQgPSBh bWRncHVfdHRtX2FsbG9jX2dhcnQoJmFiby0+dGJvKTsKPiArCWlmIChyZXQpIHsKPiArCQlhbWRn cHVfYm9fdW5yZXNlcnZlKGFibyk7Cj4gKwkJZGV2X2VycihhZGV2LT5kZXYsICIlcCBiaW5kIGZh aWxlZFxuIiwgYWJvKTsKPiArCQlnb3RvIG91dF91bnJlZjsKPiArCX0KPiArCj4gICAJcmV0ID0g YW1kZ3B1X2JvX2ttYXAoYWJvLCBOVUxMKTsKPiAgIAlhbWRncHVfYm9fdW5yZXNlcnZlKGFibyk7 Cj4gICAJaWYgKHJldCkgewo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfb2JqZWN0LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfb2Jq ZWN0LmMKPiBpbmRleCA3OWNkYmYxLi43ZjdjMjIxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9vYmplY3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV9vYmplY3QuYwo+IEBAIC0yNTcsNiArMjU3LDEzIEBAIGludCBhbWRn cHVfYm9fY3JlYXRlX3Jlc2VydmVkKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+ICAgCQlk ZXZfZXJyKGFkZXYtPmRldiwgIiglZCkga2VybmVsIGJvIHBpbiBmYWlsZWRcbiIsIHIpOwo+ICAg CQlnb3RvIGVycm9yX3VucmVzZXJ2ZTsKPiAgIAl9Cj4gKwo+ICsJciA9IGFtZGdwdV90dG1fYWxs b2NfZ2FydCgmKCpib19wdHIpLT50Ym8pOwo+ICsJaWYgKHIpIHsKPiArCQlkZXZfZXJyKGFkZXYt PmRldiwgIiVwIGJpbmQgZmFpbGVkXG4iLCAqYm9fcHRyKTsKPiArCQlnb3RvIGVycm9yX3VucGlu Owo+ICsJfQo+ICsKPiAgIAlpZiAoZ3B1X2FkZHIpCj4gICAJCSpncHVfYWRkciA9IGFtZGdwdV9i b19ncHVfb2Zmc2V0KCpib19wdHIpOwo+ICAgCj4gQEAgLTI3MCw2ICsyNzcsOCBAQCBpbnQgYW1k Z3B1X2JvX2NyZWF0ZV9yZXNlcnZlZChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgIAo+ ICAgCXJldHVybiAwOwo+ICAgCj4gK2Vycm9yX3VucGluOgo+ICsJYW1kZ3B1X2JvX3VucGluKCpi b19wdHIpOwo+ICAgZXJyb3JfdW5yZXNlcnZlOgo+ICAgCWFtZGdwdV9ib191bnJlc2VydmUoKmJv X3B0cik7Cj4gICAKPiBAQCAtOTAzLDEyICs5MTIsNiBAQCBpbnQgYW1kZ3B1X2JvX3Bpbl9yZXN0 cmljdGVkKHN0cnVjdCBhbWRncHVfYm8gKmJvLCB1MzIgZG9tYWluLAo+ICAgCQlnb3RvIGVycm9y Owo+ICAgCX0KPiAgIAo+IC0JciA9IGFtZGdwdV90dG1fYWxsb2NfZ2FydCgmYm8tPnRibyk7Cj4g LQlpZiAodW5saWtlbHkocikpIHsKPiAtCQlkZXZfZXJyKGFkZXYtPmRldiwgIiVwIGJpbmQgZmFp bGVkXG4iLCBibyk7Cj4gLQkJZ290byBlcnJvcjsKPiAtCX0KPiAtCj4gICAJYm8tPnBpbl9jb3Vu dCA9IDE7Cj4gICAKPiAgIAlkb21haW4gPSBhbWRncHVfbWVtX3R5cGVfdG9fZG9tYWluKGJvLT50 Ym8ubWVtLm1lbV90eXBlKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X3Rlc3QuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90ZXN0 LmMKPiBpbmRleCA2MjJhZmZjLi5kNmVlZWExIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdV90ZXN0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfdGVzdC5jCj4gQEAgLTEwMiw2ICsxMDIsMTEgQEAgc3RhdGljIHZvaWQgYW1k Z3B1X2RvX3Rlc3RfbW92ZXMoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICAJCQlEUk1f RVJST1IoIkZhaWxlZCB0byBwaW4gR1RUIG9iamVjdCAlZFxuIiwgaSk7Cj4gICAJCQlnb3RvIG91 dF9sY2xlYW5fdW5yZXM7Cj4gICAJCX0KPiArCQlyID0gYW1kZ3B1X3R0bV9hbGxvY19nYXJ0KCZn dHRfb2JqW2ldLT50Ym8pOwo+ICsJCWlmIChyKSB7Cj4gKwkJCURSTV9FUlJPUigiJXAgYmluZCBm YWlsZWRcbiIsIGd0dF9vYmpbaV0pOwo+ICsJCQlnb3RvIG91dF9sY2xlYW5fdW5waW47Cj4gKwkJ fQo+ICAgCQlnYXJ0X2FkZHIgPSBhbWRncHVfYm9fZ3B1X29mZnNldChndHRfb2JqW2ldKTsKPiAg IAo+ICAgCQlyID0gYW1kZ3B1X2JvX2ttYXAoZ3R0X29ialtpXSwgJmd0dF9tYXApOwo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5j IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG0uYwo+IGlu ZGV4IDMxNjUyYzFlLi5kNDMzNDI4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv ZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5jCj4gQEAgLTMxMTAsMTMgKzMxMTAsMjIgQEAg c3RhdGljIGludCBkbV9wbGFuZV9oZWxwZXJfcHJlcGFyZV9mYihzdHJ1Y3QgZHJtX3BsYW5lICpw bGFuZSwKPiAgIAkJZG9tYWluID0gQU1ER1BVX0dFTV9ET01BSU5fVlJBTTsKPiAgIAo+ICAgCXIg PSBhbWRncHVfYm9fcGluKHJibywgZG9tYWluKTsKPiAtCWFtZGdwdV9ib191bnJlc2VydmUocmJv KTsKPiAtCj4gICAJaWYgKHVubGlrZWx5KHIgIT0gMCkpIHsKPiAgIAkJaWYgKHIgIT0gLUVSRVNU QVJUU1lTKQo+ICAgCQkJRFJNX0VSUk9SKCJGYWlsZWQgdG8gcGluIGZyYW1lYnVmZmVyIHdpdGgg ZXJyb3IgJWRcbiIsIHIpOwo+ICsJCWFtZGdwdV9ib191bnJlc2VydmUocmJvKTsKPiArCQlyZXR1 cm4gcjsKPiArCX0KPiArCj4gKwlyID0gYW1kZ3B1X3R0bV9hbGxvY19nYXJ0KCZyYm8tPnRibyk7 Cj4gKwlpZiAodW5saWtlbHkociAhPSAwKSkgewo+ICsJCWFtZGdwdV9ib191bnBpbihyYm8pOwo+ ICsJCWFtZGdwdV9ib191bnJlc2VydmUocmJvKTsKPiArCQlEUk1fRVJST1IoIiVwIGJpbmQgZmFp bGVkXG4iLCByYm8pOwo+ICAgCQlyZXR1cm4gcjsKPiAgIAl9Cj4gKwlhbWRncHVfYm9fdW5yZXNl cnZlKHJibyk7Cj4gKwo+ICAgCWFmYi0+YWRkcmVzcyA9IGFtZGdwdV9ib19ncHVfb2Zmc2V0KHJi byk7Cj4gICAKPiAgIAlhbWRncHVfYm9fcmVmKHJibyk7CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2FtZC1nZngK