From: "flichtenheld (Code Review)" Date: Mon, 20 Apr 2026 11:48:34 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Noas3uLx0EY="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: GHA: Factor out building SSL libs to a reusable workflow List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --Noas3uLx0EY= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1630?usp=3Demail to review the following change. Change subject: GHA: Factor out building SSL libs to a reusable workflow ...................................................................... GHA: Factor out building SSL libs to a reusable workflow We amassed a lot of code duplication there. Make it easier to track the differences between the libraries. Change-Id: I3d89016ccae297cfa596897c11a518f1ffbe3dc8 Signed-off-by: Frank Lichtenheld --- M .github/workflows/build.yaml A .github/workflows/test-ssllib.yml M renovate.json 3 files changed, 152 insertions(+), 313 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/30/1630/1 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 365e72a..e4cb799 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -304,324 +304,49 @@ !${{ github.workspace }}/out/**/vcpkg_installed/** libressl: - strategy: - fail-fast: false - matrix: - os: [ubuntu-24.04] - ssllib: [libressl] - build: [ normal, asan ] - configureflags: ["--with-openssl-engine=3Dno"] - include: - - build: asan - cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fn= o-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame= -pointer -g -O1" - ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall - cc: clang - - build: normal - cflags: "-O2 -g" - ldflags: "" - cc: gcc - - name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{matrix.s= sllib}}" - runs-on: ${{matrix.os}} - env: - CFLAGS: ${{ matrix.cflags }} - LDFLAGS: ${{ matrix.ldflags }} - CC: ${{matrix.cc}} - UBSAN_OPTIONS: print_stacktrace=3D1 + uses: ./.github/workflows/test-ssllib.yml + with: + libname: libressl + ovpnlibdesc: LibreSSL # versioning=3Dsemver-coerced - LIBRESSL_REPO: libressl/portable - LIBRESSL_VERSION: v4.2.1 - LIBRESSL_INSTALL: /opt/libressl + ghrepo: libressl/portable + gitref: v4.2.1 + libconfigure: "LIBRESSL_GIT_OPTIONS=3D--no-single-branch ./autogen.s= h && ./configure --prefix=3D$LIBPREFIX" - steps: - - name: Install dependencies - run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-d= ev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils = libtool automake autoconf pkg-config libcap-ng-dev libnl-genl-3-dev - - name: Restore libressl from cache - uses: actions/cache@...3010... - id: libressl-cache - with: - path: ${{ env.LIBRESSL_INSTALL }} - key: ${{ matrix.os }}-libressl-${{matrix.build }}-${{ env.LIBRES= SL_VERSION }} - - name: "libressl: checkout" - if: steps.libressl-cache.outputs.cache-hit !=3D 'true' - uses: actions/checkout@...2998... # v6.0.2 - with: - path: libressl - repository: ${{ env.LIBRESSL_REPO }} - ref: ${{ env.LIBRESSL_VERSION }} - - name: "libressl: autogen.sh" - if: steps.libressl-cache.outputs.cache-hit !=3D 'true' - env: - LIBRESSL_GIT_OPTIONS: "--no-single-branch" - run: ./autogen.sh - working-directory: libressl - - name: "libressl: configure" - if: steps.libressl-cache.outputs.cache-hit !=3D 'true' - run: ./configure --prefix=3D${{ env.LIBRESSL_INSTALL }} - working-directory: libressl - - name: "libressl: make all" - if: steps.libressl-cache.outputs.cache-hit !=3D 'true' - run: make -j3 - working-directory: libressl - - name: "libressl: make install" - if: steps.libressl-cache.outputs.cache-hit !=3D 'true' - run: sudo make install - working-directory: libressl - - name: "ldconfig" - run: sudo ldconfig - - name: Checkout OpenVPN - uses: actions/checkout@...2998... # v6.0.2 - - name: autoconf - run: autoreconf -fvi - - name: configure - run: | - OPENSSL_CFLAGS=3D"-I${{ env.LIBRESSL_INSTALL }}/include" \ - OPENSSL_LIBS=3D"-L${{ env.LIBRESSL_INSTALL }}/lib -lssl -lcrypto= " \ - LDFLAGS=3D"-Wl,-rpath=3D${{ env.LIBRESSL_INSTALL }}/lib" \ - ./configure --with-crypto-library=3Dopenssl --enable-werror ${{m= atrix.configureflags}} - - name: make all - run: make -j3 - - name: Ensure the build uses LibreSSL - run: | - ./src/openvpn/openvpn --version - ./src/openvpn/openvpn --version | grep -q "library versions: Lib= reSSL" - - name: configure checks - run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc - - name: make check - run: make -j3 check VERBOSE=3D1 - - openssl: - strategy: - fail-fast: false - matrix: - os: [ubuntu-24.04] - ssllib: [openssl] - build: [ normal, asan ] - configureflags: ["--with-openssl-engine=3Dno"] - include: - - build: asan - cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fn= o-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame= -pointer -g -O1" - ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall - cc: clang - - build: normal - cflags: "-O2 -g" - ldflags: "" - cc: gcc - - name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{matrix.s= sllib}} - 4.0" - runs-on: ${{matrix.os}} - env: - CFLAGS: ${{ matrix.cflags }} - LDFLAGS: ${{ matrix.ldflags }} - CC: ${{matrix.cc}} - UBSAN_OPTIONS: print_stacktrace=3D1 + openssl4: + uses: ./.github/workflows/test-ssllib.yml + with: + libname: openssl + ovpnlibdesc: OpenSSL 4. # versioning=3Dsemver-coerced - OPENSSL_REPO: openssl/openssl - OPENSSL_VERSION: openssl-4.0.0-beta1 - OPENSSL_INSTALL: /opt/openssl - - steps: - - name: Install dependencies - run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-d= ev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils = libtool automake autoconf pkg-config libcap-ng-dev libnl-genl-3-dev - - name: Restore OpenSSL 4.0 from cache - uses: actions/cache@...3010... - id: openssl-cache - with: - path: ${{ env.OPENSSL_INSTALL }} - key: ${{ matrix.os }}-openssl-${{matrix.build }}-${{ env.OPENSSL= _VERSION }} - - name: "openssl: checkout" - if: steps.openssl-cache.outputs.cache-hit !=3D 'true' - uses: actions/checkout@...2998... # v6.0.2 - with: - path: openssl - repository: ${{ env.OPENSSL_REPO }} - ref: ${{ env.OPENSSL_VERSION }} - - name: "openssl: configure" - if: steps.openssl-cache.outputs.cache-hit !=3D 'true' - run: ./Configure --prefix=3D${{ env.OPENSSL_INSTALL }} --libdir= =3D${{ env.OPENSSL_INSTALL }}/lib --openssldir=3D${{ env.OPENSSL_INSTALL }}= -g - working-directory: openssl - - name: "openssl: make all" - if: steps.openssl-cache.outputs.cache-hit !=3D 'true' - run: make -j3 - working-directory: openssl - - name: "openssl: make install" - if: steps.openssl-cache.outputs.cache-hit !=3D 'true' - run: sudo make install - working-directory: openssl - - name: "ldconfig" - run: sudo ldconfig - - name: Checkout OpenVPN - uses: actions/checkout@...2998... # v6.0.2 - - name: autoconf - run: autoreconf -fvi - - name: configure - run: | - OPENSSL_CFLAGS=3D"-I${{ env.OPENSSL_INSTALL }}/include" \ - OPENSSL_LIBS=3D"-L${{ env.OPENSSL_INSTALL }}/lib -lssl -lcrypto"= \ - LDFLAGS=3D"-Wl,-rpath=3D${{ env.OPENSSL_INSTALL }}/lib" \ - ./configure --with-crypto-library=3Dopenssl --enable-werror ${{m= atrix.configureflags}} - - name: make all - run: make -j3 - - name: Ensure the build uses Openssl - run: | - ./src/openvpn/openvpn --version - ./src/openvpn/openvpn --version | grep -q "library versions: Ope= nSSL 4.0" - - name: configure checks - run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc - - name: make check - run: make -j3 check VERBOSE=3D1 + ghrepo: openssl/openssl + gitref: openssl-4.0.0-beta1 + libconfigure: ./Configure --prefix=3D$LIBPREFIX --libdir=3D$LIBPREFI= X/lib --openssldir=3D$LIBPREFIX -g mbedtls4: - strategy: - fail-fast: false - matrix: - os: [ubuntu-24.04] - ssllib: [mbedtls4] - build: [ normal, asan ] - include: - - build: asan - cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fn= o-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame= -pointer -g -O1" - ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall - cc: clang - - build: normal - cflags: "-O2 -g" - ldflags: "" - cc: gcc - - name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{matrix.s= sllib}}" - runs-on: ${{matrix.os}} - env: - CFLAGS: ${{ matrix.cflags }} - LDFLAGS: ${{ matrix.ldflags }} - CC: ${{matrix.cc}} - UBSAN_OPTIONS: print_stacktrace=3D1 - PKG_CONFIG_PATH: /opt/mbedtls4/lib/pkgconfig + uses: ./.github/workflows/test-ssllib.yml + with: + libname: mbedtls + ovpnlibname: mbedtls + ovpnlibdesc: mbed TLS 4. # versioning=3Dsemver-coerced - MBEDTLS_REPO: Mbed-TLS/mbedtls - MBEDTLS_VERSION: v4.0.0 - MBEDTLS_INSTALL: /opt/mbedtls4 - - steps: - - name: Install dependencies - run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-d= ev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils = python3-jinja2 python3-jsonschema libtool automake autoconf pkg-config libc= ap-ng-dev libnl-genl-3-dev - - name: Restore mbed TLS from cache - uses: actions/cache@...3010... - id: mbedtls-cache - with: - path: ${{ env.MBEDTLS_INSTALL }} - key: ${{ matrix.os }}-mbedtls-${{matrix.build }}-${{ env.MBEDTLS= _VERSION }} - - name: "mbedtls: checkout" - if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true' - uses: actions/checkout@...2998... # v6.0.2 - with: - path: mbedtls - submodules: recursive - repository: ${{ env.MBEDTLS_REPO }} - ref: ${{ env.MBEDTLS_VERSION }} - - uses: lukka/get-cmake@...2999... # v4.2.3 - - name: "mbedtls: cmake" - if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true' - run: cmake -B build -DCMAKE_INSTALL_PREFIX=3D${{ env.MBEDTLS_INSTA= L }} - working-directory: mbedtls - - name: "mbedtls: cmake --build" - if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true' - run: cmake --build build - working-directory: mbedtls - - name: "mbedtls: cmake --install" - if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true' - run: sudo cmake --install build - working-directory: mbedtls - - name: Checkout OpenVPN - uses: actions/checkout@...2998... # v6.0.2 - - name: autoconf - run: autoreconf -fvi - - name: configure - run: ./configure --with-crypto-library=3Dmbedtls --enable-werror - - name: make all - run: make -j3 - - name: Ensure the build uses mbed TLS ${{ env.MBEDTLS_VERSION }} - run: | - ./src/openvpn/openvpn --version - ./src/openvpn/openvpn --version | grep -q "library versions: mbe= d TLS 4." - - name: configure checks - run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc - - name: make check - run: make -j3 check VERBOSE=3D1 + ghrepo: Mbed-TLS/mbedtls + gitref: v4.0.0 + libconfigure: cmake -B build -DCMAKE_INSTALL_PREFIX=3D$LIBPREFIX + libmake: cmake --build build + libinstall: sudo cmake --install build + ovpnconfigureenv: PKG_CONFIG_PATH=3D$LIBPREFIX/lib/pkgconfig aws-lc: - strategy: - fail-fast: false - matrix: - os: [ubuntu-24.04] - ssllib: [ awslc ] - build: [ normal, asan ] - include: - - build: asan - cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fn= o-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame= -pointer -g -O1" - ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall - cc: clang - cxx: clang++ - - build: normal - cflags: "-O2 -g" - ldflags: "" - cc: gcc - cxx: c++ - - name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{matrix.s= sllib}}" - runs-on: ${{matrix.os}} - env: - CFLAGS: ${{ matrix.cflags }} - LDFLAGS: ${{ matrix.ldflags }} - CC: ${{matrix.cc}} - CXX: ${{matrix.cxx}} - UBSAN_OPTIONS: print_stacktrace=3D1 - AWS_LC_INSTALL: /opt/aws-lc + uses: ./.github/workflows/test-ssllib.yml + with: + libname: aws-lc + ovpnlibdesc: AWS-LC # versioning=3Dsemver-coerced - AWS_LC_REPO: aws/aws-lc - AWS_LC_VERSION: v1.70.0 - - steps: - - name: Install dependencies - run: sudo apt update && sudo apt install -y gcc golang make liblzo= 2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang libcmocka-dev p= ython3-docutils python3-jinja2 python3-jsonschema libtool automake autoconf= pkg-config libcap-ng-dev libnl-genl-3-dev - - name: Restore AWS-LC from cache - uses: actions/cache@...3010... - id: aws-lc-cache - with: - path: ${{ env.AWS_LC_INSTALL }} - key: ${{ matrix.os }}-aws-lc-${{matrix.build }}-${{ env.AWS_LC_V= ERSION }} - - name: "AWS-LC: checkout" - if: steps.aws-lc-cache.outputs.cache-hit !=3D 'true' - uses: actions/checkout@...2998... # v6.0.2 - with: - path: aws-lc - repository: ${{ env.AWS_LC_REPO }} - ref: ${{ env.AWS_LC_VERSION }} - - uses: lukka/get-cmake@...2999... # v4.2.3 - - name: "AWS-LC: build" - if: steps.aws-lc-cache.outputs.cache-hit !=3D 'true' - run: | - mkdir build - cd build - cmake -GNinja -DCMAKE_BUILD_TYPE=3DRelease -DCMAKE_INSTALL_PREFI= X=3D"${{ env.AWS_LC_INSTALL }}" -DBUILD_SHARED_LIBS=3D1 ../ - ninja install - working-directory: aws-lc - - name: Checkout OpenVPN - uses: actions/checkout@...2998... # v6.0.2 - - name: autoconf - run: autoreconf -fvi - - name: configure with AWS-LC - run: | - OPENSSL_CFLAGS=3D"-I${{ env.AWS_LC_INSTALL }}/include" \ - OPENSSL_LIBS=3D"-L${{ env.AWS_LC_INSTALL }}/lib -lssl -lcrypto" \ - LDFLAGS=3D"-Wl,-rpath=3D${{ env.AWS_LC_INSTALL }}/lib" \ - ./configure --with-crypto-library=3Dopenssl - - name: make all - run: make -j3 - - name: Ensure the build uses AWS-LC - run: | - ./src/openvpn/openvpn --version - ./src/openvpn/openvpn --version | grep -q "library versions: AWS= -LC" - - name: configure checks - run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc - - name: make check - run: make -j3 check VERBOSE=3D1 + ghrepo: aws/aws-lc + gitref: v1.70.0 + libconfigure: cmake -B build -GNinja -DCMAKE_BUILD_TYPE=3DRelease -D= CMAKE_INSTALL_PREFIX=3D"$LIBPREFIX" -DBUILD_SHARED_LIBS=3D1 + libmake: cmake --build build + libinstall: sudo cmake --install build + # not ready for --enable-werror + ovpnconfigureflags: diff --git a/.github/workflows/test-ssllib.yml b/.github/workflows/test-ssl= lib.yml new file mode 100644 index 0000000..7c6cdb7 --- /dev/null +++ b/.github/workflows/test-ssllib.yml @@ -0,0 +1,114 @@ +name: test_ssllib + +on: + workflow_call: + inputs: + libname: + required: true + type: string + ovpnlibname: + type: string + default: openssl + ovpnlibdesc: + required: true + type: string + ghrepo: + required: true + type: string + gitref: + required: true + type: string + libconfigure: + required: true + type: string + libmake: + type: string + default: "make -j3" + libinstall: + type: string + default: "sudo make install" + ovpnconfigureenv: + type: string + default: >- + OPENSSL_CFLAGS=3D"-I$LIBPREFIX/include" + OPENSSL_LIBS=3D"-L$LIBPREFIX/lib -lssl -lcrypto" + LDFLAGS=3D"-Wl,-rpath=3D$LIBPREFIX/lib" + ovpnconfigureflags: + type: string + default: --enable-werror --with-openssl-engine=3Dno + +jobs: + test_ssllib: + strategy: + fail-fast: false + matrix: + os: [ubuntu-24.04] + build: [normal, asan] + include: + - build: asan + cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fn= o-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame= -pointer -g -O1" + ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall + cc: clang + - build: normal + cflags: "-O2 -g" + ldflags: "" + cc: gcc + + name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{inputs.l= ibname}}" + runs-on: ${{matrix.os}} + env: + CFLAGS: ${{matrix.cflags}} + LDFLAGS: ${{matrix.ldflags}} + CC: ${{matrix.cc}} + UBSAN_OPTIONS: print_stacktrace=3D1 + LIBPREFIX: /opt/${{inputs.libname}} + + steps: + - name: Install dependencies + run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-d= ev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils = libtool automake autoconf pkg-config libcap-ng-dev libnl-genl-3-dev + - name: Restore ${{inputs.libname}} from cache + uses: actions/cache@...3010... + id: ssllib-cache + with: + path: ${{env.LIBPREFIX}} + key: ${{matrix.os}}-${{inputs.libname}}-${{matrix.build }}-${{in= puts.gitref}} + - name: "${{inputs.libname}}: checkout" + if: steps.ssllib-cache.outputs.cache-hit !=3D 'true' + uses: actions/checkout@...2998... # v6.0.2 + with: + submodules: recursive + path: ${{inputs.libname}} + repository: ${{inputs.ghrepo}} + ref: ${{inputs.gitref}} + - name: "${{inputs.libname}}: configure" + if: steps.ssllib-cache.outputs.cache-hit !=3D 'true' + run: ${{inputs.libconfigure}} + working-directory: ${{inputs.libname}} + - name: "${{inputs.libname}}: build" + if: steps.ssllib-cache.outputs.cache-hit !=3D 'true' + run: ${{inputs.libmake}} + working-directory: ${{inputs.libname}} + - name: "${{inputs.libname}}: install" + if: steps.ssllib-cache.outputs.cache-hit !=3D 'true' + run: ${{inputs.libinstall}} + working-directory: ${{inputs.libname}} + - name: Run ldconfig + run: sudo ldconfig + - name: "OpenVPN: checkout" + uses: actions/checkout@...2998... # v6.0.2 + - name: "OpenVPN: autoreconf" + run: autoreconf -fvi + - name: "OpenVPN: configure" + run: | + ${{inputs.ovpnconfigureenv}} \ + ./configure --with-crypto-library=3D${{inputs.ovpnlibname}} ${{i= nputs.ovpnconfigureflags}} + - name: "OpenVPN: build" + run: make -j3 + - name: Ensure the build uses ${{inputs.libname}} + run: | + ./src/openvpn/openvpn --version + ./src/openvpn/openvpn --version | grep -q "library versions: ${{= inputs.ovpnlibdesc}}" + - name: "OpenVPN: configure checks" + run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc + - name: "OpenVPN: make check" + run: make -j3 check VERBOSE=3D1 diff --git a/renovate.json b/renovate.json index f9c62c4..809ac3f 100644 --- a/renovate.json +++ b/renovate.json @@ -40,7 +40,7 @@ "/^\\.github/workflows/.+\\.ya?ml$/" ], "matchStrings": [ - "versioning=3D(?.*?)\\n\\s*.*?_REPO:\\s*(?.*?)\\n\\s*.*?_VERSION:\\s*(?.*?)\\n" + "versioning=3D(?.*?)\\n\\s*ghrepo:\\s*(?.*?)\\n\\s*gitrepo:\\s*(?.*?)\\n" ], "datasourceTemplate": "github-tags" } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1630?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3d89016ccae297cfa596897c11a518f1ffbe3dc8 Gerrit-Change-Number: 1630 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --Noas3uLx0EY= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

GHA: Factor out building SSL libs to a reus=
able workflow

We amassed a lot of code duplication there. Make
it= easier to track the differences between the libraries.

Change-Id: I= 3d89016ccae297cfa596897c11a518f1ffbe3dc8
Signed-off-by: Frank Lichtenhel= d <frank@...2641...>
---
M .github/workflows/build.yaml
A .g= ithub/workflows/test-ssllib.yml
M renovate.json
3 files changed, 152 = insertions(+), 313 deletions(-)

git pull ssh://g=
errit.openvpn.net:29418/openvpn refs/changes/30/1630/1
diff --git a=
/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 365e72a..e4cb799 100644
--- a/.github/workflows/bui= ld.yaml
+++ b/.github/workflows/build.yaml
= @@ -304,324 +304,49 @@
!${{ github.workspace }= }/out/**/vcpkg_installed/**

libressl:<= /span>
- strategy:- fail-fast: false<= br>- matrix:
- os: [ubuntu-24.04]

= - ssllib: [libressl]
- build: [ normal, as= an ]
- configure= flags: ["--with-openssl-engine=3Dno"]
- include:
- - build: asan
- cflags: "-fsanitize=3Daddress -fno-= sanitize-recover=3Dall -fno-optimize-sibling-calls -fsanitize-address-use-= after-scope -fno-omit-frame-pointer -g -O1"
- ldflags: -fsanitize=3Daddress -fno-s= anitize-recover=3Dall
-= cc: clang
-= - build: normal
- cflags: "-O2 -g"
- ldflags: ""
- cc: gcc
-
- name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}= } - ${{matrix.ssllib}}"
- runs-on: ${{matrix.os}}
- env:
-= CFLAGS: ${{ matrix.cflags }}
- LDFLAGS: ${{ matrix.ldflags }}
- CC: ${{matrix.cc}}
- UBSAN_OPTIONS: print_stacktrace=3D1
+ uses: ./.github/w= orkflows/test-ssllib.yml
+ with:
+ = libname: libressl
+ = ovpnlibdesc: LibreSSL
# versioning=3Dsemver-coe= rced
- LIBRESSL_RE= PO: libressl/portable
-= LIBRESSL_VERSION: v4.2.1
- LIBRESSL_INSTALL: /opt/libressl
+ ghrepo: libressl/portable
+ gitref: v4.2.1
+ libconfigure: "LIBRESSL_= GIT_OPTIONS=3D--no-single-branch ./autogen.sh && ./configure --pref= ix=3D$LIBPREFIX"


- steps:
- - name: Install dependencies
- run: sudo apt update && sudo apt instal= l -y liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang libc= mocka-dev python3-docutils libtool automake autoconf pkg-config libcap-ng-d= ev libnl-genl-3-dev
- = - name: Restore libressl from cache
- uses: actions/cache@...3010...
- id: libressl-cache
- with:

- path: ${{ env.LIBRESSL_INSTALL }}=
- key: ${{ ma= trix.os }}-libressl-${{matrix.build }}-${{ env.LIBRESSL_VERSION }}- - name: "libressl: = checkout"
- = if: steps.libressl-cache.outputs.cache-hit !=3D 'true'
<= span style=3D"color: hsl(0, 100%, 40%);">- uses: actions/checkout@...1186...= .2998... # v6.0.2
- = with:
- pa= th: libressl
- = repository: ${{ env.LIBRESSL_REPO }}
- ref: ${{ env.LIBRESSL_VERSION }}
- - name: "libressl: autogen.= sh"
- if: s= teps.libressl-cache.outputs.cache-hit !=3D 'true'
- env:
- LIBRESSL_GIT_OPTIONS: "--no-singl= e-branch"
- = run: ./autogen.sh
- = working-directory: libressl
- - name: "libressl: configure"
- if: steps.libressl-cache.outputs= .cache-hit !=3D 'true'
- run: ./configure --prefix=3D${{ env.LIBRESSL_INSTALL }}
- working-director= y: libressl
- - na= me: "libressl: make all"
- if: steps.libressl-cache.outputs.cache-hit !=3D 't= rue'
- run: = make -j3
- worki= ng-directory: libressl
= - - name: "libressl: make install"
- if: steps.libressl-cache.outputs.cache-= hit !=3D 'true'
- run: sudo make install
- working-directory: libressl
- - name: "ldconfig"
- run: sudo ldconfig

= - - name: Checkout OpenVPN
- uses: actions/c= heckout@...2998... # v6.0.2
- - name: autoconf
- run: autoreconf -fvi
- - name: configure
- run: |
- OPENSSL_CFLAGS=3D"-I${{ env.LIBRESSL_INSTALL }}/inc= lude" \
- = OPENSSL_LIBS=3D"-L${{ env.LIBRESSL_INSTALL }}/lib -lssl -lcrypto"= ; \
- LDFLAGS= =3D"-Wl,-rpath=3D${{ env.LIBRESSL_INSTALL }}/lib" \
- ./configure --with-crypto= -library=3Dopenssl --enable-werror ${{matrix.configureflags}}

- - name: make all
- run: make -j3
- - name: Ensure the build use= s LibreSSL
- run= : |
- ./src/op= envpn/openvpn --version
- ./src/openvpn/openvpn --version | grep -q "library version= s: LibreSSL"
- = - name: configure checks
- run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t= _server_null.rc
- = - name: make check
- = run: make -j3 check VERBOSE=3D1
-
- open= ssl:
- strategy:

- fail-fast: false
- matrix:
= - os: [ubuntu-24.04]
- ssllib: [openssl]
- build: [ normal= , asan ]
- confi= gureflags: ["--with-openssl-engine=3Dno"]
- include:
- - build: asan
- cflags: "-fsanitize=3Daddress= -fno-sanitize-recover=3Dall -fno-optimize-sibling-calls -fsanitize-addres= s-use-after-scope -fno-omit-frame-pointer -g -O1"
- ldflags: -fsanitize=3Daddress = -fno-sanitize-recover=3Dall
- cc: clang
- - build: normal
- cflags: "-O2 -g"
- ldflags: ""
- cc: gcc

-
- name: "${{matrix.cc}} ${{matrix.build}} - ${{matri= x.os}} - ${{matrix.ssllib}} - 4.0"
- runs-on: ${{matrix.os}}
- env:
- CFLAGS: ${{ matrix.cflags }}
- LDFLAGS: ${{ matrix.ldflags }}
- CC: ${{matrix.cc}}

<= span style=3D"color: hsl(0, 100%, 40%);">- UBSAN_OPTIONS: print_stackt= race=3D1

+ openssl4:=
+ uses: ./.github= /workflows/test-ssllib.yml
+ with:
+ = libname: openssl
+= ovpnlibdesc: OpenSSL 4.
# versioning=3Dsemver-= coerced
- OPENSSL_= REPO: openssl/openssl
-= OPENSSL_VERSION: openssl-4.0.0-beta1
- OPENSSL_INSTALL: /opt/openssl
-
- steps:
- run: sudo apt update && sudo apt install -y= liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang libcmock= a-dev python3-docutils libtool automake autoconf pkg-config libcap-ng-dev l= ibnl-genl-3-dev
- = - name: Restore OpenSSL 4.0 from cache
- uses: actions/cache@...3010...
- id: openssl-cache
- with:
- path: ${{ env.OPENSSL_INSTALL }}<= /span>
- key: ${{ mat= rix.os }}-openssl-${{matrix.build }}-${{ env.OPENSSL_VERSION }}
<= span style=3D"color: hsl(0, 100%, 40%);">- - name: "openssl: chec= kout"

- if:= steps.openssl-cache.outputs.cache-hit !=3D 'true'
- uses: actions/checkout@...3022...= ... # v6.0.2
- w= ith:
- path: o= penssl
- repos= itory: ${{ env.OPENSSL_REPO }}
- ref: ${{ env.OPENSSL_VERSION }}
- - name: "openssl: configure"
- if: steps.opens= sl-cache.outputs.cache-hit !=3D 'true'
- run: ./Configure --prefix=3D${{ env.OPENS= SL_INSTALL }} --libdir=3D${{ env.OPENSSL_INSTALL }}/lib --openssldir=3D${{ = env.OPENSSL_INSTALL }} -g
- working-directory: openssl
- - name: "openssl: make all"
- if: steps.openssl-cache.outp= uts.cache-hit !=3D 'true'

- run: make -j3
- working-directory: openssl
- - name: "openssl: make install"
- if: steps.openss= l-cache.outputs.cache-hit !=3D 'true'
- run: sudo make install
- working-directory: openssl<= br>- - name: "ldconfig&= quot;
- run: sud= o ldconfig
- - nam= e: Checkout OpenVPN
- = uses: actions/checkout@...2998... # v6.0.2
- - name: autoconf
- run: autoreconf -fvi
- - name: configure
- run: |
- OPENSSL_CFLAGS=3D"-I${{ env.= OPENSSL_INSTALL }}/include" \
- OPENSSL_LIBS=3D"-L${{ env.OPENSSL_INSTALL }}/li= b -lssl -lcrypto" \
- ./conf= igure --with-crypto-library=3Dopenssl --enable-werror ${{matrix.configurefl= ags}}
- - name: ma= ke all
- run: ma= ke -j3
- - name: E= nsure the build uses Openssl
- run: |
-= ./src/openvpn/openvpn --version
- ./src/openvpn/openvpn --version | grep -q &qu= ot;library versions: OpenSSL 4.0"
- - name: configure checks
- run: echo 'RUN_SUDO=3D"sudo -E&q= uot;' >tests/t_server_null.rc
- - name: make check
- run: make -j3 check VERBOSE=3D1
+ ghrepo: openssl/openssl<= br>+ gitref: openssl-4.0.0= -beta1
+ libconf= igure: ./Configure --prefix=3D$LIBPREFIX --libdir=3D$LIBPREFIX/lib --openss= ldir=3D$LIBPREFIX -g

mbedtls4:<= br>- strategy:
- fail-fast: false

- matrix:
- os: [ubuntu-24.04]
- ssllib: [mbedtls4]
<= span style=3D"color: hsl(0, 100%, 40%);">- build: [ normal, asan ]
- include:=
- - build: asan

- cflags: "= -fsanitize=3Daddress -fno-sanitize-recover=3Dall -fno-optimize-sibling-cal= ls -fsanitize-address-use-after-scope -fno-omit-frame-pointer -g -O1"<= /span>
- ldflags: -= fsanitize=3Daddress -fno-sanitize-recover=3Dall
- cc: clang
- - build: normal
- cflags: "-O2 -g"

- ldflags: "= ;"
- cc= : gcc
-
- name: "${{matrix.cc}} ${{mat= rix.build}} - ${{matrix.os}} - ${{matrix.ssllib}}"
- runs-on: ${{matrix.os}}
- env:
- CFLAGS: ${{ matrix.cflags }}
- LDFLAGS: ${{ matrix.ldflags }= }
- CC: ${{matrix.= cc}}
- UBSAN_OPTIO= NS: print_stacktrace=3D1
+ uses: ./.github/workflows/test-ssllib= .yml
+ with:

+ libname: mbedtls
+ ovpnlibname: mbe= dtls
+ ovpnlibde= sc: mbed TLS 4.
# versioning=3Dsemver-coerced=
- MBEDTLS_REPO: Mbed-TLS= /mbedtls
- MBEDTLS= _VERSION: v4.0.0
- = MBEDTLS_INSTALL: /opt/mbedtls4
-
- steps:<= /span>
- - name: Install = dependencies
- r= un: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev= liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils py= thon3-jinja2 python3-jsonschema libtool automake autoconf pkg-config libcap= -ng-dev libnl-genl-3-dev
- uses: actions/cache@...3010...
- id: mbedtls-cache
- with:
- path: ${{ env.MBEDTLS_INSTALL= }}
- key: ${{= matrix.os }}-mbedtls-${{matrix.build }}-${{ env.MBEDTLS_VERSION }}<= br>- - name: "mbedtls: = checkout"
- = if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true'
- uses: actions/checkout@...493...= 2998... # v6.0.2

- = with:
- pat= h: mbedtls
- s= ubmodules: recursive
- = repository: ${{ env.MBEDTLS_REPO }}
- ref: ${{ env.MBEDTLS_VERSION }}
= - - uses: lukka/get-cmake@...1186...= .2999... # v4.2.3
- = - name: "mbedtls: cmake"
- if: steps.mbedtls-cache.outputs.cache-hit !=3D '= true'
- run:= cmake -B build -DCMAKE_INSTALL_PREFIX=3D${{ env.MBEDTLS_INSTAL }}- working-directory: mbe= dtls
- - name: &qu= ot;mbedtls: cmake --build"
- if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true&= #39;
- run: cmak= e --build build
- = working-directory: mbedtls
- - name: "mbedtls: cmake --install"
- if: steps.mbedtls-cache.outputs= .cache-hit !=3D 'true'
- run: sudo cmake --install build
- working-directory: mbedtls
- - name: Checkout OpenVPN
- uses: actions/chec= kout@...2998... # v6.0.2
- run: autoreconf -fvi
- - name: configure
- run: ./configure --with-crypto-library=3Dmbedtls --ena= ble-werror
- - nam= e: make all
- ru= n: make -j3
- - na= me: Ensure the build uses mbed TLS ${{ env.MBEDTLS_VERSION }}
- run: |
- ./src/openvpn/openvpn --version<= /span>
- ./src/openvp= n/openvpn --version | grep -q "library versions: mbed TLS 4."

- - name: configure c= hecks
- run: ech= o 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc
- - name: make check
- run: make -j3 ch= eck VERBOSE=3D1
+ = ghrepo: Mbed-TLS/mbedtls
+ gitref: v4.0.0
+ libconfigure: cmake -B build -DCMAKE_INSTALL_PREFIX=3D$LIBPRE= FIX
+ libmake: c= make --build build
+ = libinstall: sudo cmake --install build
+ ovpnconfigureenv: PKG_CONFIG_PATH=3D$LIBPREFI= X/lib/pkgconfig

aws-lc:
- strategy:

- fail-fast: false
- matrix:
- os: [ubuntu-24.04]
- ssllib: [ awslc ]
- build: [ normal, asan ]<= br>- include:
- - build: asan

= - cflags: "-fsani= tize=3Daddress -fno-sanitize-recover=3Dall -fno-optimize-sibling-calls -fs= anitize-address-use-after-scope -fno-omit-frame-pointer -g -O1"=
- ldflags: -fsanit= ize=3Daddress -fno-sanitize-recover=3Dall
- cc: clang
- cxx: clang++
- - build: normal
- cflags: "-O2 -g"- ldflags: "&quo= t;
- cc: gcc=
- cxx: c++<= /span>
-
- name: "${{matrix.cc}} ${{matrix.bu= ild}} - ${{matrix.os}} - ${{matrix.ssllib}}"
- runs-on: ${{matrix.os}}
- env:
- CFLAGS: ${{ matrix.cflags }}
- LDFLAGS: ${{ matrix.ldflags }}
- CC: ${{matrix.cc}}
- CXX: ${{matrix.cx= x}}
- UBSAN_OPTION= S: print_stacktrace=3D1
- AWS_LC_INSTALL: /opt/aws-lc
+ uses: ./.github/workflows/test-ssllib.yml
+ with:

+ libname: aws-lc
+ ovpnlibdesc: AWS-LC
# versioning=3Dsemver-coerced

- AWS_LC_REPO: aws/aws-lc
- AWS_LC_VERSION: v1.70.0
-
- steps:
- - name: Install dependencies
- run: sudo apt update && sudo apt install -y = gcc golang make liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html= clang libcmocka-dev python3-docutils python3-jinja2 python3-jsonschema lib= tool automake autoconf pkg-config libcap-ng-dev libnl-genl-3-dev
= - - name: Restore AWS-LC fro= m cache
- uses: = actions/cache@...3010...
- with:
- = path: ${{ env.AWS_LC_INSTALL }}
- key: ${{ matrix.os }}-aws-lc-${{matrix.build }}= -${{ env.AWS_LC_VERSION }}
- - name: "AWS-LC: checkout"
- if: steps.aws-lc-cache.outputs.cache-hit = !=3D 'true'
- = uses: actions/checkout@...2998... # v6.0.2
- with:
- path: aws-lc
- repository: ${{ env.AWS_LC_REPO }}
= - ref: ${{ env.AWS_LC_VE= RSION }}
- - uses:= lukka/get-cmake@...2999... # v4.2.3
- - name: "AWS-LC: build"
- if: steps.aws-lc-cache.outputs.cac= he-hit !=3D 'true'
- run: |
- = mkdir build
- = cd build
- = cmake -GNinja -DCMAKE_BUILD_TYPE=3DRelease -DCMAKE_INSTALL_PREFIX=3D&q= uot;${{ env.AWS_LC_INSTALL }}" -DBUILD_SHARED_LIBS=3D1 ../
<= span style=3D"color: hsl(0, 100%, 40%);">- ninja install
- working-directory: aws-= lc
- - name: Check= out OpenVPN
- us= es: actions/checkout@...2998... # v6.0.2
- - name: autoconf
- run: autoreconf -fvi
- - name: configure with AWS-LC
- run: |
- OPENSSL_CFLAGS=3D"-I${{ en= v.AWS_LC_INSTALL }}/include" \
- OPENSSL_LIBS=3D"-L${{ env.AWS_LC_INSTALL }}/li= b -lssl -lcrypto" \
- ./confi= gure --with-crypto-library=3Dopenssl
- - name: make all
- run: make -j3
- - name: Ensure the build uses AWS-LC
- run: |
- ./src/openvpn/openvpn --version
- ./src/openvpn= /openvpn --version | grep -q "library versions: AWS-LC"- - name: configure checks<= /span>
- run: echo '= ;RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc
<= span style=3D"color: hsl(0, 100%, 40%);">- - name: make check
- run: make -j3 check VE= RBOSE=3D1
+ ghre= po: aws/aws-lc
+ = gitref: v1.70.0
+ = libconfigure: cmake -B build -GNinja -DCMAKE_BUILD_TYPE=3DRelease -DCMAK= E_INSTALL_PREFIX=3D"$LIBPREFIX" -DBUILD_SHARED_LIBS=3D1+ libmake: cmake --build = build
+ libinsta= ll: sudo cmake --install build
+ # not ready for --enable-werror
+ ovpnconfigureflags:
diff= --git a/.github/workflows/test-ssllib.yml b/.github/workflows/test-ssllib.= yml
new file mode 100644
index 0000000..7c6= cdb7
--- /dev/null
+++ b/.github/workflows/= test-ssllib.yml
@@ -0,0 +1,114 @@
+name: test_ssllib
+
+on:
+ workf= low_call:
+ inputs= :
+ libname:

+ required: true<= /span>
+ type: string=
+ ovpnlibname:<= /span>
+ type: string=
+ default: op= enssl
+ ovpnlibd= esc:
+ require= d: true
+ type= : string
+ ghrep= o:
+ required:= true
+ type: = string
+ gitref:=
+ required: t= rue
+ type: st= ring
+ libconfig= ure:
+ require= d: true
+ type= : string
+ libma= ke:
+ type: st= ring
+ default= : "make -j3"
= + type: string
+ default: "sudo make install"
+ ovpnconfigureenv:
+ type: string
+ default: >-
+ OPENSSL_CFLAGS=3D"-I$L= IBPREFIX/include"
+ LDFLAGS=3D&qu= ot;-Wl,-rpath=3D$LIBPREFIX/lib"
+ ovpnconfigureflags:
+ type: string
+ default: --enable-werror --with-openssl-eng= ine=3Dno
+
= +jobs:
+ test_ssllib:
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ubuntu-24.04]
+ build: [normal, asan]
+ include:
+ - build: asan
+ cflags: "-fsanitize=3Da= ddress -fno-sanitize-recover=3Dall -fno-optimize-sibling-calls -fsanitize-= address-use-after-scope -fno-omit-frame-pointer -g -O1"
+ ldflags: -fsanitize=3D= address -fno-sanitize-recover=3Dall

+ cc: clang
+ - build: normal
+ cflags: "-O2 -g"
+ ldflags: ""= ;

+ cc: gc= c
+
+ name: "${{matrix.cc}} ${{mat= rix.build}} - ${{matrix.os}} - ${{inputs.libname}}"
+ runs-on: ${{matrix.os}}
= + env:
+ CFLAGS: ${{matrix.cflags}}+ LDFLAGS: ${{matrix.ldf= lags}}
+ CC: ${{= matrix.cc}}
+ UB= SAN_OPTIONS: print_stacktrace=3D1
+ LIBPREFIX: /opt/${{inputs.libname}}
+
+ steps:
+ - name: Install dependencies
+ run: sudo apt update && sudo apt ins= tall -y liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang l= ibcmocka-dev python3-docutils libtool automake autoconf pkg-config libcap-n= g-dev libnl-genl-3-dev
+ uses: actions/cache@...3010...<= /span>
+ id: ssllib-c= ache
+ with:
+ path: ${{en= v.LIBPREFIX}}
+ = key: ${{matrix.os}}-${{inputs.libname}}-${{matrix.build }}-${{inputs.gi= tref}}
+ - name:= "${{inputs.libname}}: checkout"
+ if: steps.ssllib-cache.outputs.cache-hit != =3D 'true'
+ = uses: actions/checkout@...2998... # v6.0.2
+ with:
+ submodules: recursive
+ path: ${{inputs.libname}}
+ repository: $= {{inputs.ghrepo}}
+ = ref: ${{inputs.gitref}}
+ - name: "${{inputs.libname}}: configure"=
+ if: steps.ssllib-c= ache.outputs.cache-hit !=3D 'true'
+ run: ${{inputs.libconfigure}}
+ working-directory: ${{inpu= ts.libname}}

+ -= name: "${{inputs.libname}}: build"
+ if: steps.ssllib-cache.outputs.cache-hit = !=3D 'true'
+= run: ${{inputs.libmake}}
+ working-directory: ${{inputs.libname}}
+ - name: "${{inputs.libna= me}}: install"

+= if: steps.ssllib-cache.outputs.cache-hit !=3D 'true'=
+ run: ${{inputs.lib= install}}
+ wo= rking-directory: ${{inputs.libname}}
+ - name: Run ldconfig
+ run: sudo ldconfig
+ - name: "OpenVPN: checkout"<= /span>
+ uses: action= s/checkout@...2998... # v6.0.2
+ - name: "OpenVPN: autoreconf"
+ run: autoreconf -fvi+ - name: "OpenVPN: = configure"
+ = run: |
+ = ${{inputs.ovpnconfigureenv}} \
+ ./configure --with-crypto-library=3D${{inputs.ovpnlib= name}} ${{inputs.ovpnconfigureflags}}
+ - name: "OpenVPN: build"
+ run: make -j3
+ - name: Ensure the build use= s ${{inputs.libname}}

+ run: |
+ = ./src/openvpn/openvpn --version
+ ./src/openvpn/openvpn --version | grep -q &quo= t;library versions: ${{inputs.ovpnlibdesc}}"
+ - name: "OpenVPN: configure checks= "
+ run: = echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc
+ - name: "Op= enVPN: make check"
+ run: make -j3 check VERBOSE=3D1
diff --git a/re= novate.json b/renovate.json
index f9c62c4..809ac3f 100644
--- a/renovate.json
+++ b/renovate.json
@@ -40,7 +40,7 @@
"/^\\.g= ithub/workflows/.+\\.ya?ml$/"
], "matchStrings": [
- "versioning=3D(?<version= ing>.*?)\\n\\s*.*?_REPO:\\s*(?<depName>.*?)\\n\\s*.*?_VERSION:\\s*= (?<currentValue>.*?)\\n"
+ "versioning=3D(?<versioning>.*?)= \\n\\s*ghrepo:\\s*(?<depName>.*?)\\n\\s*gitrepo:\\s*(?<currentValu= e>.*?)\\n"
],
= "datasourceTemplate": "github-tags"
}


To view, visit change 1630. To= unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3d89016ccae297cfa596897c11a= 518f1ffbe3dc8
Gerrit-Change-Number: 1630
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --Noas3uLx0EY=--