From: "flichtenheld (Code Review)"
Date: Wed, 9 Jul 2025 10:08:40 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227..., heiko@...515...,
openvpn-devel@lists.sourceforge.net
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="DRws49qh9wg="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: mac dns: compare
servers before restoring backup
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: d12fk
Cc: plaisthos , openvpn-devel
--DRws49qh9wg=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: d12fk, plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/1075?usp=3Demail )
Change subject: mac dns: compare servers before restoring backup
......................................................................
Patch Set 2: Code-Review-2
(1 comment)
Patchset:
PS2:
> Could you please also post the output of `show State:/Network/Service/034=
7C55F-C172-49FF-BECC-C533F0 [=E2=80=A6]
Before running the test:
```
> show State:/Network/Service/0347C55F-C172-49FF-BECC-C533F04B4B13/DNS
{
DomainName : flow.local
ServerAddresses : {
0 : 172.31.32.1
}
}
> show State:/Network/Global/DNS
{
SearchDomains : {
0 : flow.local
}
ServerAddresses : {
0 : 10.8.144.10
1 : 10.8.160.10
2 : 172.31.32.1
}
__CONFIGURATION_ID__ : Default: 0
__FLAGS__ : 2
__ORDER__ : 0
}
> show Setup:/Network/Service/0347C55F-C172-49FF-BECC-C533F04B4B13/DNS
{
ServerAddresses : {
0 : 10.8.144.10
1 : 10.8.160.10
2 : 172.31.32.1
}
}
```
After running the test:
```
> show State:/Network/Service/0347C55F-C172-49FF-BECC-C533F04B4B13/DNS
{
DomainName : flow.local
ServerAddresses : {
0 : 172.31.32.1
}
}
> show State:/Network/Global/DNS
{
SearchDomains : {
0 : open.vpn
}
SearchOrder : 5000
ServerAddresses : {
0 : 10.194.0.1
}
__CONFIGURATION_ID__ : Default: 0
__FLAGS__ : 2
__ORDER__ : 0
}
> show Setup:/Network/Service/0347C55F-C172-49FF-BECC-C533F04B4B13/DNS
{
SearchDomains : {
0 : open.vpn
}
SearchOrder : 5000
ServerAddresses : {
0 : 10.194.0.1
1 : fd00:abcd:194::1
}
}
```
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1075?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1aabd62e60dd18408a57baccbb0f4ebd6d2f8d67
Gerrit-Change-Number: 1075
Gerrit-PatchSet: 2
Gerrit-Owner: d12fk
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: d12fk
Gerrit-Comment-Date: Wed, 09 Jul 2025 10:08:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: flichtenheld
Comment-In-Reply-To: d12fk
Gerrit-MessageType: comment
--DRws49qh9wg=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: d12fk, plaisthos.
Patch set 2:Code-Review -2=
V=
iew Change
1 comment:
Patchset:
Patch Set #2:
Could you please=
also post the output of `show State:/Network/Service/0347C55F-C172-49FF-BE=
CC-C533F0 [=E2=80=A6]
Before running the test:
```
> show State:/Netw=
ork/Service/0347C55F-C172-49FF-BECC-C533F04B4B13/DNS
<dictionary> =
{
DomainName : flow.local
ServerAddresses : <array> {
=
0 : 172.31.32.1
}
}
> show State:/Network/Global/DNS
<=
;dictionary> {
SearchDomains : <array> {
0 : flow.loca=
l
}
ServerAddresses : <array> {
0 : 10.8.144.10
=
1 : 10.8.160.10
2 : 172.31.32.1
}
__CONFIGURATION_ID__ =
: Default: 0
__FLAGS__ : 2
__ORDER__ : 0
}
> show Setup:=
/Network/Service/0347C55F-C172-49FF-BECC-C533F04B4B13/DNS
<dictionary=
> {
ServerAddresses : <array> {
0 : 10.8.144.10
=
1 : 10.8.160.10
2 : 172.31.32.1
}
}
```
After running the test:
=
```=
> show State:/Network/Service/0347C55F-C172-49FF-BECC-C533F04B4B13/D=
NS
<dictionary> {
DomainName : flow.local
ServerAddresse=
s : <array> {
0 : 172.31.32.1
}
}
> show State:/=
Network/Global/DNS
<dictionary> {
SearchDomains : <array&g=
t; {
0 : open.vpn
}
SearchOrder : 5000
ServerAddresse=
s : <array> {
0 : 10.194.0.1
}
__CONFIGURATION_ID__ =
: Default: 0
__FLAGS__ : 2
__ORDER__ : 0
}
> show Setup:=
/Network/Service/0347C55F-C172-49FF-BECC-C533F04B4B13/DNS
<dictionary=
> {
SearchDomains : <array> {
0 : open.vpn
}
=
SearchOrder : 5000
ServerAddresses : <array> {
0 : 10.19=
4.0.1
1 : fd00:abcd:194::1
}
}
```
=
ul>To view, visit change 1075. To unsubscribe, or for help writing mail filt=
ers, visit settings.
=
<=
meta itemprop=3D"name" content=3D"View Change"/>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1aabd62e60dd18408a57baccbb0=
f4ebd6d2f8d67
Gerrit-Change-Number: 1075
Gerrit-PatchSet: 2
Gerrit-Owner: d12fk <heiko@...515...> =
div>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: d12fk <heiko@...515...>=
;
Gerrit-Comment-Date: Wed, 09 Jul 2025 10:08:40=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Comment-In-Reply-To: d12fk <heiko@...515...=
>
Gerrit-MessageType: comment
--DRws49qh9wg=--