From: "cron2 (Code Review)" Date: Wed, 9 Jul 2025 07:46:38 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., heiko@...515..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="PQk+VNeLQKM="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: dns: do not run updown scripts with lwipovpn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: d12fk , plaisthos , flichtenheld Cc: openvpn-devel --PQk+VNeLQKM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#3) to the change originally created by= d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1077?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: dns: do not run updown scripts with lwipovpn ...................................................................... dns: do not run updown scripts with lwipovpn Running the script doesn't make sense with the AFUNIX dev node, so we simply clear any scripts that have been set before. Change-Id: I7e9a0c668e0950257632452cfd9eeb236f0120f2 Signed-off-by: Heiko Hund Acked-by: Arne Schwabe Message-Id: <20250708185210.30421-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 069.html Signed-off-by: Gert Doering --- M src/openvpn/options.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/77/1077/3 diff --git a/src/openvpn/options.c b/src/openvpn/options.c index af097f8..0662b49 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -61,6 +61,7 @@ #include "xkey_common.h" #include "dco.h" #include "options_util.h" +#include "tun_afunix.h" #include @@ -3593,6 +3594,13 @@ struct gc_arena gc =3D gc_new(); struct dns_options *dns =3D &o->dns_options; + if (is_tun_afunix(o->dev_node)) + { + /* Disable running dns-updown script with lwipovpn */ + dns->updown_flags =3D DNS_UPDOWN_NO_FLAGS; + dns->updown =3D NULL; + } + if (dns->servers || dns_updown_user_set(dns) || dns_updown_forced(dns)) { /* Clean up env from --dhcp-option DNS config */ -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1077?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7e9a0c668e0950257632452cfd9eeb236f0120f2 Gerrit-Change-Number: 1077 Gerrit-PatchSet: 3 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --PQk+VNeLQKM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #3 to the change originally cr= eated by d12fk.

View Change

The following approvals got outdated an= d were removed: Code-Review+2 by plaisthos

dns: do not run updown scripts with lwipovpn
=
Running the script doesn't make sense with the AFUNIX dev node, so = we
simply clear any scripts that have been set before.

Change-Id:= I7e9a0c668e0950257632452cfd9eeb236f0120f2
Signed-off-by: Heiko Hund <= ;heiko@...2662...>
Acked-by: Arne Schwabe <arne-openvpn@...1227...= >
Message-Id: <20250708185210.30421-1-gert@...1296...>
URL: = https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32069.h= tml
Signed-off-by: Gert Doering <gert@...1296...>
---
M src/= openvpn/options.c
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/77/1077/3<=
/pre>
+#include &q=
uot;tun_afunix.h"

#include <ctyp= e.h>

@@ -3593,6 +3594,13 @@
= struct gc_arena gc =3D gc_new();
struct dns= _options *dns =3D &o->dns_options;

+ if (is_tun_afunix(o->dev_nod= e))
+ {
= + /* Disable running dn= s-updown script with lwipovpn */
+ dns->updown_flags =3D DNS_UPDOWN_NO_FLAGS;+ dns->updown =3D N= ULL;
+ }+
if (dns= ->servers || dns_updown_user_set(dns) || dns_updown_forced(dns))<= br> {
/* Clean up env from --dhcp-option= DNS config */

To view, visit change 1077= . To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7e9a0c668e0950257632452cfd9= eeb236f0120f2
Gerrit-Change-Number: 1077
Gerrit-PatchSet: 3
Gerrit-Owner: d12fk <heiko@...515...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--PQk+VNeLQKM=--