Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=yugang.chen@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49dW5j1xFCzDqmY for ; Fri, 5 Jun 2020 15:14:00 +1000 (AEST) IronPort-SDR: qo1BQOrC1smLtgyJfjN3wnDoGwVl9MAkaSCs5Trnb2fNCIbcKN/tetCM5z+Kj4HY4bTwXyLVdb OKWUOHsegA7Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2020 22:13:57 -0700 IronPort-SDR: tftyY8f2oGEG3RhCuawUqqmGYreLJBIWvZ7okY39FNDLpsuj4gvsVC5cZJJVdbyCpN2X1vqsO6 OAeH4LJnODcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,475,1583222400"; d="scan'208";a="258584183" Received: from yugangch-mobl.ccr.corp.intel.com (HELO [10.238.4.37]) ([10.238.4.37]) by orsmga007.jf.intel.com with ESMTP; 04 Jun 2020 22:13:53 -0700 Subject: Re: add Node as /redfish/v1/Systems/Node/ for multi-node system To: Deepak Kodihalli , James Feist , "openbmc@lists.ozlabs.org" , "Leung, John" , jason.m.bills@linux.intel.com, chunhui.jia@linux.intel.com, gmills@us.ibm.com Cc: Brad Bishop References: From: "yugang.chen" Message-ID: Date: Fri, 5 Jun 2020 13:13:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2020 05:14:01 -0000 Deepak,  It looks something like that. Is it possible to loop us in while you post something on Gerrit? thanks. On 6/4/2020 4:14 PM, Deepak Kodihalli wrote: > On 04/06/20 1:08 pm, yugang.chen wrote: >> Dear Deepak, >> >> I'm openbmc engineer working for redfish' slave log in multiple >> systems, we want to add slave node's log to redfish,  is there some >> design or documentation for systems schema based on associations to >> different systems interface? if so, we can work based on that common >> interface for slave logs on redfish, thanks. > > This is something I'm still working on (and should be able to post > something on Gerrit in a few days). Just so that we're on the same > page - the problem I am trying to solve is a D-Bus model based > approach to depict multiple systems and the parts contained within > (the parts could be physical containment as well as logical things > like logs). This would prevent writing code that assumes specific > names in the D-Bus path hierarchy. Daniel/James - does this help the > problem you are trying to solve? > >> Best Regards >> >> Yugang(Daniel) Chen >> >> >> On 6/3/2020 12:40 AM, James Feist wrote: >>> On 6/1/2020 11:39 PM, yugang.chen wrote: >>>> Dear All, >>>> >>>> May I have your attention? For a multi-node system,  there is an >>>> option for master to use name "Node" as ​{ComputerSystemId} to >>>> stand for slave node, to show slave node's event log in master >>>> redfish, >>>> >>>> Could you please share your comment/idea for naming ("Node")? >>>> thanks. >>> >>> Has there been any design docs for multiple systems in Redfish? This >>> is much bigger than just adding support for multiple logs, this is >>> adding support for multiple Systems interfaces, and many things need >>> to be considered such as the mapping of multiple CPUs, Memory, logs, >>> and how this fits into the inventory picture. On IRC a while back we >>> had discussed making the systems schema based on associations to >>> different systems interfaces, and I believe a design was going to be >>> written on this topic by Deepak. The name should probably come from >>> the Systems interfaces that are provided. I'm not sure why we would >>> need to hardcode these. How these interfaces get created, and what >>> they map to, needs to be discussed. >>> >>> >>>> >>>> here is the patch for code review: >>>> https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/32971 ; >>>> >>>> for example, Node1: >>>> >>>> /​redfish/​v1/​Systems/​{ComputerSystemId}/​LogServices/​ >>>> {LogServiceId}/ ​Entries/​{LogEntryId} --> >>>> /​redfish/​v1/​Systems/​Node1/​LogServices/​{LogServiceId}/​Entries/​ >>>> {LogEntryId} >>>> >>>> Best Regards >>>> >>>> Daniel(Yugang) >>>> >