Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE92AC433E0 for ; Wed, 12 Aug 2020 07:05:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A33922053B for ; Wed, 12 Aug 2020 07:05:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="FayKKNJP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A33922053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6939A6E8B9; Wed, 12 Aug 2020 07:05:35 +0000 (UTC) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id E683F6E850 for ; Tue, 11 Aug 2020 21:21:26 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 11 Aug 2020 14:21:13 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 11 Aug 2020 14:21:26 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 11 Aug 2020 14:21:26 -0700 Received: from [172.20.40.66] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 11 Aug 2020 21:21:25 +0000 Subject: Re: [PATCH v3] platform/x86: Add new vga-switcheroo gmux driver for ACPI-driven muxes To: Lukas Wunner References: <0850ac9a-3d60-053d-1d70-5f20ce621b24@nvidia.com> <20200729210557.9195-1-ddadap@nvidia.com> <20200810083757.2jbwebbvocqe5rle@wunner.de> <20200811034301.nlhue4xgfv4p3utr@wunner.de> From: Daniel Dadap Message-ID: Date: Tue, 11 Aug 2020 16:22:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200811034301.nlhue4xgfv4p3utr@wunner.de> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1597180873; bh=R2i9R+envwB1tq+uKoKa3kcK4HJWK1Npmh4i7DeM6e0=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=FayKKNJP9hXS6Z8PTFlWtbm0Fs7Hm30fTZ9PmJNRroiWPH7fdMpF5pScO0iL2+j4y z0Gbe9MCB9/krKw7/A++bd9F8KfvECzA3L0hiCFU2CuuXf58b7zif96wrxh0VhxWF/ FyX7+76b2pNcO7lgSdLeUniKcg1fepGlcgWFA8fdCygvLV9qe8aLeS9o5ZL/YnGaCU 2nqEYjF8yFQm0fvFilXE8wQSyRwSXRyOvoEAWrWB2XFuy0ULEsu4+Y+JVYm+7j+7zf wpXmJscyulFPYo9SuXq4fmshuPeT0WiQCc6e6umTFNA/d9ub6aC3XJxpjr6iPbMQgC aolV9yVO6l+tg== X-Mailman-Approved-At: Wed, 12 Aug 2020 07:05:21 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, pobrn@protonmail.com, peter@lekensteyn.nl, dvhart@infradead.org, andy@infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 8/10/20 10:43 PM, Lukas Wunner wrote: > On Mon, Aug 10, 2020 at 01:44:58PM -0500, Daniel Dadap wrote: > >> Would it be clearer to write it out as something like 0 << 4 & 1 << 0 for >> MUX_STATE_SET_IGPU and 1 << 4 & 1 << 0 for MUX_STATE_SET_DGPU? > BIT(4) | BIT(0) might be clearer, but that gives you an unsigned long > and I'm not sure if gcc accepts that as an enum (=int) initializer. Ah yes, I forgot the BIT() macro. And it does seem to work just fine for initializing enum values, and there does seem to be precedent in other code in the kernel for doing so. And of course I meant | instead of & earlier. :) _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel