Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F404C10F27 for ; Mon, 9 Mar 2020 14:04:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2305A20848 for ; Mon, 9 Mar 2020 14:04:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=candelatech.com header.i=@candelatech.com header.b="hr5F0z08" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726676AbgCIOEj (ORCPT ); Mon, 9 Mar 2020 10:04:39 -0400 Received: from mail2.candelatech.com ([208.74.158.173]:49234 "EHLO mail3.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726275AbgCIOEj (ORCPT ); Mon, 9 Mar 2020 10:04:39 -0400 Received: from [192.168.254.4] (unknown [50.34.210.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id EE61313C344; Mon, 9 Mar 2020 07:04:37 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com EE61313C344 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1583762678; bh=Le98ODmUxh2hQ4bGpJJt0SPEeLoeZXUn0R03xpgLpuk=; h=Subject:To:References:From:Date:In-Reply-To:From; b=hr5F0z0829W8DAc93zBp77V+9ArdSm/Uw4EO6VKbwZObRzMz+xUQJdTK+rFQFXyUs U4zr4nix5vG/RVZkQfd6dOuW6pYQfb745qLCPly6aFqhVABDaUtCGDAUeIAEa2HYCR 6N5UGO4EhqGzgyxsSYXDfQ5AEbSWrH8EymIUYXew= Subject: Re: [PATCH] ip link: Prevent duplication of table id for vrf tables To: David Ahern , Donald Sharp , netdev@vger.kernel.org, dsahern@kernel.org, roopa@cumulusnetworks.com, sworley@cumulusnetworks.com References: <20200307205916.15646-1-sharpd@cumulusnetworks.com> From: Ben Greear Message-ID: Date: Mon, 9 Mar 2020 07:04:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/08/2020 07:22 PM, David Ahern wrote: > On 3/7/20 1:59 PM, Donald Sharp wrote: >> Creation of different vrf's with duplicate table id's creates >> a situation where two different routing entities believe >> they have exclusive access to a particular table. This >> leads to situations where different routing processes >> clash for control of a route due to inadvertent table >> id overlap. Prevent end user from making this mistake >> on accident. > > I get the pain, but it is a user management problem and ip is but one > tool. I think at most ip warns the user about the table duplication; it > can't fail the create. You could default 'ip' to use the safe mode, and allow a --force option if there is some reason why it should be allowed? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com