Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B304C388F7 for ; Wed, 28 Oct 2020 13:25:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C42AD2474A for ; Wed, 28 Oct 2020 13:25:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hHKY9hGD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C42AD2474A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXlRj-0008SB-LV for qemu-devel@archiver.kernel.org; Wed, 28 Oct 2020 09:24:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXlQa-0007Vd-Fe for qemu-devel@nongnu.org; Wed, 28 Oct 2020 09:23:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kXlQX-0007gF-Jc for qemu-devel@nongnu.org; Wed, 28 Oct 2020 09:23:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603891424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AjU+Z1t1z9OvCaEm7HkPNbfZvyd9kI9jwGKE3wiWDKM=; b=hHKY9hGDSyU5juh+D1mneCNCbJP4yO4JrX1hecd30BlJg6zmNyIJeHleHNlU44M9KK0xJA xoBm1JuLHZAhf+AZXGs9Zl6gTSiolHPvbQZNIC95RRBgBWJxUB+5z5Z0l0WTOYmslyiDcE oi1Hpr4OXPHas9OV/vVMt29mO5PKYDA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-499-k22oHER8NpKu_NMfvnpJdA-1; Wed, 28 Oct 2020 09:23:39 -0400 X-MC-Unique: k22oHER8NpKu_NMfvnpJdA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6926B1030986; Wed, 28 Oct 2020 13:23:38 +0000 (UTC) Received: from [10.10.118.238] (ovpn-118-238.rdu2.redhat.com [10.10.118.238]) by smtp.corp.redhat.com (Postfix) with ESMTP id 40B3719C4F; Wed, 28 Oct 2020 13:23:33 +0000 (UTC) Subject: Re: [PATCH 1/5] python: add pytest and tests To: Thomas Huth , qemu-devel@nongnu.org References: <20201027223815.159802-1-jsnow@redhat.com> <20201027223815.159802-2-jsnow@redhat.com> <7440abdc-b01e-ba5e-5238-a6e4573f88b5@redhat.com> From: John Snow Message-ID: Date: Wed, 28 Oct 2020 09:23:32 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <7440abdc-b01e-ba5e-5238-a6e4573f88b5@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 01:50:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.921, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= , Eduardo Habkost , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Markus Armbruster , Wainer dos Santos Moschetta , Cleber Rosa , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/28/20 2:19 AM, Thomas Huth wrote: > On 27/10/2020 23.38, John Snow wrote: >> Try using pytest to manage our various tests; even though right now >> they're only invoking binaries and not really running any python-native >> code. >> >> Create tests/, and add test_lint.py which calls out to mypy, flake8, >> pylint and isort to enforce the standards in this directory. >> >> Add pytest to the setup.cfg development dependencies; add a pytest >> configuration section as well; run it in verbose mode. >> >> Finally, add pytest to the Pipfile environment and lock the new >> dependencies. (Note, this also updates an unrelated dependency; but the >> only way to avoid this is to pin that dependency at a lower version -- >> which there is no reason to do at present.) >> >> Provided you have the right development dependencies (mypy, flake8, >> isort, pylint, and now pytest) You should be able to run "pytest" from >> the python folder to run all of these linters with the correct >> arguments. >> >> Signed-off-by: John Snow >> --- >> python/Pipfile.lock | 71 ++++++++++++++++++++++++++++++++++++--- >> python/setup.cfg | 5 +++ >> python/tests/test_lint.py | 28 +++++++++++++++ >> 3 files changed, 99 insertions(+), 5 deletions(-) >> create mode 100644 python/tests/test_lint.py >> >> diff --git a/python/Pipfile.lock b/python/Pipfile.lock >> index 05077475d750..105ffbc09a8e 100644 >> --- a/python/Pipfile.lock >> +++ b/python/Pipfile.lock >> @@ -30,6 +30,14 @@ >> "markers": "python_version >= '3.5'", >> "version": "==2.4.2" >> }, >> + "attrs": { >> + "hashes": [ >> + "sha256:26b54ddbbb9ee1d34d5d3668dd37d6cf74990ab23c828c2888dccdceee395594", >> + "sha256:fce7fc47dfc976152e82d53ff92fa0407700c21acd20886a13777a0d20e655dc" >> + ], >> + "markers": "python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3'", > > Can't you simply use "python_version >= '3.6'" instead? > > Thomas > This file is generated; I don't really actually know what these markers mean or to whom. I can't edit it because it's checksummed. --js