Return-Path: Subject: Re: [PATCH 9/9] nvme: add support for streams and directives To: "Martin K. Petersen" , Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, adilger@dilger.ca, linux-nvme@lists.infradead.org References: <1498004526-4543-1-git-send-email-axboe@kernel.dk> <1498004526-4543-10-git-send-email-axboe@kernel.dk> <20170626095907.GG14057@infradead.org> From: Jens Axboe Message-ID: Date: Mon, 26 Jun 2017 12:00:41 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 List-ID: On 06/26/2017 11:52 AM, Martin K. Petersen wrote: > > Christoph, > >> - can we keep a module option to disable streams, or in fact for >> now maybe to explicitly enable it? I expect this to be interesting >> at least for the first devices that implement it. Also given that >> it needs to be explicitly enabled I would expect some overhead of >> just enabling it when never used > > Yeah, based on my experiments we'll need to drive this as an opt-in > feature for now. Short term the module option is OK. Once more devices > start materializing we probably need a white/blacklist/quirk scheme. Completely agree. Might even need quirks for stream allocations too, for instance. But let's hope we can keep it clean. -- Jens Axboe