Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52A34C433E0 for ; Fri, 29 May 2020 10:07:53 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C8202074D for ; Fri, 29 May 2020 10:07:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C8202074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jebvJ-0005s1-Un; Fri, 29 May 2020 10:07:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jebvI-0005rr-Nk for xen-devel@lists.xenproject.org; Fri, 29 May 2020 10:07:32 +0000 X-Inumbo-ID: 35add962-a194-11ea-81bc-bc764e2007e4 Received: from ppsw-31.csi.cam.ac.uk (unknown [131.111.8.131]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 35add962-a194-11ea-81bc-bc764e2007e4; Fri, 29 May 2020 10:07:32 +0000 (UTC) X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: http://help.uis.cam.ac.uk/email-scanner-virus Received: from 88-109-182-220.dynamic.dsl.as9105.com ([88.109.182.220]:51378 helo=[192.168.1.219]) by ppsw-31.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.157]:465) with esmtpsa (PLAIN:amc96) (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) id 1jebv9-000oOY-Jb (Exim 4.92.3) (return-path ); Fri, 29 May 2020 11:07:23 +0100 Subject: Re: [PATCH] xsm: also panic upon "flask=enforcing" when XSM_FLASK=n To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <8a4c4486-cf27-66a0-5ff9-5329277deccf@suse.com> From: Andrew Cooper Message-ID: Date: Fri, 29 May 2020 11:07:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <8a4c4486-cf27-66a0-5ff9-5329277deccf@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Paul Durrant , George Dunlap , Ian Jackson , Daniel de Graaf Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 29/05/2020 10:34, Jan Beulich wrote: > While the behavior to ignore this option without FLASK support was > properly documented, it is still somewhat surprising to someone using > this option and then still _not_ getting the assumed security. Add a > 2nd handler for the command line option for the XSM_FLASK=n case, and > invoke panic() when the option is specified (and not subsequently > overridden by "flask=disabled"). > > Suggested-by: Ian Jackson > Signed-off-by: Jan Beulich I'm very tempted to nack this outright, lest I remind both of you of the total disaster that was XSA-9, and the subsequent retraction of the code which did exactly this. If you want to do something like this, prohibit creating guests so the administrator can still log in and unbreak, instead of having it entering a reboot loop with no output.  The console isn't established this early, so none of this text makes it out onto VGA/serial. ~Andrew