Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 941E0C43381 for ; Sun, 31 Mar 2019 14:59:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61CEF2086C for ; Sun, 31 Mar 2019 14:59:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aMcP0P3B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731259AbfCaO7p (ORCPT ); Sun, 31 Mar 2019 10:59:45 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:53166 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731240AbfCaO7o (ORCPT ); Sun, 31 Mar 2019 10:59:44 -0400 Received: by mail-wm1-f67.google.com with SMTP id a184so7520564wma.2 for ; Sun, 31 Mar 2019 07:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=soDkRc2e7Sf3P/QbO1M/jSFbHxFNW61RwlAlFVGwTGs=; b=aMcP0P3BQwUWkeGrwSkndowO3hnnmPuOp6QnbX9HYAVd31jNH33auXLWlrl/luGvri LtQqYmX29B1w4WhlKVJBmW7LofkBneapfhkl9bn0nFkAlSQO9+dt8ObD2ro9gnEqjcRQ rGbWlpaBjhHt/LImT5wft1suBJK6UY1mWfBvodT5vsxJOVI9jpTA6uj5Gc8/cYv5cnJm pihnEVPApaAIaE6TthaLF1nYm3U/4CBcnBYM3ENL/qateSrGPPS8KOKZk9U6XAv5r0++ ZsN97k/prtmVzu0ij+zcNLvOVgtn62QPFh/S+m784qSINyQCoyMQshPBukwJAXckOz5H gXJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=soDkRc2e7Sf3P/QbO1M/jSFbHxFNW61RwlAlFVGwTGs=; b=fqRVdn3PvFh3zZSTQq3O3PkrMCzQ6Ar6QX00pANAuUFgD64xq5fcw/NHxCXvF4k8J5 99+UzbyUWNaDVPxnHqjZmndeAyBAUO8mlJ85h+g4E2XpgZ7r0jce6g16s4BaDoxW+Dx+ 4PcDUvtpB27fkYaBRSx8cF9+hpPXsYjsYYk+e9RwkOAuJYI8kwMd7aR53eTVZfjV7D09 sM9YnXeGSsQe5nkcpFaogJl5eSHkYDXwIzCmPP5hNKG/Xy8gRWDgM/+yOo+InC9T8pk+ DfZA4EQgLro9OWyFT3KTEY6ZHHFLacCQMvje+A8tlCcclD7vnLjFxP+g5UmSlpdHrrt0 NkFg== X-Gm-Message-State: APjAAAUoJWNPQHbC6dfqCLQ6E2ZewiM+MW3fN8hpwsJ6AGoJsWOkiA1U gK+/RUUsHvdESMHQaGa7DkA/nGD2 X-Google-Smtp-Source: APXvYqwnDdBgHB3Dx3Bfi/sxVVQSFbXAC21dt0k/4PfsgTpZNjB+lFQhkq7Efpja9Tik+rNGaPQgMg== X-Received: by 2002:a1c:e904:: with SMTP id q4mr1381348wmc.43.1554044383151; Sun, 31 Mar 2019 07:59:43 -0700 (PDT) Received: from ?IPv6:2003:ea:8be1:dd00:a4e7:3af3:db88:50bb? (p200300EA8BE1DD00A4E73AF3DB8850BB.dip0.t-ipconnect.de. [2003:ea:8be1:dd00:a4e7:3af3:db88:50bb]) by smtp.googlemail.com with ESMTPSA id k15sm5994296wmj.8.2019.03.31.07.59.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Mar 2019 07:59:42 -0700 (PDT) Subject: Re: [PATCH net-next] net: phy: improve genphy_read_status To: Andrew Lunn Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" References: <36da82de-6dad-939e-7604-d3c0b93f54c8@gmail.com> <20190331145241.GC20636@lunn.ch> From: Heiner Kallweit Message-ID: Date: Sun, 31 Mar 2019 16:59:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190331145241.GC20636@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 31.03.2019 16:52, Andrew Lunn wrote: >> - if (AUTONEG_ENABLE == phydev->autoneg) { >> + if (phydev->autoneg == AUTONEG_ENABLE && phydev->link) { > > Hi Heiner > > I don't necessary agree with placing the constant first in the > comparison, but it is best practice not to change it when making > additions. It makes it a little bit harder to see what the actual > change was. > I understand the point. However a patch to only change the order of the operands most likely would also be rejected as not being worth it. As a consequence we would have to live with it forever. So I think it needs some "if we touch the code anyway" situation. Or what would be the preferred way to change something like that that is in general ok and can be just a little bit improved? > Andrew > Heiner