Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A37B7EB64D9 for ; Wed, 5 Jul 2023 01:55:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3097B85FB4; Wed, 5 Jul 2023 03:55:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=starfivetech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id EE575860A6; Wed, 5 Jul 2023 03:55:07 +0200 (CEST) Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by phobos.denx.de (Postfix) with ESMTP id 8FA3C85F52 for ; Wed, 5 Jul 2023 03:55:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=starfivetech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=minda.chen@starfivetech.com Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id DC2CC24E26F; Wed, 5 Jul 2023 09:54:59 +0800 (CST) Received: from EXMBX171.cuchost.com (172.16.6.91) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 5 Jul 2023 09:54:59 +0800 Received: from [192.168.125.127] (113.72.144.31) by EXMBX171.cuchost.com (172.16.6.91) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 5 Jul 2023 09:54:59 +0800 Message-ID: Date: Wed, 5 Jul 2023 09:54:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 0/4] Fix rtl8169 compile warning and add a new device ID Content-Language: en-US To: Joe Hershberger , Ramon Fried , Leo , Rick Chen CC: , Mason Huo References: <20230621090540.119313-1-minda.chen@starfivetech.com> From: Minda Chen In-Reply-To: <20230621090540.119313-1-minda.chen@starfivetech.com> Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [113.72.144.31] X-ClientProxiedBy: EXCAS063.cuchost.com (172.16.6.23) To EXMBX171.cuchost.com (172.16.6.91) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Joe and Ramon Sorry to disturb you. Could you please review this patchset. Thanks On 2023/6/21 17:05, Minda Chen wrote: > StarFive JH7110 uboot support PCIe and using rtl8169 network adapter > PCIe device. But compile warning in rtl8169 driver cause CI test fail. > So commit this patch set to fix it, Also a new device ID to adjust the > PCI bar regions in rtl8169. >=20 > The StarFive JH7110 PCIe driver link: > https://patchwork.ozlabs.org/project/uboot/cover/20230509082617.119018-= 1-minda.chen@starfivetech.com/ >=20 > patch 1 is fix make pointer from integer warning. > eg: /home/minda/vf2/visionfive/u-boot/drivers/net/rtl8169.c:103:52: wa= rning: > passing argument 2 of =E2=80=98writew=E2=80=99 makes pointer from i= nteger without a cast [-Wint-conversion] > patch 2 fix RISC-V 8169 descriptor less than DMA min aligned size warni= ng > patch 3 add new device ID > patch 4 enable 8169 in JH7110 SoC configs file. >=20 > Minda Chen (4): > net: rtl8169: Fix compile warning in rtl8169 network adapter > net: rtl8169: Fix DMA min aligned compile warning in riscv > net: rtl8169: Add one more device ID > configs: starfive-jh7110: Add CONFIG_RTL8169 >=20 > configs/starfive_visionfive2_defconfig | 1 + > drivers/net/rtl8169.c | 22 +++++++++++++--------- > 2 files changed, 14 insertions(+), 9 deletions(-) >=20 >=20 > base-commit: 50842b217fef505a0ec6662cc2acdc55d0bb23c5