From: Maarten Lankhorst Subject: Re: [PATCH] drm: fix call_kern.cocci warnings v3 Date: Thu, 25 Oct 2018 20:03:13 +0200 Message-ID: References: <20181025102105.15412-1-david1.zhou@amd.com> <860e509a-1bff-a2b5-2934-6a2125e8fa40@linux.intel.com> <4835ed61-da2b-d205-26a6-09815da787db@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4835ed61-da2b-d205-26a6-09815da787db@amd.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chunming Zhou , "Zhou, David(ChunMing)" , "dri-devel@lists.freedesktop.org" Cc: =?UTF-8?Q?Christian_K=c3=b6nig?= , "intel-gfx@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T3AgMjUtMTAtMTggb20gMTQ6MDEgc2NocmVlZiBDaHVubWluZyBaaG91Ogo+Cj4g5ZyoIDIwMTgv MTAvMjUgMTg6MzYsIE1hYXJ0ZW4gTGFua2hvcnN0IOWGmemBkzoKPj4gT3AgMjUtMTAtMTggb20g MTI6MjEgc2NocmVlZiBDaHVubWluZyBaaG91Ogo+Pj4gZHJpdmVycy9ncHUvZHJtL2RybV9zeW5j b2JqLmM6MjAyOjQtMTQ6IEVSUk9SOiBmdW5jdGlvbiBkcm1fc3luY29ial9maW5kX3NpZ25hbF9w dF9mb3JfcG9pbnQgY2FsbGVkIG9uIGxpbmUgMzkwIGluc2lkZSBsb2NrIG9uIGxpbmUgMzg5IGJ1 dCB1c2VzIEdGUF9LRVJORUwKPj4+Cj4+PiAgICBGaW5kIGZ1bmN0aW9ucyB0aGF0IHJlZmVyIHRv IEdGUF9LRVJORUwgYnV0IGFyZSBjYWxsZWQgd2l0aCBsb2NrcyBoZWxkLgo+Pj4KPj4+IEdlbmVy YXRlZCBieTogc2NyaXB0cy9jb2NjaW5lbGxlL2xvY2tzL2NhbGxfa2Vybi5jb2NjaQo+Pj4KPj4+ IHYyOgo+Pj4gc3luY29iai0+dGltZWxpbmUgc3RpbGwgbmVlZHMgcHJvdGVjdC4KPj4+Cj4+PiB2 MzoKPj4+IHVzZSBhIGdsb2JhbCBzaWduYWxlZCBmZW5jZSBpbnN0ZWFkIG9mIHJlLWFsbG9jYXRp b24uCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogQ2h1bm1pbmcgWmhvdSA8ZGF2aWQxLnpob3VAYW1k LmNvbT4KPj4+IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXgu aW50ZWwuY29tPgo+Pj4gQ2M6IGludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4+IENj OiBDaHJpc3RpYW4gS8O2bmlnIDxlYXN5MnJlbWVtYmVyLmNoa0Bnb29nbGVtYWlsLmNvbT4KPj4+ IC0tLQo+Pj4gICBkcml2ZXJzL2dwdS9kcm0vZHJtX2Rydi5jICAgICB8ICAyICsrCj4+PiAgIGRy aXZlcnMvZ3B1L2RybS9kcm1fc3luY29iai5jIHwgNTIgKysrKysrKysrKysrKysrKysrKysrLS0t LS0tLS0tLS0tLS0KPj4+ICAgaW5jbHVkZS9kcm0vZHJtX3N5bmNvYmouaCAgICAgfCAgMSArCj4+ PiAgIDMgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRpb25zKC0pCj4+ Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMgYi9kcml2ZXJzL2dw dS9kcm0vZHJtX2Rydi5jCj4+PiBpbmRleCAzNmU4ZTljYmVjNTIuLjBhNmYxMDIzZDZjMyAxMDA2 NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMKPj4+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1fZHJ2LmMKPj4+IEBAIC0zNyw2ICszNyw3IEBACj4+PiAgICNpbmNsdWRlIDxk cm0vZHJtX2NsaWVudC5oPgo+Pj4gICAjaW5jbHVkZSA8ZHJtL2RybV9kcnYuaD4KPj4+ICAgI2lu Y2x1ZGUgPGRybS9kcm1QLmg+Cj4+PiArI2luY2x1ZGUgPGRybS9kcm1fc3luY29iai5oPgo+Pj4g ICAKPj4+ICAgI2luY2x1ZGUgImRybV9jcnRjX2ludGVybmFsLmgiCj4+PiAgICNpbmNsdWRlICJk cm1fbGVnYWN5LmgiCj4+PiBAQCAtMTAwMyw2ICsxMDA0LDcgQEAgc3RhdGljIGludCBfX2luaXQg ZHJtX2NvcmVfaW5pdCh2b2lkKQo+Pj4gICAJaWYgKHJldCA8IDApCj4+PiAgIAkJZ290byBlcnJv cjsKPj4+ICAgCj4+PiArCWRybV9zeW5jb2JqX3N0dWJfZmVuY2VfaW5pdCgpOwo+Pj4gICAJZHJt X2NvcmVfaW5pdF9jb21wbGV0ZSA9IHRydWU7Cj4+PiAgIAo+Pj4gICAJRFJNX0RFQlVHKCJJbml0 aWFsaXplZFxuIik7Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9zeW5jb2Jq LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYwo+Pj4gaW5kZXggYjdlYWE2MDNmMzY4 Li42YjNmNWEwNmU0ZDMgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNv YmouYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9zeW5jb2JqLmMKPj4+IEBAIC04MCw2 ICs4MCwyNyBAQCBzdHJ1Y3QgZHJtX3N5bmNvYmpfc2lnbmFsX3B0IHsKPj4+ICAgCXN0cnVjdCBs aXN0X2hlYWQgbGlzdDsKPj4+ICAgfTsKPj4+ICAgCj4+PiArc3RhdGljIHN0cnVjdCBkcm1fc3lu Y29ial9zdHViX2ZlbmNlIHN0dWJfc2lnbmFsZWRfZmVuY2U7Cj4+PiArc3RhdGljIHZvaWQgZ2xv YmFsX3N0dWJfZmVuY2VfcmVsZWFzZShzdHJ1Y3QgZG1hX2ZlbmNlICpmZW5jZSkKPj4+ICt7Cj4+ PiArCS8qIGl0IGlzIGltcG9zc2libGUgdG8gY29tZSBoZXJlICovCj4+PiArCUJVRygpOwo+Pj4g K30KPj4gV0FSTl9PTl9PTkNFKDEpPyBObyBuZWVkIHRvIGhhbHQgdGhlIG1hY2hpbmUuCj4+Cj4+ PiArc3RhdGljIGNvbnN0IHN0cnVjdCBkbWFfZmVuY2Vfb3BzIGdsb2JhbF9zdHViX2ZlbmNlX29w cyA9IHsKPj4+ICsJLmdldF9kcml2ZXJfbmFtZSA9IGRybV9zeW5jb2JqX3N0dWJfZmVuY2VfZ2V0 X25hbWUsCj4+PiArCS5nZXRfdGltZWxpbmVfbmFtZSA9IGRybV9zeW5jb2JqX3N0dWJfZmVuY2Vf Z2V0X25hbWUsCj4+PiArCS5yZWxlYXNlID0gZ2xvYmFsX3N0dWJfZmVuY2VfcmVsZWFzZSwKPj4+ ICt9Owo+Pj4gKwo+Pj4gK3ZvaWQgZHJtX3N5bmNvYmpfc3R1Yl9mZW5jZV9pbml0KHZvaWQpCj4+ PiArewo+Pj4gKwlzcGluX2xvY2tfaW5pdCgmc3R1Yl9zaWduYWxlZF9mZW5jZS5sb2NrKTsKPj4+ ICsJZG1hX2ZlbmNlX2luaXQoJnN0dWJfc2lnbmFsZWRfZmVuY2UuYmFzZSwKPj4+ICsJCSAgICAg ICAmZ2xvYmFsX3N0dWJfZmVuY2Vfb3BzLAo+Pj4gKwkJICAgICAgICZzdHViX3NpZ25hbGVkX2Zl bmNlLmxvY2ssCj4+PiArCQkgICAgICAgMCwgMCk7Cj4+PiArCWRtYV9mZW5jZV9zaWduYWwoJnN0 dWJfc2lnbmFsZWRfZmVuY2UuYmFzZSk7Cj4+PiArfQo+Pj4gICAvKioKPj4+ICAgICogZHJtX3N5 bmNvYmpfZmluZCAtIGxvb2t1cCBhbmQgcmVmZXJlbmNlIGEgc3luYyBvYmplY3QuCj4+PiAgICAq IEBmaWxlX3ByaXZhdGU6IGRybSBmaWxlIHByaXZhdGUgcG9pbnRlcgo+Pj4gQEAgLTExMSwyNCAr MTMyLDE0IEBAIHN0YXRpYyBzdHJ1Y3QgZG1hX2ZlbmNlCj4+PiAgIAkJCQkgICAgICB1aW50NjRf dCBwb2ludCkKPj4+ICAgewo+Pj4gICAJc3RydWN0IGRybV9zeW5jb2JqX3NpZ25hbF9wdCAqc2ln bmFsX3B0Owo+Pj4gKwlzdHJ1Y3QgZG1hX2ZlbmNlICpmID0gTlVMTDsKPj4+ICAgCj4+PiArCXNw aW5fbG9jaygmc3luY29iai0+cHRfbG9jayk7Cj4+PiAgIAlpZiAoKHN5bmNvYmotPnR5cGUgPT0g RFJNX1NZTkNPQkpfVFlQRV9USU1FTElORSkgJiYKPj4+ICAgCSAgICAocG9pbnQgPD0gc3luY29i ai0+dGltZWxpbmUpKSB7Cj4+PiAtCQlzdHJ1Y3QgZHJtX3N5bmNvYmpfc3R1Yl9mZW5jZSAqZmVu Y2UgPQo+Pj4gLQkJCWt6YWxsb2Moc2l6ZW9mKHN0cnVjdCBkcm1fc3luY29ial9zdHViX2ZlbmNl KSwKPj4+IC0JCQkJR0ZQX0tFUk5FTCk7Cj4+PiAtCj4+PiAtCQlpZiAoIWZlbmNlKQo+Pj4gLQkJ CXJldHVybiBOVUxMOwo+Pj4gLQkJc3Bpbl9sb2NrX2luaXQoJmZlbmNlLT5sb2NrKTsKPj4+IC0J CWRtYV9mZW5jZV9pbml0KCZmZW5jZS0+YmFzZSwKPj4+IC0JCQkgICAgICAgJmRybV9zeW5jb2Jq X3N0dWJfZmVuY2Vfb3BzLAo+Pj4gLQkJCSAgICAgICAmZmVuY2UtPmxvY2ssCj4+PiAtCQkJICAg ICAgIHN5bmNvYmotPnRpbWVsaW5lX2NvbnRleHQsCj4+PiAtCQkJICAgICAgIHBvaW50KTsKPj4+ IC0KPj4+IC0JCWRtYV9mZW5jZV9zaWduYWwoJmZlbmNlLT5iYXNlKTsKPj4+IC0JCXJldHVybiAm ZmVuY2UtPmJhc2U7Cj4+PiArCQlkbWFfZmVuY2VfZ2V0KCZzdHViX3NpZ25hbGVkX2ZlbmNlLmJh c2UpOwo+Pj4gKwkJc3Bpbl91bmxvY2soJnN5bmNvYmotPnB0X2xvY2spOwo+Pj4gKwkJcmV0dXJu ICZzdHViX3NpZ25hbGVkX2ZlbmNlLmJhc2U7Cj4+PiAgIAl9Cj4+PiAgIAo+Pj4gICAJbGlzdF9m b3JfZWFjaF9lbnRyeShzaWduYWxfcHQsICZzeW5jb2JqLT5zaWduYWxfcHRfbGlzdCwgbGlzdCkg ewo+Pj4gQEAgLTEzNyw5ICsxNDgsMTIgQEAgc3RhdGljIHN0cnVjdCBkbWFfZmVuY2UKPj4+ICAg CQlpZiAoKHN5bmNvYmotPnR5cGUgPT0gRFJNX1NZTkNPQkpfVFlQRV9CSU5BUlkpICYmCj4+PiAg IAkJICAgIChwb2ludCAhPSBzaWduYWxfcHQtPnZhbHVlKSkKPj4+ICAgCQkJY29udGludWU7Cj4+ PiAtCQlyZXR1cm4gZG1hX2ZlbmNlX2dldCgmc2lnbmFsX3B0LT5mZW5jZV9hcnJheS0+YmFzZSk7 Cj4+PiArCQlmID0gZG1hX2ZlbmNlX2dldCgmc2lnbmFsX3B0LT5mZW5jZV9hcnJheS0+YmFzZSk7 Cj4+PiArCQlicmVhazsKPj4+ICAgCX0KPj4+IC0JcmV0dXJuIE5VTEw7Cj4+PiArCXNwaW5fdW5s b2NrKCZzeW5jb2JqLT5wdF9sb2NrKTsKPj4+ICsKPj4+ICsJcmV0dXJuIGY7Cj4+PiAgIH0KPj4+ ICAgCj4+PiAgIHN0YXRpYyB2b2lkIGRybV9zeW5jb2JqX2FkZF9jYWxsYmFja19sb2NrZWQoc3Ry dWN0IGRybV9zeW5jb2JqICpzeW5jb2JqLAo+Pj4gQEAgLTE2Niw5ICsxODAsNyBAQCBzdGF0aWMg dm9pZCBkcm1fc3luY29ial9mZW5jZV9nZXRfb3JfYWRkX2NhbGxiYWNrKHN0cnVjdCBkcm1fc3lu Y29iaiAqc3luY29iaiwKPj4+ICAgCX0KPj4+ICAgCj4+PiAgIAltdXRleF9sb2NrKCZzeW5jb2Jq LT5jYl9tdXRleCk7Cj4+PiAtCXNwaW5fbG9jaygmc3luY29iai0+cHRfbG9jayk7Cj4+PiAgIAkq ZmVuY2UgPSBkcm1fc3luY29ial9maW5kX3NpZ25hbF9wdF9mb3JfcG9pbnQoc3luY29iaiwgcHRf dmFsdWUpOwo+Pj4gLQlzcGluX3VubG9jaygmc3luY29iai0+cHRfbG9jayk7Cj4+PiAgIAlpZiAo ISpmZW5jZSkKPj4+ICAgCQlkcm1fc3luY29ial9hZGRfY2FsbGJhY2tfbG9ja2VkKHN5bmNvYmos IGNiLCBmdW5jKTsKPj4+ICAgCW11dGV4X3VubG9jaygmc3luY29iai0+Y2JfbXV0ZXgpOwo+Pj4g QEAgLTM3OSwxMSArMzkxLDkgQEAgZHJtX3N5bmNvYmpfcG9pbnRfZ2V0KHN0cnVjdCBkcm1fc3lu Y29iaiAqc3luY29iaiwgdTY0IHBvaW50LCB1NjQgZmxhZ3MsCj4+PiAgIAkJaWYgKHJldCA8IDAp Cj4+PiAgIAkJCXJldHVybiByZXQ7Cj4+PiAgIAl9Cj4+PiAtCXNwaW5fbG9jaygmc3luY29iai0+ cHRfbG9jayk7Cj4+PiAgIAkqZmVuY2UgPSBkcm1fc3luY29ial9maW5kX3NpZ25hbF9wdF9mb3Jf cG9pbnQoc3luY29iaiwgcG9pbnQpOwo+Pj4gICAJaWYgKCEqZmVuY2UpCj4+PiAgIAkJcmV0ID0g LUVJTlZBTDsKPj4+IC0Jc3Bpbl91bmxvY2soJnN5bmNvYmotPnB0X2xvY2spOwo+Pj4gICAJcmV0 dXJuIHJldDsKPj4+ICAgfQo+Pj4gICAKPj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1f c3luY29iai5oIGIvaW5jbHVkZS9kcm0vZHJtX3N5bmNvYmouaAo+Pj4gaW5kZXggMjkyNDRjYmNk MDVlLi42M2NmZDE1NDAyNDEgMTAwNjQ0Cj4+PiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fc3luY29i ai5oCj4+PiArKysgYi9pbmNsdWRlL2RybS9kcm1fc3luY29iai5oCj4+PiBAQCAtMTQ4LDQgKzE0 OCw1IEBAIGludCBkcm1fc3luY29ial9nZXRfZmQoc3RydWN0IGRybV9zeW5jb2JqICpzeW5jb2Jq LCBpbnQgKnBfZmQpOwo+Pj4gICBpbnQgZHJtX3N5bmNvYmpfc2VhcmNoX2ZlbmNlKHN0cnVjdCBk cm1fc3luY29iaiAqc3luY29iaiwgdTY0IHBvaW50LCB1NjQgZmxhZ3MsCj4+PiAgIAkJCSAgICAg c3RydWN0IGRtYV9mZW5jZSAqKmZlbmNlKTsKPj4+ICAgCj4+PiArdm9pZCBkcm1fc3luY29ial9z dHViX2ZlbmNlX2luaXQodm9pZCk7Cj4+PiAgICNlbmRpZgo+PiBNb3ZlIGl0IHRvIGRybV9pbnRl cm5hbC5oID8gVGhpcyBpcyBub3QgZm9yIGRyaXZlciBjb25zdW1wdGlvbi4gOikKPj4gaSB3b3Vs ZCBzcGxpdCB1cCB0aGUgY2hhbmdlcyBhdCB0aGlzIHBvaW50Ogo+Pgo+PiAxLiBSZXBsYWNlIG1l bW9yeSBhbGxvY2F0aW9uIHdpdGggYSBzdGF0aWMgZmVuY2UsIG5vdCBuZWNlc3NhcmlseSBjaGFu Z2luZyBhbnkgbG9ja2luZywgYWRkIGEgZml4ZXMgdGFnIHRvIHRoaXMgY29tbWl0Lgo+Pgo+PiAy LiBNb3ZlIGxvY2tpbmcuCj4gTm8gbmVjZXNzYXJ5LCB3aHkgY2hhbmdlIGl0Pwo+Cj4+IDMuIEZp eCBkcm1fc3luY29ial9mZW5jZV9nZXRfb3JfYWRkX2NhbGxiYWNrIHRvIHJldHVybiBhbiBlcnJv ci4KPiB3aHkgZG9lcyBpdCBzdGlsbCBuZWVkIGEgcmV0dXJuIHZhbHVlPyBDaHJpcyBhbmQgSSBh cmUgdHJ5aW5nIHRvIGF2b2lkIHRoYXQuCkkganVzdCBuZWVkIGEgY2xhcmlmaWNhdGlvbiBvbiB3 aHkgaXQncyBvayB0byBpZ25vcmUgdG8gcmV0dXJuIGZlbmNlIG5vdCBmb3VuZC4gQ291bGQgYmUg YSBjb21tZW50IGluIHRoZSBjb2RlIGFzIHdlbGwuIDopCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=