Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD256C432C0 for ; Mon, 2 Dec 2019 11:18:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A88D920833 for ; Mon, 2 Dec 2019 11:18:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727398AbfLBLSg (ORCPT ); Mon, 2 Dec 2019 06:18:36 -0500 Received: from out30-131.freemail.mail.aliyun.com ([115.124.30.131]:38795 "EHLO out30-131.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726276AbfLBLSg (ORCPT ); Mon, 2 Dec 2019 06:18:36 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=dust.li@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0TjimBtc_1575285500; Received: from jingxuanljxdeMacBook-Pro.local(mailfrom:dust.li@linux.alibaba.com fp:SMTPD_---0TjimBtc_1575285500) by smtp.aliyun-inc.com(127.0.0.1); Mon, 02 Dec 2019 19:18:21 +0800 Subject: Re: [PATCH] net: sched: fix wrong class stats dumping in sch_mqprio To: Cong Wang Cc: Jamal Hadi Salim , Jiri Pirko , John Fastabend , Tony Lu , Linux Kernel Network Developers References: <20191128063107.91297-1-dust.li@linux.alibaba.com> From: Dust Li Message-ID: Date: Mon, 2 Dec 2019 19:18:20 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/30/19 1:48 PM, Cong Wang wrote: > On Wed, Nov 27, 2019 at 10:31 PM Dust Li wrote: >> Actually, the stack variables bstats and qstats in >> mqprio_dump_class_stats() are not really used. As a result, >> 'tc -s class show' for the mqprio class always return 0 for >> both bstats and qstats. Use them to store the child qdisc's >> stats and add them up as the stats for the mqprio class. > This patch is on top of the previous one you sent, so please group > and number them as "Patch X/N", otherwise it is confusing. > > Thanks. OK, Thanks for your kind advice, I'll group them and re-send. Thanks. Dust Li