From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Use memset64() to align the ring with MI_NOOP Date: Wed, 25 Apr 2018 15:00:43 +0100 Message-ID: References: <20180425123718.16366-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id D260089B33 for ; Wed, 25 Apr 2018 14:00:48 +0000 (UTC) In-Reply-To: <20180425123718.16366-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI1LzA0LzIwMTggMTM6MzcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBXaGVuIGZpbGxpbmcg dGhlIHJpbmcgdG8gYWxpZ24gdGhlIGVtaXQgcG9pbnRlciB0byB0aGUgbmV4dCBjYWNoZWxpbmUs Cj4gdXNlIG1lbXNldDY0KCkgcmF0aGVyIHRoYW4gb3Blbi1jb2RpbmcgaXQuIEFzIHdlIGtub3cg dGhhdCB3ZSBhbHdheXMKPiBoYXZlIGFuIGV2ZW4gbnVtYmVyIG9mIGR3b3Jkcywgd2UgY2FuIHJl cGxhY2UgdGhlIGR3b3JkIGxvb3Agd2l0aCB0aGUKPiBxd29yZCBlcXVpdmFsZW50Lgo+IAo+IFNp Z25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0t LQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIHwgMTQgKysrKysr KystLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZm ZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+IGluZGV4IGM2 OGFjNjA1YjhhOS4uMDdhOWEyYjRiZWI3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3JpbmdidWZmZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3JpbmdidWZmZXIuYwo+IEBAIC0xNzE3LDIyICsxNzE3LDI0IEBAIHUzMiAqaW50ZWxfcmluZ19i ZWdpbihzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSwgdW5zaWduZWQgaW50IG51bV9kd29yZHMpCj4g ICAvKiBBbGlnbiB0aGUgcmluZyB0YWlsIHRvIGEgY2FjaGVsaW5lIGJvdW5kYXJ5ICovCj4gICBp bnQgaW50ZWxfcmluZ19jYWNoZWxpbmVfYWxpZ24oc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEpCj4g ICB7Cj4gLQlpbnQgbnVtX2R3b3JkcyA9IChycS0+cmluZy0+ZW1pdCAmIChDQUNIRUxJTkVfQllU RVMgLSAxKSkgLyBzaXplb2YodTMyKTsKPiAtCXUzMiAqY3M7Cj4gKwlpbnQgbnVtX2R3b3JkczsK PiArCXZvaWQgKmNzOwo+ICAgCj4gKwludW1fZHdvcmRzID0gKHJxLT5yaW5nLT5lbWl0ICYgKENB Q0hFTElORV9CWVRFUyAtIDEpKSAvIHNpemVvZih1MzIpOwo+ICAgCWlmIChudW1fZHdvcmRzID09 IDApCj4gICAJCXJldHVybiAwOwo+ICAgCj4gLQludW1fZHdvcmRzID0gQ0FDSEVMSU5FX0JZVEVT IC8gc2l6ZW9mKHUzMikgLSBudW1fZHdvcmRzOwo+ICsJbnVtX2R3b3JkcyA9IENBQ0hFTElORV9E V09SRFMgLSBudW1fZHdvcmRzOwo+ICsJR0VNX0JVR19PTihudW1fZHdvcmRzICYgMSk7Cj4gKwo+ ICAgCWNzID0gaW50ZWxfcmluZ19iZWdpbihycSwgbnVtX2R3b3Jkcyk7Cj4gICAJaWYgKElTX0VS UihjcykpCj4gICAJCXJldHVybiBQVFJfRVJSKGNzKTsKPiAgIAo+IC0Jd2hpbGUgKG51bV9kd29y ZHMtLSkKPiAtCQkqY3MrKyA9IE1JX05PT1A7Cj4gLQoKQlVJTERfQlVHX09OKE1JX05PT1AgIT0g MCkgZm9yIHBhcmFub2lkIGZ1dHVyZSBwcm9vZmluZywgc2luY2UgTUlfTk9PUCAKaXMgbm93IG5v dCBtZW50aW9uZWQgaW4gdGhpcyBmdW5jdGlvbiwgYnV0IGlzIG1lYW50LgoKPiArCW1lbXNldDY0 KGNzLCAwLCBudW1fZHdvcmRzLzIpOwoKU3BhY2VzIGFyb3VuZCAnLycgdG8gYXBwZWFzZSBjaGVj a3BhdGNoIGFuZCBvdXIgc3R5bGUuCgo+ICAgCWludGVsX3JpbmdfYWR2YW5jZShycSwgY3MpOwo+ ICAgCj4gKwlHRU1fQlVHX09OKHJxLT5yaW5nLT5lbWl0ICYgQ0FDSEVMSU5FX0JZVEVTKTsKPiAg IAlyZXR1cm4gMDsKPiAgIH0KPiAgIAo+IAoKV2l0aCB3aGl0ZXNwYWNlIGZpeGVkLCBhbmQgcHJl ZmVyYWJseSBCVUlMRF9CVUdfT046CgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRr by51cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==