References: <20200731100629.24611-1-arne@...1227...> From: Arne Schwabe Message-ID: Date: Wed, 19 Aug 2020 10:31:22 +0200 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB Subject: Re: [Openvpn-devel] [PATCH] Skip existing interfaces on opening the first available utun on macOS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: Lev Stipakov Cc: openvpn-devel Am 05.08.20 um 11:02 schrieb Lev Stipakov: > Hi, > > + ASSERT(snprintf(ifname, sizeof(ifname), "utun%d", utunnum)); > > Not sure about ASSERT here, because according to > https://linux.die.net/man/3/snprintf > >> If an output error is encountered, a negative value is returned. > > which won't trigger assert. > > Otherwise looks good. > > Compiled and tested on macOS. > > Maybe Gert could remove ASSERT wrapping before commiting. > > Acked-by: Lev Stipakov > You are too late, there is already a v2 that fixed that problem and is merged :) Arne