From: "Kuehling, Felix" Subject: Re: [PATCH] drm/amdgpu: improve HMM error -ENOMEM and -EBUSY handling Date: Mon, 17 Jun 2019 20:45:24 +0000 Message-ID: References: <20190615015231.31871-1-Philip.Yang@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190615015231.31871-1-Philip.Yang-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US Content-ID: <300CC6DBA8BC6E469FA826F94333E678-asWib9pRmPqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Yang, Philip" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" T24gMjAxOS0wNi0xNCA5OjUyIHAubS4sIFlhbmcsIFBoaWxpcCB3cm90ZToNCj4gVW5kZXIgbWVt b3J5IHByZXNzdXJlLCBobW1fcmFuZ2VfZmF1bHQgbWF5IHJldHVybiBlcnJvciBjb2RlIC1FTk9N RU0NCj4gb3IgLUVCVVNZLCBjaGFuZ2UgcHJfaW5mbyB0byBwcl9kZWJ1ZyB0byByZW1vdmUgdW5u ZWNlc3Nhcnkga2VybmVsIGxvZw0KPiBtZXNzYWdlIGJlY2F1c2Ugd2Ugd2lsbCByZXRyeSByZXN0 b3JlIGFnYWluLg0KPg0KPiBDYWxsIGdldF91c2VyX3BhZ2VzX2RvbmUgaWYgVFRNIGdldCB1c2Vy IHBhZ2VzIGZhaWxlZCB3aWxsIGhhdmUNCj4gV0FSTl9PTkNFIGtlcm5lbCBjYWxsaW5nIHN0YWNr IGR1bXAgbG9nLg0KPg0KPiBDaGFuZ2UtSWQ6IEkwODZmOTI5NDQ2MzBmOWQxYTcwMzY1YzAwNDE3 Y2I5NDQwNjYyNDY0DQo+IFNpZ25lZC1vZmYtYnk6IFBoaWxpcCBZYW5nIDxQaGlsaXAuWWFuZ0Bh bWQuY29tPg0KDQpSZXZpZXdlZC1ieTogRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1ZWhsaW5nQGFt ZC5jb20+DQoNCg0KPiAtLS0NCj4gICAuLi4vZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9hbWRr ZmRfZ3B1dm0uYyAgfCAzOCArKystLS0tLS0tLS0tLS0tLS0tDQo+ICAgMSBmaWxlIGNoYW5nZWQs IDYgaW5zZXJ0aW9ucygrKSwgMzIgZGVsZXRpb25zKC0pDQo+DQo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfYW1ka2ZkX2dwdXZtLmMgYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfYW1ka2ZkX2dwdXZtLmMNCj4gaW5kZXggNzRlODY5NTI1 NTNmLi4xMGFiYWUzOThlNTEgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9hbWRrZmRfZ3B1dm0uYw0KPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfYW1ka2ZkX2dwdXZtLmMNCj4gQEAgLTE3MzEsMzUgKzE3MzEsMTcgQEAgc3Rh dGljIGludCB1cGRhdGVfaW52YWxpZF91c2VyX3BhZ2VzKHN0cnVjdCBhbWRrZmRfcHJvY2Vzc19p bmZvICpwcm9jZXNzX2luZm8sDQo+ICAgCQlyZXQgPSBhbWRncHVfdHRtX3R0X2dldF91c2VyX3Bh Z2VzKGJvLT50Ym8udHRtLA0KPiAgIAkJCQkJCSAgIGJvLT50Ym8udHRtLT5wYWdlcyk7DQo+ICAg CQlpZiAocmV0KSB7DQo+IC0JCQliby0+dGJvLnR0bS0+cGFnZXNbMF0gPSBOVUxMOw0KPiAtCQkJ cHJfaW5mbygiJXM6IEZhaWxlZCB0byBnZXQgdXNlciBwYWdlczogJWRcbiIsDQo+ICsJCQlwcl9k ZWJ1ZygiJXM6IEZhaWxlZCB0byBnZXQgdXNlciBwYWdlczogJWRcbiIsDQo+ICAgCQkJCV9fZnVu Y19fLCByZXQpOw0KPiAtCQkJLyogUHJldGVuZCBpdCBzdWNjZWVkZWQuIEl0IHdpbGwgZmFpbCBs YXRlcg0KPiAtCQkJICogd2l0aCBhIFZNIGZhdWx0IGlmIHRoZSBHUFUgdHJpZXMgdG8gYWNjZXNz DQo+IC0JCQkgKiBpdC4gQmV0dGVyIHRoYW4gaGFuZ2luZyBpbmRlZmluaXRlbHkgd2l0aA0KPiAt CQkJICogc3RhbGxlZCB1c2VyIG1vZGUgcXVldWVzLg0KPiAtCQkJICovDQo+IC0JCX0NCj4gLQl9 DQo+IC0NCj4gLQlyZXR1cm4gMDsNCj4gLX0NCj4gICANCj4gLS8qIFJlbW92ZSBpbnZhbGlkIHVz ZXJwdHIgQk9zIGZyb20gaG1tIHRyYWNrIGxpc3QNCj4gLSAqDQo+IC0gKiBTdG9wIEhNTSB0cmFj ayB0aGUgdXNlcnB0ciB1cGRhdGUNCj4gLSAqLw0KPiAtc3RhdGljIHZvaWQgdW50cmFja19pbnZh bGlkX3VzZXJfcGFnZXMoc3RydWN0IGFtZGtmZF9wcm9jZXNzX2luZm8gKnByb2Nlc3NfaW5mbykN Cj4gLXsNCj4gLQlzdHJ1Y3Qga2dkX21lbSAqbWVtLCAqdG1wX21lbTsNCj4gLQlzdHJ1Y3QgYW1k Z3B1X2JvICpibzsNCj4gKwkJCS8qIFJldHVybiBlcnJvciAtRUJVU1kgb3IgLUVOT01FTSwgcmV0 cnkgcmVzdG9yZSAqLw0KPiArCQkJcmV0dXJuIHJldDsNCj4gKwkJfQ0KPiAgIA0KPiAtCWxpc3Rf Zm9yX2VhY2hfZW50cnlfc2FmZShtZW0sIHRtcF9tZW0sDQo+IC0JCQkJICZwcm9jZXNzX2luZm8t PnVzZXJwdHJfaW52YWxfbGlzdCwNCj4gLQkJCQkgdmFsaWRhdGVfbGlzdC5oZWFkKSB7DQo+IC0J CWJvID0gbWVtLT5ibzsNCj4gICAJCWFtZGdwdV90dG1fdHRfZ2V0X3VzZXJfcGFnZXNfZG9uZShi by0+dGJvLnR0bSk7DQo+ICAgCX0NCj4gKw0KPiArCXJldHVybiAwOw0KPiAgIH0NCj4gICANCj4g ICAvKiBWYWxpZGF0ZSBpbnZhbGlkIHVzZXJwdHIgQk9zDQo+IEBAIC0xODQxLDEzICsxODIzLDYg QEAgc3RhdGljIGludCB2YWxpZGF0ZV9pbnZhbGlkX3VzZXJfcGFnZXMoc3RydWN0IGFtZGtmZF9w cm9jZXNzX2luZm8gKnByb2Nlc3NfaW5mbykNCj4gICAJCWxpc3RfbW92ZV90YWlsKCZtZW0tPnZh bGlkYXRlX2xpc3QuaGVhZCwNCj4gICAJCQkgICAgICAgJnByb2Nlc3NfaW5mby0+dXNlcnB0cl92 YWxpZF9saXN0KTsNCj4gICANCj4gLQkJLyogU3RvcCBITU0gdHJhY2sgdGhlIHVzZXJwdHIgdXBk YXRlLiBXZSBkb250IGNoZWNrIHRoZSByZXR1cm4NCj4gLQkJICogdmFsdWUgZm9yIGNvbmN1cnJl bnQgQ1BVIHBhZ2UgdGFibGUgdXBkYXRlIGJlY2F1c2Ugd2Ugd2lsbA0KPiAtCQkgKiByZXNjaGVk dWxlIHRoZSByZXN0b3JlIHdvcmtlciBpZiBwcm9jZXNzX2luZm8tPmV2aWN0ZWRfYm9zDQo+IC0J CSAqIGlzIHVwZGF0ZWQuDQo+IC0JCSAqLw0KPiAtCQlhbWRncHVfdHRtX3R0X2dldF91c2VyX3Bh Z2VzX2RvbmUoYm8tPnRiby50dG0pOw0KPiAtDQo+ICAgCQkvKiBVcGRhdGUgbWFwcGluZy4gSWYg dGhlIEJPIHdhcyBub3QgdmFsaWRhdGVkDQo+ICAgCQkgKiAoYmVjYXVzZSB3ZSBjb3VsZG4ndCBn ZXQgdXNlciBwYWdlcyksIHRoaXMgd2lsbA0KPiAgIAkJICogY2xlYXIgdGhlIHBhZ2UgdGFibGUg ZW50cmllcywgd2hpY2ggd2lsbCByZXN1bHQgaW4NCj4gQEAgLTE5NDYsNyArMTkyMSw2IEBAIHN0 YXRpYyB2b2lkIGFtZGdwdV9hbWRrZmRfcmVzdG9yZV91c2VycHRyX3dvcmtlcihzdHJ1Y3Qgd29y a19zdHJ1Y3QgKndvcmspDQo+ICAgCX0NCj4gICANCj4gICB1bmxvY2tfb3V0Og0KPiAtCXVudHJh Y2tfaW52YWxpZF91c2VyX3BhZ2VzKHByb2Nlc3NfaW5mbyk7DQo+ICAgCW11dGV4X3VubG9jaygm cHJvY2Vzc19pbmZvLT5sb2NrKTsNCj4gICAJbW1wdXQobW0pOw0KPiAgIAlwdXRfdGFza19zdHJ1 Y3QodXNlcnRhc2spOw0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4