References: <20210310154754.GH976@...1296...> <20210317130312.8585-1-arne@...1227...> From: Antonio Quartulli Message-ID: Date: Thu, 25 Mar 2021 23:57:12 +0100 MIME-Version: 1.0 In-Reply-To: <20210317130312.8585-1-arne@...1227...> Content-Language: en-US Subject: Re: [Openvpn-devel] [PATCH v5 1/2] Move auth deferred related members into its own struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Arne Schwabe , openvpn-devel@lists.sourceforge.net Hi, On 17/03/2021 14:03, Arne Schwabe wrote: > This structures the code a bit nicer and also prepares for deferred > scripts that needs their own set of files. > > Signed-off-by: Arne Schwabe For me this is an ACK, but unfortunately I have no test rig for deferred auth and therefore I cannot really test these code paths. This said, after staring at the code, I can confirm this is just a restyling of some struct members and nothing else. A basic client-server test passes as expected. Regards, -- Antonio Quartulli