From: "cron2 (Code Review)" Date: Fri, 18 Jul 2025 18:55:36 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="23aOZj+++vI="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Multi-socket: Fix assert triggered by stale peer-id reuse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: plaisthos , flichtenheld , openvpn-devel --23aOZj+++vI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/1078?usp=3Demail ) Change subject: Multi-socket: Fix assert triggered by stale peer-id reuse ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: Interesting. I can not trigger the ASSERT() with "master" with the sequenc= e described - start multisocket master - connect UDP client on peer id 0 - connect TCP client on peer id 1 - restart the server - TCP client reconnects, now peer id 0 - UDP client "sends packets with peer id 0" it does some other weird things here, namely killing the TCP #0 instance on= each UDP packet from #0 - but this is also fixed with this patch (it will = just ignore udp #0 packets). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1078?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iecbbcf32c0059f2b16a05333b3794599060d7d6a Gerrit-Change-Number: 1078 Gerrit-PatchSet: 3 Gerrit-Owner: its_Giaan Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Fri, 18 Jul 2025 18:55:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --23aOZj+++vI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, its_Giaan, plaistho= s.

Patch set 3:Code-Review +2=

V= iew Change

1 comment:

  • Patchset:

    • Patch Set #3:

      Interesting. I can not trigger the ASSERT()= with "master" with the sequence described

      • start multi= socket master
      • connect UDP client on peer id 0
      • connect TCP c= lient on peer id 1
      • restart the server
      • TCP client reconnects= , now peer id 0
      • UDP client "sends packets with peer id 0"=

      it doe= s some other weird things here, namely killing the TCP #0 instance on each = UDP packet from #0 - but this is also fixed with this patch (it will just i= gnore udp #0 packets).

To view, visit change 1078. To= unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iecbbcf32c0059f2b16a05333b37= 94599060d7d6a
Gerrit-Change-Number: 1078
Gerrit-PatchSet: 3
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Fri, 18 Jul 2025 18:55:36= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--23aOZj+++vI=--