Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D03EC0015E for ; Tue, 15 Aug 2023 06:34:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5010940014; Tue, 15 Aug 2023 02:34:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD89090000B; Tue, 15 Aug 2023 02:34:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5284940014; Tue, 15 Aug 2023 02:34:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A2F7190000B for ; Tue, 15 Aug 2023 02:34:20 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 08D6A40C87 for ; Tue, 15 Aug 2023 06:34:20 +0000 (UTC) X-FDA: 81125374680.10.4AA82E2 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf08.hostedemail.com (Postfix) with ESMTP id 3A6FE160007 for ; Tue, 15 Aug 2023 06:34:18 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=p9+S6hsr; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of hughd@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692081258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CxAoE5eSsUJ3Vpa248rsUjBgcZlqW5zx3rfHtPXFetE=; b=KLcJvwiVW0WWnzzZxQ7vVeg7yGU7GePx9yrQ4ApeTPf9hnbpRLLQJVnFdROwmabk4wVpXj xPEagsPamJ2sbcHyebdumSFXyj9tJzzrn4gWtKgJd3s1OCfNjn9qUqzRzYiO3jKerTlZN2 Dpp5waHkvYsuZDggWaNWb5lB7AD3J/U= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=p9+S6hsr; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of hughd@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692081258; a=rsa-sha256; cv=none; b=4PgsBNvHUtkemLhNB3OnXVrEqpAik5Ml9m0HQ3JI/WL4MC/FSGIEHpFCrF/hBOkaHjUY5m 3YE0rVDWLyEon4e9nt2HVg8ztKm2wzaPJ5PCzXLhFTAt4duBKVEV1TeFFNgRgPa5VGLxA6 v9yYTtt2kor8LFia8yShyoY7EdNQRZI= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-58c5aecea4eso2009117b3.3 for ; Mon, 14 Aug 2023 23:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692081257; x=1692686057; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=CxAoE5eSsUJ3Vpa248rsUjBgcZlqW5zx3rfHtPXFetE=; b=p9+S6hsrqoi9/yc4fLyRQJ95h3qITRTFxdQEqhTJUhKaf0i0Jq2XhWghBIyPtmk/uJ 4M5rigTywIy/m6/mqluMBYNqiUseBjkuhrD18FHdjGgYia3YM0ohXGUPvtYtuJbUMGeY KVH2ky0rlQ6+hENvUAmulC7cWSQSP/LKt+gOFFRQrWskd7A62t+qW5uDKWGsrqjzQyk+ fLqCcbbNzqddLJlXUy8iNMraK1vN+/eGlLwEF2khEeWeMKnJ7UuQbpgWL7j/mRLCk4cz YpGbv7Zwl3yPNwj3AN+GR84frj8c9W+wGv9rPeefkMFN0+K0UD0PoEDwA3yJa5lDyBmb 07KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692081257; x=1692686057; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CxAoE5eSsUJ3Vpa248rsUjBgcZlqW5zx3rfHtPXFetE=; b=V7xG4O8IVmbYyeTnmjxiiTXx/RL+CRIdDbo1yVGAZK107OrHDoI8zq+/th21Xe9OfA wEnQWZt8H4oxiS6aLKkReXSJ2eqppu4su6HeguPlluVyd1riuMlqzERBg9yhpqqIpPJf OkMo1Vgxr+tlD0O0+uG48qGVz4W6yOl7zB/+aW2qmAWcl6Jrvkx1CVXFAgz42zvWlndE 9NnICT8uXj/onVZS1MkO4mZD3cHnrZgPrDV1E3dW74tbnc2kFHAnV7Fqhb1zVrfG+drs RC8XVU6cH4qVfsnEIyAVb1vIUmaQJWHcUnQ98U1ZEcoPWEjKdtLWx0+UAupck9NDcURx JhBg== X-Gm-Message-State: AOJu0YzuUfdULJALZ570tQZ33VLEFrhc9It+iw0xndJEE1Pw1SwHBPiK WmxOaiIelAa/uJ4GxoiDDFdoUQ== X-Google-Smtp-Source: AGHT+IH+fi/XU+DF2DJSdgQk63a8BNgNbEsx1w15WGuNkVMjLKqhEPN8ZgYcWj0XgH+EA3OAGhi3nA== X-Received: by 2002:a81:a1cc:0:b0:58c:5463:85ec with SMTP id y195-20020a81a1cc000000b0058c546385ecmr1880290ywg.23.1692081257133; Mon, 14 Aug 2023 23:34:17 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id r30-20020a81441e000000b005836fc7df19sm3235677ywa.81.2023.08.14.23.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 23:34:16 -0700 (PDT) Date: Mon, 14 Aug 2023 23:34:05 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Jann Horn cc: Hugh Dickins , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Lorenzo Stoakes , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Russell King , "David S. Miller" , Michael Ellerman , "Aneesh Kumar K.V" , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Vasily Gorbik , Vishal Moola , Vlastimil Babka , Zi Yan , Linux ARM , sparclinux@vger.kernel.org, linuxppc-dev , linux-s390 , kernel list , Linux-MM Subject: Re: [BUG] Re: [PATCH v3 10/13] mm/khugepaged: collapse_pte_mapped_thp() with mmap_read_lock() In-Reply-To: Message-ID: References: <7cd843a9-aa80-14f-5eb2-33427363c20@google.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463760895-1382586557-1692081256=:4366" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3A6FE160007 X-Stat-Signature: e8yfepbzw81awxwxy96jyqidsbrkqpz7 X-HE-Tag: 1692081258-600085 X-HE-Meta: U2FsdGVkX1/9fS/Esd++/s9fy+zY34x/6kFMf8vxEyGgyRRpjNZv9wN6MGl4fksgpAj+d68JZzqdKuPBU/Z/Q9ldmK3LuSelbUgJeyZbmIdwh8n+0yuqO8LX27/RROotLA/tlgrOy68XAED5aWujJCql6qsgQUa2l4aVBlRSO4vbyDrBWXw9I9SRskkYM5htTj1lZf0xxYPKCCR/1l+2tyvdckYufjkxzjOsr9kZ0h1OiySd7XWasaU0xd4eh8QDHnVgU/Fz80UvfVHFhZ1AoALi5yp7c/jgp9aEd2LshNc0qoicvRv2Z8jHyrV1VmfxYkuh517foPx2Sq5Vb9UrMK0ltH+6JK1ZARsBRf0nXndanXDpsfXKw9EfqP/q8W5xW3094XF0lL4e4nlx22ACRr1ZFvpKsfVRk7vd+i45cGR+VptOfL60y1GksX2tTzD87rehMI/DsdGXi2tFBMcWYiBBPF4pBc101+0/CfuuobouwMPVWsWAkj/bIYVz8kjerrCBG9EBriY0r6ov9OMmZVyyLC/+hHEP7FkPAo4qaeDgB981DRFV6NTmVXKyNwnus4uvwvm0f2su+7YmIlgDmVJ5OgpoMPSMPn2F4wqAXs/w/dDBwJBD9xlBFkSH/dOC7swKQNrs4PNiO/mcAav2hAcL3uZfR52YGamk1x2SekjZOYsYRUeXqHxJecxBKmZR83pOCKksPX2B25QAbqJ7Zc1y3aaC4R0GYmGVXmUcsoZpP9ZrAitHmIW5Hn32pvAHL/YXFAS3yvJfzO03e7/nauKnjtlpDUP8jTTP7ra/lIQC/Nwr5NujRKa8CTGeBNGfqFd6TYqYbsUfWz8JTwWfweqZ2UC1YHPu34OFcwLXIQxtO/tv3Zz0gLCSnglSqHmOsxvH8sWVrqBF7HdJhrHQCGNR6kFraenRC4N+zIcQ8BcoqKFsQe10a1LzmrqhS2YHhtvdfSX2wpaTBKyhDCc rQN3YMgy 4wWptDcj7CN73rZWvuKxkLmCpduSpHSCmf04/b4b+DCTCo3jwk5Tf+4X6iA5+PXwcmxM3pz5qX2NDyfNQPNqCCUTsMxHn97ZCXvd9pG+x1WJexKDqRNF5ZH/bpnRYvlVCZcKSNUDA1tkYdKgh3bknGn9eQlxdk60t0jH1JEYZVOscUI/pztiRVDxImDQH5WA1Z4kwLbKU3uCMvgESl7WsOn8ATOCN79afN7s18uOwqwebfbm+NoPX8z+VpNs4guGMDIVzMI6DemOa1yKbbM1F3kdZJAXUaf8rKkRk4XTSmY1t0r0Q7kOvtQVZ5DrYGB2vbqNRyPq9L/4D4V+qScLtb77SrhMtQlf+5dJ/rZ7rtjenAfWS/pydR6cpPofcdantDm+jbu/69F6uK3gnOGQxlEjTK7JlsBZ783pbIvgcH84S+yCG/JgdjUAkMYj/NafmmnJ7DWsGWuwHGMJ9b9kdZCCI3gMuYCVvBVvTRX5lB3lA1fS1Ufp4Pa0DqIJwJqD78Qn8kOAbyqLjaL8W4q//2B/r+OgJU05otgJMasPG3NUMydJAOixxQl4nli7AmJa6VUXzWWpzpW0OUp9WYPZJpSvCOjMnom9+gafQB7Hfv5hExes= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463760895-1382586557-1692081256=:4366 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE On Mon, 14 Aug 2023, Jann Horn wrote: > On Wed, Jul 12, 2023 at 6:42=E2=80=AFAM Hugh Dickins w= rote: > > Bring collapse_and_free_pmd() back into collapse_pte_mapped_thp(). > > It does need mmap_read_lock(), but it does not need mmap_write_lock(), > > nor vma_start_write() nor i_mmap lock nor anon_vma lock. All racing > > paths are relying on pte_offset_map_lock() and pmd_lock(), so use those= =2E >=20 > We can still have a racing userfaultfd operation at the "/* step 4: > remove page table */" point that installs a new PTE before the page > table is removed. >=20 > To reproduce, patch a delay into the kernel like this: >=20 >=20 > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 9a6e0d507759..27cc8dfbf3a7 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include >=20 > #include > #include > @@ -1617,6 +1618,11 @@ int collapse_pte_mapped_thp(struct mm_struct > *mm, unsigned long addr, > } >=20 > /* step 4: remove page table */ > + if (strcmp(current->comm, "DELAYME") =3D=3D 0) { > + pr_warn("%s: BEGIN DELAY INJECTION\n", __func__); > + mdelay(5000); > + pr_warn("%s: END DELAY INJECTION\n", __func__); > + } >=20 > /* Huge page lock is still held, so page table must remain empty = */ > pml =3D pmd_lock(mm, pmd); >=20 >=20 > And then run the attached reproducer against mm/mm-everything. You > should get this in dmesg: >=20 > [ 206.578096] BUG: Bad rss-counter state mm:000000000942ebea > type:MM_ANONPAGES val:1 Thanks a lot, Jann. I haven't thought about it at all yet; and just tried to reproduce, but haven't yet got the "BUG: Bad rss-counter": just see "Invalid argument" on the UFFDIO_COPY ioctl. Will investigate tomorrow. Hugh ---1463760895-1382586557-1692081256=:4366--