From: "mattock (Code Review)" Date: Thu, 21 Aug 2025 11:42:43 +0000 References: Reply-To: sasepp@...2783..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="PxUrDVUpNe8="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Add sample FFDH parameters file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --PxUrDVUpNe8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1147?usp=3Demail to review the following change. Change subject: Add sample FFDH parameters file ...................................................................... Add sample FFDH parameters file Change-Id: I13ad2b7da6b008bc692b1f08f502fc3fc57e7206 Signed-off-by: Samuli Sepp=C3=A4nen --- A sample/sample-keys/ffdhe2048.pem M tests/t_server_null_default.rc 2 files changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/47/1147/1 diff --git a/sample/sample-keys/ffdhe2048.pem b/sample/sample-keys/ffdhe204= 8.pem new file mode 100644 index 0000000..9b182b7 --- /dev/null +++ b/sample/sample-keys/ffdhe2048.pem @@ -0,0 +1,8 @@ +-----BEGIN DH PARAMETERS----- +MIIBCAKCAQEA//////////+t+FRYortKmq/cViAnPTzx2LnFg84tNpWp4TZBFGQz ++8yTnc4kmz75fS/jY2MMddj2gbICrsRhetPfHtXV/WVhJDP1H18GbtCFY2VVPe0a +87VXE15/V8k1mE8McODmi3fipona8+/och3xWKE2rec1MKzKT0g6eXq8CrGCsyT7 +YdEIqUuyyOP7uWrat2DX9GgdT0Kj3jlN9K5W7edjcrsZCwenyO4KbXCeAvzhzffi +7MA0BM0oNC9hkXL+nOmFg/+OTxIy7vKBg8P+OxtMb61zO7X8vC7CIAXFjvGDfRaD +ssbzSibBsu/6iGtCOGEoXJf//////////wIBAg=3D=3D +-----END DH PARAMETERS----- diff --git a/tests/t_server_null_default.rc b/tests/t_server_null_default.rc index 900f189..798cfd0 100755 --- a/tests/t_server_null_default.rc +++ b/tests/t_server_null_default.rc @@ -13,7 +13,7 @@ top_builddir=3D"${top_builddir:-..}" sample_keys=3D"${srcdir}/../sample/sample-keys" =20 -DH=3D"${sample_keys}/dh2048.pem" +DH=3D"${sample_keys}/ffdhe2048.pem" CA=3D"${sample_keys}/ca.crt" CLIENT_CERT=3D"${sample_keys}/client.crt" CLIENT_KEY=3D"${sample_keys}/client.key" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1147?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I13ad2b7da6b008bc692b1f08f502fc3fc57e7206 Gerrit-Change-Number: 1147 Gerrit-PatchSet: 1 Gerrit-Owner: mattock Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange --PxUrDVUpNe8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

mattock would like plaisthos and flichtenheld to review= this change.

V= iew Change

Add sample FFDH parameters file

Change-Id: I13ad2b7da= 6b008bc692b1f08f502fc3fc57e7206
Signed-off-by: Samuli Sepp=C3=A4nen <= sasepp@...2705...>
---
A sample/sample-keys/ffdhe2048.pem
M tes= ts/t_server_null_default.rc
2 files changed, 9 insertions(+), 1 deletion= (-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/=
47/1147/1
diff --git a/sample/sample-keys/ffdhe2048.pem b/sample/sa=
mple-keys/ffdhe2048.pem
new file mode 100644
index 0000000..9b182b7
--- /dev/null
+++ = b/sample/sample-keys/ffdhe2048.pem
@@ -0,0 +1,8 @@+-----BEGIN DH PARAMETERS----= -
+MIIBCAKCAQEA//////= ////+t+FRYortKmq/cViAnPTzx2LnFg84tNpWp4TZBFGQz
++8yTnc4kmz75fS/jY2MMddj2gbICrsRhetPfHtXV/WVhJDP1= H18GbtCFY2VVPe0a
+87V= XE15/V8k1mE8McODmi3fipona8+/och3xWKE2rec1MKzKT0g6eXq8CrGCsyT7
+YdEIqUuyyOP7uWrat2DX9GgdT0Kj3jlN9= K5W7edjcrsZCwenyO4KbXCeAvzhzffi
+7MA0BM0oNC9hkXL+nOmFg/+OTxIy7vKBg8P+OxtMb61zO7X8vC7CIAXFjvGDfRa= D
+ssbzSibBsu/6iGtCOG= EoXJf//////////wIBAg=3D=3D
+-----END DH PARAMETERS-----
diff --git a/tests/t_ser= ver_null_default.rc b/tests/t_server_null_default.rc
index = 900f189..798cfd0 100755
--- a/tests/t_server_null_default.r= c
+++ b/tests/t_server_null_default.rc
@@ -= 13,7 +13,7 @@
top_builddir=3D"${top_builddir:-..}&quo= t;
sample_keys=3D"${srcdir}/../sample/sample-keys&quo= t;

-D= H=3D"${sample_keys}/dh2048.pem"
+DH=3D"${sample_keys}/ffdhe2048.pem"<= br> CA=3D"${sample_keys}/ca.crt"
CLIENT_CE= RT=3D"${sample_keys}/client.crt"
CLIENT_KEY=3D&q= uot;${sample_keys}/client.key"

To = view, visit change 1147. To unsubscribe, or for help writing mail filters, visi= t settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I13ad2b7da6b008bc692b1f08f50= 2fc3fc57e7206
Gerrit-Change-Number: 1147
Gerrit-PatchSet: 1
Gerrit-Owner: mattock <sasepp@...2783...>= ;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newchange
--PxUrDVUpNe8=--