Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C80DC433EF for ; Wed, 13 Apr 2022 07:45:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 87FC481870; Wed, 13 Apr 2022 09:45:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1649835917; bh=1ZHQYZ+GwG7edI4P9GHLzDHyvAFRTWcm4lU5dqvlQUA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=xNl/DZyUGBSomCBc6raGnxTUrreEEX2+NNicP+kK7gNuLqbj8/DrSrU+8oyM/g7ki 2cW7TZ72yJyo8ahRstkd+J0i6rK3Amrkqoj0Ovl40Sbdv3hrNacnolgcBWhVijmzfv LVXYNBFthEoEnN9MB8/3jMkyN6RjeO+gwnZzqmeSZpllPgksA9zaht0jSed7CYg3bn orajvypXqWFpJZav/gS2D9goE1qgMrlQyl/lXgIOT56C9qcIY7RaIJYhN/tz8vKKRv QLDPURQol8lt14k1xePOFs5aSYGSIby/PYzGiRszp+wUw4Abf+qWqFFrpiAfWk7uN5 JTMSzJdIyTDEA== Received: from [IPV6:2001:a61:618e:a001:4533:dcfd:27c0:598a] (unknown [IPv6:2001:a61:618e:a001:4533:dcfd:27c0:598a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sbabic@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id B09AD811A6; Wed, 13 Apr 2022 09:45:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1649835915; bh=1ZHQYZ+GwG7edI4P9GHLzDHyvAFRTWcm4lU5dqvlQUA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jB66Dbi1DubOKlN97agDs+mL7avq8myz6k2lHJXd89qxIoe7PgJRLg4wBzoHz29MA CiMvIMLN75a3YYaMaZtap3uHBN51Gwi7462L97kdtmoANuiYMmVQ9HqnGhtqIosjRE EZ5WHrDlu7S+UFMUWNd9t7QjY/3QtbuleRWwP8j078HCKwO8s5Zc2Ohs3gRCKi0PC/ 5uyeL3+hHSGqSpjeJn2j8PlHrgEqRuXtq8tQhopjOEt7o2X+RnKBhubnwFiHGt6spg mM4xZep4oyQqc7Scn3CWZRfJJxrqyiq2l1hVujsAvvEod1bxRuC5dLQyNKr89unaVV Q9pUNWwsZ3BWA== Message-ID: Date: Wed, 13 Apr 2022 09:45:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH V2 19/26] imx: imx8ulp_evk: Power down the domains may used in u-boot Content-Language: de-DE To: "Peng Fan (OSS)" , Stefano Babic Cc: "festevam@gmail.com" , "u-boot@lists.denx.de" , dl-uboot-imx , Ye Li References: <20220406063031.21960-1-peng.fan@oss.nxp.com> <20220406063031.21960-20-peng.fan@oss.nxp.com> <4963df3b-ba38-5d33-ab57-ecb5344971a6@oss.nxp.com> From: Stefano Babic In-Reply-To: <4963df3b-ba38-5d33-ab57-ecb5344971a6@oss.nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Peng, On 13.04.22 05:00, Peng Fan (OSS) wrote: > Hi Stefano, > > On 2022/4/13 1:10, Stefano Babic wrote: >> Hi Peng,Ye, >> >> On 06.04.22 08:30, Peng Fan (OSS) wrote: >>> From: Ye Li >>> >>> Since ATF power domain will hold the enable counter for each power >>> domain, >>> We need to power off them before entering kernel to avoid this >>> power domain can't be really powered off. >>> >>> Signed-off-by: Ye Li >>> Signed-off-by: Peng Fan >>> --- >>>    board/freescale/imx8ulp_evk/imx8ulp_evk.c | 30 >>> +++++++++++++++++++++++ >>>    1 file changed, 30 insertions(+) >>> >>> diff --git a/board/freescale/imx8ulp_evk/imx8ulp_evk.c >>> b/board/freescale/imx8ulp_evk/imx8ulp_evk.c >>> index b61a4cfbe8d..1bd308148f3 100644 >>> --- a/board/freescale/imx8ulp_evk/imx8ulp_evk.c >>> +++ b/board/freescale/imx8ulp_evk/imx8ulp_evk.c >>> @@ -13,6 +13,8 @@ >>>    #include >>>    #include >>>    #include >>> +#include >>> +#include >> >> But which patch is adding the file above ? I cannot find it, it is not >> part of this series and of course build is broken without it. > > V5 patchset should not have such issue. I just see you already picked up > V5 in your repo. > Which series are you talking about ? This series is in V2, and yes, I merged the whole series with the exception of this patch, but none of the applied patches added imx8ulp-power.h. Regards, Stefano > Thanks, > Peng. > >> >> Best regards, >> Stefano >> >>>    DECLARE_GLOBAL_DATA_PTR; >>> @@ -129,3 +131,31 @@ int board_late_init(void) >>>    { >>>        return 0; >>>    } >>> + >>> +void board_quiesce_devices(void) >>> +{ >>> +    /* Disable the power domains may used in u-boot before entering >>> kernel */ >>> +#if CONFIG_IS_ENABLED(POWER_DOMAIN) >>> +    struct udevice *scmi_devpd; >>> +    int ret, i; >>> +    struct power_domain pd; >>> +    ulong ids[] = { IMX8ULP_PD_FLEXSPI2, IMX8ULP_PD_USB0, >>> IMX8ULP_PD_USDHC0, >>> +            IMX8ULP_PD_USDHC1, IMX8ULP_PD_USDHC2_USB1, >>> IMX8ULP_PD_DCNANO, >>> +            IMX8ULP_PD_MIPI_DSI }; >>> + >>> +    ret = uclass_get_device(UCLASS_POWER_DOMAIN, 0, &scmi_devpd); >>> +    if (ret) { >>> +        printf("Cannot get scmi devpd: err=%d\n", ret); >>> +        return; >>> +    } >>> + >>> +    pd.dev = scmi_devpd; >>> + >>> +    for (i = 0; i < ARRAY_SIZE(ids); i++) { >>> +        pd.id = ids[i]; >>> +        ret = power_domain_off(&pd); >>> +        if (ret) >>> +            printf("power_domain_off %lu failed: err=%d\n", ids[i], >>> ret); >>> +    } >>> +#endif >>> +} >> -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================