Message-ID: Date: Tue, 28 Jun 2022 16:29:21 +0200 MIME-Version: 1.0 Content-Language: en-GB References: <20220624083809.23487-1-a@...2181...> <20220624083809.23487-12-a@...2181...> From: Arne Schwabe In-Reply-To: <20220624083809.23487-12-a@...2181...> Subject: Re: [Openvpn-devel] [PATCH 11/25] dco: split option parsing routines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Antonio Quartulli , openvpn-devel@lists.sourceforge.net Am 24.06.22 um 10:37 schrieb Antonio Quartulli: > + if (!finish_options(c)) > + { > + msg(D_TLS_ERRORS, "ERROR: Failed to finish option processing"); > + return false; > + } This error is a bit too generic for my taste. Can we make it more specific? Like "Failed to apply options when finalising tun setup" or something? Arne