From: "flichtenheld (Code Review)" Date: Wed, 6 Dec 2023 17:30:24 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, gert@...1296... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="QrN1PPELMlU="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: cron2 , openvpn-devel --QrN1PPELMlU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/466?usp=3Demail ) Change subject: Implement the --tls-export-cert feature ...................................................................... Patch Set 2: Code-Review-1 (6 comments) File doc/man-sections/script-options.rst: http://gerrit.openvpn.net/c/openvpn/+/466/comment/738f9728_f9eb156f : PS2, Line 427: Adds a an environment variables ``peer_cert_{x}`` (and an = alias Remove "a" File src/openvpn/ssl_verify.c: http://gerrit.openvpn.net/c/openvpn/+/466/comment/dd7a5b9a_bf660274 : PS2, Line 466: /* export the certificate itself as pem when the enabled= */ missing words? http://gerrit.openvpn.net/c/openvpn/+/466/comment/f487e7c8_793bcb7e : PS2, Line 477: bool ret =3D true; Can combine with the next line. http://gerrit.openvpn.net/c/openvpn/+/466/comment/2e703085_bdc2ffba : PS2, Line 602: * these variables defined */ can replace repetition of "these variables" with "them" File src/openvpn/ssl_verify_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/466/comment/74783133_a96d6da5 : PS2, Line 225: * The only way to is directly access the DER encoded ra= w certificate "to is" -> "is to" http://gerrit.openvpn.net/c/openvpn/+/466/comment/b48e3170_e0e585b4 : PS2, Line 230: * using needing 3 times the space for the base64 and 10= 0 bytes for the drop one of "using needing" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/466?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b4cebd0bf19ce2 Gerrit-Change-Number: 466 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Comment-Date: Wed, 06 Dec 2023 17:30:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --QrN1PPELMlU= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, plaisthos.

Patch set 2:Code-Review -1=

Vi= ew Change

6 comments:

  • File doc/man-sections/script-op= tions.rst:

  • File src/openvpn/s= sl_verify.c:

  • File src/openvpn/ssl_verify_mbedtls.c:

    • Patch Set #2, Line 225: * The only way to is directly acc= ess the DER encoded raw certificate

      "to is" -> "is to"

      =
    • Patch Set #2, Line 230: * using needing 3 times the space for the base64 and 10= 0 bytes for the

      drop one of "using needing"

T= o view, visit change 466. To unsubscribe, or for help writing mail filters, visi= t settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b= 4cebd0bf19ce2
Gerrit-Change-Number: 466
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Comment-Date: Wed, 06 Dec 2023 17:30:24= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--QrN1PPELMlU=--